Bug 2184480 - Review Request: php-splitbrain-php-jsstrip - PHP-based JavaScript compressor
Summary: Review Request: php-splitbrain-php-jsstrip - PHP-based JavaScript compressor
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/%{author}/%{project}
Whiteboard:
Depends On:
Blocks: 2184444
TreeView+ depends on / blocked
 
Reported: 2023-04-04 20:13 UTC by Artur Frenszek-Iwicki
Modified: 2023-04-24 02:47 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-04-24 02:47:15 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)
phpcompatinfo analyse (4.83 KB, text/plain)
2023-04-14 13:36 UTC, Remi Collet
no flags Details
review checklist (4.94 KB, text/plain)
2023-04-14 13:36 UTC, Remi Collet
no flags Details

Description Artur Frenszek-Iwicki 2023-04-04 20:13:31 UTC
spec: https://svgames.pl/fedora/php-splitbrain-php-jsstrip-1.0.1-1/php-splitbrain-php-jsstrip.spec
srpm: https://svgames.pl/fedora/php-splitbrain-php-jsstrip-1.0.1-1/php-splitbrain-php-jsstrip-1.0.1-1.fc38.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=99529494

Description: PHP JSStrip is a PHP port of the original Python tool, jsstrip.py. It is a library for removing comments and whitespace from a JavaScript file. You might want to do this to optimize size and performance, or to make a file harder to read.

Fedora Account System Username: suve

Comment 1 Jakub Kadlčík 2023-04-04 20:20:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5743617
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184480-php-splitbrain-php-jsstrip/fedora-rawhide-x86_64/05743617-php-splitbrain-php-jsstrip/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Remi Collet 2023-04-14 13:36:15 UTC
Created attachment 1957495 [details]
phpcompatinfo analyse

Comment 3 Remi Collet 2023-04-14 13:36:41 UTC
Created attachment 1957496 [details]
review checklist

Comment 4 Remi Collet 2023-04-14 13:40:06 UTC
[x]: Package complies to the Packaging Guidelines


Can fix the "mixed-use-of-spaces-and-tabs" from rpmlint

Also, I don't think "zip" is the best format on linux ;)
(see tar with --exclude-vcs option)

Comment 5 Remi Collet 2023-04-14 13:42:42 UTC
==== APPROVED ====

Comment 6 Fedora Admin user for bugzilla script actions 2023-04-15 09:36:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-php-jsstrip

Comment 7 Fedora Update System 2023-04-15 11:01:40 UTC
FEDORA-2023-49e98f652e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-49e98f652e

Comment 8 Fedora Update System 2023-04-16 03:35:10 UTC
FEDORA-2023-49e98f652e has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-49e98f652e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-49e98f652e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-04-24 02:47:15 UTC
FEDORA-2023-49e98f652e has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.