Spec URL: https://smani.fedorapeople.org/review/python-flask-mongoengine.spec SRPM URL: https://smani.fedorapeople.org/review/python-flask-mongoengine-1.0.0-1.fc39.src.rpm Description: Flask extension that provides integration with MongoEngine Fedora Account System Username: smani
Copr build: https://copr.fedorainfracloud.org/coprs/build/5744522 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184590-python-flask-mongoengine/fedora-rawhide-x86_64/05744522-python-flask-mongoengine/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://smani.fedorapeople.org/review/python-flask-mongoengine.spec SRPM URL: https://smani.fedorapeople.org/review/python-flask-mongoengine-1.0.0-1.fc39.src.rpm
Created attachment 1955813 [details] The .spec file difference from Copr build 5744522 to 5744571
Copr build: https://copr.fedorainfracloud.org/coprs/build/5744571 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184590-python-flask-mongoengine/fedora-rawhide-x86_64/05744571-python-flask-mongoengine/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fedora-review mechanism showed the packaged already existed but is currently retired five years ago so it is basically a pull out of retirement. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* MIT License". 38 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-flask- mongoengine/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-flask-mongoengine-1.0.0-1.fc39.noarch.rpm python-flask-mongoengine-1.0.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0w8fxdf2')] checks: 31, packages: 2 python3-flask-mongoengine.noarch: W: spurious-executable-perm /usr/share/doc/python3-flask-mongoengine/README.rst 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python3-flask-mongoengine.noarch: W: spurious-executable-perm /usr/share/doc/python3-flask-mongoengine/README.rst 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/f/flask-mongoengine/flask-mongoengine-1.0.0.tar.gz : CHECKSUM(SHA256) this package : ce68726d2be8d88006e88f17e4be3b7ad07c79ca8dedb60653d3dab5d9485840 CHECKSUM(SHA256) upstream package : ce68726d2be8d88006e88f17e4be3b7ad07c79ca8dedb60653d3dab5d9485840 Requires -------- python3-flask-mongoengine (rpmlib, GLIBC filtered): python(abi) python3.11dist(flask) python3.11dist(flask-wtf) python3.11dist(mongoengine) python3.11dist(wtforms) python3.11dist(wtforms[email]) Provides -------- python3-flask-mongoengine: python-flask-mongoengine python3-flask-mongoengine python3.11-flask-mongoengine python3.11dist(flask-mongoengine) python3dist(flask-mongoengine) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-flask-mongoengine --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: SugarActivity, Java, Haskell, R, Ocaml, PHP, C/C++, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Correct, this is a unretirement re-rereview.
Based on the review, the package is ready for approval. Note in the future, use rpmautospec macros i.e. %autorelease and %autochangelog (generate changelog file if needed with "rpmautospec generate-changelog" command). Thus APPROVED.
Thanks for the review! Personally I still prefer the traditional explicit Release/Changelog, but I might look into it again at some point.