Spec URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas-44.0-1.fc39.src.rpm Description: MinGW Windows gsettings-desktop-schemas Fedora Account System Username: smani
Copr build: https://copr.fedorainfracloud.org/coprs/build/5744539 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184592-mingw-gsettings-desktop-schemas/fedora-rawhide-x86_64/05744539-mingw-gsettings-desktop-schemas/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
@benson_muite Gentle ping, let me know if I can review anything in exchange.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-gsettings-desktop-schemas : /usr/i686-w64-mingw32/sys- root/mingw/include/gsettings-desktop-schemas/gdesktop-enums.h mingw64-gsettings-desktop-schemas : /usr/x86_64-w64-mingw32/sys- root/mingw/include/gsettings-desktop-schemas/gdesktop-enums.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License", "GNU Lesser General Public License v2.1 or later". 105 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/mingw-gsettings-desktop- schemas/2184592-mingw-gsettings-desktop-schemas/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/i686-w64-mingw32/sys- root/mingw/share/GConf, /usr/i686-w64-mingw32/sys- root/mingw/share/GConf/gsettings, /usr/x86_64-w64-mingw32/sys- root/mingw/share/GConf, /usr/x86_64-w64-mingw32/sys- root/mingw/share/GConf/gsettings [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/i686-w64-mingw32/sys- root/mingw/share/glib-2.0/schemas, /usr/x86_64-w64-mingw32/sys- root/mingw/share/GConf, /usr/x86_64-w64-mingw32/sys- root/mingw/share/glib-2.0, /usr/x86_64-w64-mingw32/sys- root/mingw/share/GConf/gsettings, /usr/x86_64-w64-mingw32/sys- root/mingw/share/glib-2.0/schemas, /usr/i686-w64-mingw32/sys- root/mingw/share/GConf, /usr/i686-w64-mingw32/sys- root/mingw/share/GConf/gsettings, /usr/i686-w64-mingw32/sys- root/mingw/share/glib-2.0 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-gsettings-desktop-schemas , mingw64-gsettings-desktop-schemas [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: mingw32-gsettings-desktop-schemas : /usr/i686-w64-mingw32/sys- root/mingw/share/pkgconfig/gsettings-desktop-schemas.pc mingw64-gsettings-desktop-schemas : /usr/x86_64-w64-mingw32/sys- root/mingw/share/pkgconfig/gsettings-desktop-schemas.pc [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define release_version %(echo %{version} | awk -F. '{print $1}') [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-gsettings-desktop-schemas-44.0-1.fc39.noarch.rpm mingw64-gsettings-desktop-schemas-44.0-1.fc39.noarch.rpm mingw-gsettings-desktop-schemas-44.0-1.fc39.src.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmvk_ia71')] checks: 31, packages: 3 mingw32-gsettings-desktop-schemas.noarch: W: no-documentation mingw64-gsettings-desktop-schemas.noarch: W: no-documentation mingw32-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/gsettings-desktop-schemas/gdesktop-enums.h mingw32-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/share/pkgconfig/gsettings-desktop-schemas.pc mingw64-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsettings-desktop-schemas/gdesktop-enums.h mingw64-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig/gsettings-desktop-schemas.pc ==================================== 3 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 2.8 s ==================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 mingw64-gsettings-desktop-schemas.noarch: W: no-documentation mingw32-gsettings-desktop-schemas.noarch: W: no-documentation mingw64-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsettings-desktop-schemas/gdesktop-enums.h mingw64-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig/gsettings-desktop-schemas.pc mingw32-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/gsettings-desktop-schemas/gdesktop-enums.h mingw32-gsettings-desktop-schemas.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/share/pkgconfig/gsettings-desktop-schemas.pc 2 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 0.2 s Source checksums ---------------- https://download.gnome.org/sources/gsettings-desktop-schemas/44/gsettings-desktop-schemas-44.0.tar.xz : CHECKSUM(SHA256) this package : eb2de45cad905994849e642a623adeb75d41b21b0626d40d2a07b8ea281fec0e CHECKSUM(SHA256) upstream package : eb2de45cad905994849e642a623adeb75d41b21b0626d40d2a07b8ea281fec0e Requires -------- mingw32-gsettings-desktop-schemas (rpmlib, GLIBC filtered): mingw32-pkg-config mingw64-gsettings-desktop-schemas (rpmlib, GLIBC filtered): mingw64-pkg-config Provides -------- mingw32-gsettings-desktop-schemas: mingw32-gsettings-desktop-schemas mingw64-gsettings-desktop-schemas: mingw64-gsettings-desktop-schemas Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2184592 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, fonts, Perl, PHP, Ocaml, R, Ruby, Haskell, Python, Java, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: Sorry for the delay. a) Should some of the directories be co-owned, or an explicit requires on packages which own these directories be included? b) Should the NEWS and README be packaged as documentation? c) Should translation files also be packaged? d) Should %global be used instead of %define ?
> - Header files in -devel subpackage, if present. This does not apply to mingw packages as they are pure development packages.
Ok on header files. Maybe worth updating documentation for MingGW packages and possibly also fedora-review. Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2188047 would be appreciated.
I missed you additional comments: > a) Should some of the directories be co-owned, or an explicit requires on packages which own these directories be included? Fixed b) Should the NEWS and README be packaged as documentation? According to https://docs.fedoraproject.org/en-US/packaging-guidelines/MinGW/#_files_which_are_already_part_of_native_packages these should be omitted. c) Should translation files also be packaged? d) Should %global be used instead of %define ? Changed Spec URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas-44.0-2.fc39.src.rpm %changelog * Fri Apr 21 2023 Sandro Mani <manisandro> - 44.0-2 - Package locale files - Add dir ownership - Change %%define to %%global
Created attachment 1958781 [details] The .spec file difference from Copr build 5744539 to 5812667
Copr build: https://copr.fedorainfracloud.org/coprs/build/5812667 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184592-mingw-gsettings-desktop-schemas/fedora-rawhide-x86_64/05812667-mingw-gsettings-desktop-schemas/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Above build failed because it could not find translations.
Ops forgot to BR gettext: Spec URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas-44.0-3.fc39.src.rpm %changelog * Sat Apr 22 2023 Sandro Mani <manisandro> - 44.0-3 - BR: gettext
fedora-review-service-build
[fedora-review-service-build]
Spec URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas-44.0-3.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5853194 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184592-mingw-gsettings-desktop-schemas/fedora-rawhide-x86_64/05853194-mingw-gsettings-desktop-schemas/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5853204 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184592-mingw-gsettings-desktop-schemas/fedora-rawhide-x86_64/05853204-mingw-gsettings-desktop-schemas/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Ping?
Builds on all architectures: https://copr.fedorainfracloud.org/coprs/fed500/mingw-gsettings-desktop-schemas/build/5880441/ Still get warnings: [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/x86_64-w64-mingw32/sys- root/mingw/share/GConf, /usr/i686-w64-mingw32/sys- root/mingw/share/GConf [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/i686-w64-mingw32/sys- root/mingw/share/GConf, /usr/x86_64-w64-mingw32/sys- root/mingw/share/GConf
Whops, I wrote %dir %{mingwXX_datadir}/ instead of %dir %{mingwXX_datadir}/GConf/ Spec URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-gsettings-desktop-schemas-44.0-4.fc39.src.rpm %changelog * Fri May 05 2023 Sandro Mani <manisandro> - 44.0-4 - Fix %%{mingw_datadir}/GConf/ ownership
Created attachment 1962536 [details] The .spec file difference from Copr build 5853204 to 5886834
Copr build: https://copr.fedorainfracloud.org/coprs/build/5886834 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184592-mingw-gsettings-desktop-schemas/fedora-rawhide-x86_64/05886834-mingw-gsettings-desktop-schemas/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-gsettings-desktop-schemas
Thanks!