Bug 2184633 - Review Request: rust-logging_timer_proc_macros - Proc-macro implementation for the logging_timer crate
Summary: Review Request: rust-logging_timer_proc_macros - Proc-macro implementation f...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/logging_time...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-05 09:28 UTC by Mads Kiilerich
Modified: 2023-05-02 22:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-02 22:14:59 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Mads Kiilerich 2023-04-05 09:28:17 UTC
Spec URL: https://gist.githubusercontent.com/kiilerix/35542358671335b4cbe6ee251fa60ad8/raw/4c542b030c35aac2a355b82a672cc69403b7448d/rust-logging_timer_proc_macros.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3505/99533505/rust-logging_timer_proc_macros-1.1.0-1.fc39.src.rpm
Description: Proc-macro implementation for the logging_timer crate.
Fedora Account System Username: kiilerix

This packaging of https://crates.io/crates/logging_timer_proc_macros is needed for packaging of https://crates.io/crates/logging_timer which is needed for updating the Mercurial package to version 6.4 .

Comment 1 Jakub Kadlčík 2023-04-05 10:05:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5745180
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184633-rust-logging_timer_proc_macros/fedora-rawhide-x86_64/05745180-rust-logging_timer_proc_macros/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-04-05 14:08:27 UTC
Please post a link to the raw spec file, not the GitHub UI.

Comment 3 Fabio Valentini 2023-04-05 14:27:24 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
? test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-04-05 14:46:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-logging_timer_proc_macros

Comment 5 Fabio Valentini 2023-05-02 22:14:59 UTC
This package has been imported and built.


Note You need to log in before you can comment on or make changes to this bug.