Bug 2184724 - Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator
Summary: Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/KhronosGroup/SPIRV...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-05 13:59 UTC by František Zatloukal
Modified: 2023-04-12 09:09 UTC (History)
3 users (show)

Fixed In Version: spirv-llvm15.0-translator-15.0.0-1.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-05 14:33:31 UTC
Type: Bug
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Comment 1 Jakub Kadlčík 2023-04-05 14:03:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5745890
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184724-spirv-llvm15.0-translator/fedora-rawhide-x86_64/05745890-spirv-llvm15.0-translator/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-04-05 14:04:30 UTC
As this is a versioned variant of existing packages, it appears everything looks good policy-wise and packaging-wise.

PACKAGE APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-04-05 14:10:25 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/spirv-llvm15.0-translator

Comment 4 Fabio Valentini 2023-04-07 16:29:18 UTC
(In reply to Neal Gompa from comment #2)
> As this is a versioned variant of existing packages, it appears everything
> looks good policy-wise and packaging-wise.
> 
> PACKAGE APPROVED.

I'm confused. This package's name is clearly against the Naming Guidelines for compat packages.
It should have been named spirv-llvm-translator15, just like the other new compat packages (llvm15, lld15, clang15, etc.). Putting the compat version into the *middle* of the name is awful (and using "15.0" for the compat "infix" instead of "15" like the other LLVM packages is also needlessly diverging...)

Comment 5 František Zatloukal 2023-04-12 09:09:58 UTC
(In reply to Fabio Valentini from comment #4)
> (In reply to Neal Gompa from comment #2)
> > As this is a versioned variant of existing packages, it appears everything
> > looks good policy-wise and packaging-wise.
> > 
> > PACKAGE APPROVED.
> 
> I'm confused. This package's name is clearly against the Naming Guidelines
> for compat packages.
> It should have been named spirv-llvm-translator15, just like the other new
> compat packages (llvm15, lld15, clang15, etc.). Putting the compat version
> into the *middle* of the name is awful (and using "15.0" for the compat
> "infix" instead of "15" like the other LLVM packages is also needlessly
> diverging...)

Yeah, sorry for that, I somehow had spirv-llvm8.0-translator in my muscle memory (llvm was llvm8.0 back then), and didn't think about this. Shall we create a new package and do the obsolete/provide fu? This isn't something user would normally have to manually touch, and something that would go away once intel-igc supports llvm 16.


Note You need to log in before you can comment on or make changes to this bug.