Bug 2185850 - accountsservice: C99 compatibility issue in bundled copy of mocklib
Summary: accountsservice: C99 compatibility issue in bundled copy of mocklib
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: accountsservice
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2023-04-11 12:11 UTC by Florian Weimer
Modified: 2023-04-11 15:16 UTC (History)
5 users (show)

Fixed In Version: accountsservice-23.13.9-1.fc39
Clone Of:
Environment:
Last Closed: 2023-04-11 14:30:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
freedesktop.org Gitlab accountsservice accountsservice merge_requests 131 0 None opened Fix compiler warnings 2023-04-11 14:15:32 UTC

Description Florian Weimer 2023-04-11 12:11:20 UTC
The build fails with a strict C99 compiler:

gcc -Isubprojects/mocklibc-1.0/src/mocklibc-debug-netgroup.p -Isubprojects/mocklibc-1.0/src -I../subprojects/mocklibc-1.0/src -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MQ subprojects/mocklibc-1.0/src/mocklibc-debug-netgroup.p/netgroup-debug.c.o -MF subprojects/mocklibc-1.0/src/mocklibc-debug-netgroup.p/netgroup-debug.c.o.d -o subprojects/mocklibc-1.0/src/mocklibc-debug-netgroup.p/netgroup-debug.c.o -c ../subprojects/mocklibc-1.0/src/netgroup-debug.c
../subprojects/mocklibc-1.0/src/netgroup-debug.c: In function ‘netgroup_debug_print_entry’:
../subprojects/mocklibc-1.0/src/netgroup-debug.c:25:3: error: implicit declaration of function ‘print_indent’
   25 |   print_indent(stream, indent);
      |   ^~~~~~~~~~~~

This is the same issue that was reported here: <https://code.google.com/archive/p/mocklibc/issues/3> But Google seems to have deleted the patch.

I don't know how to integrate a fix into the meson build system that accountsservice uses.

Comment 1 Ray Strode [halfline] 2023-04-11 14:30:13 UTC
* Tue Apr 11 2023 Ray Strode <rstrode> - 23.13.9-1
- Update to 23.13.9
- Fix C99 compile error
  Resolves: #2185850

Comment 2 Florian Weimer 2023-04-11 15:16:49 UTC
Thanks, verified with the instrumented compilers.


Note You need to log in before you can comment on or make changes to this bug.