Bug 2186056 - Review Request: python-pylint-venv - Make pylint respect virtualenvs
Summary: Review Request: python-pylint-venv - Make pylint respect virtualenvs
Keywords:
Status: CLOSED COMPLETED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Felix Wang
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/jgosmann/pylint-venv/
Whiteboard:
Depends On:
Blocks: 2106899
TreeView+ depends on / blocked
 
Reported: 2023-04-12 01:45 UTC by Jonathan Wright
Modified: 2023-07-05 05:47 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-05 05:47:44 UTC
Type: ---
Embargoed:
topazus: fedora-review+


Attachments (Terms of Use)

Description Jonathan Wright 2023-04-12 01:45:38 UTC
Spec URL: https://jonathanspw.fedorapeople.org/python-pylint-venv.spec
SRPM URL: https://jonathanspw.fedorapeople.org/python-pylint-venv-3.0.1-1.fc39.src.rpm

Description: Make pylint respect virtualenvs
Fedora Account System Username: jonathanspw

Comment 1 Jakub Kadlčík 2023-04-12 01:50:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5774681
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2186056-python-pylint-venv/fedora-rawhide-x86_64/05774681-python-pylint-venv/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Felix Wang 2023-04-13 14:30:58 UTC
No real tests existed on the upstream, so it use the %pyproject_check_import to check the importable installed modules. No issue with the license. Looking into the auto-generated review.txt, the package seems good with me, so I approved the package.

Comment 3 Felix Wang 2023-04-13 14:35:30 UTC
Can you take the review request of python-qcengine package for exchange? see https://bugzilla.redhat.com/show_bug.cgi?id=2186489

Comment 4 Fedora Admin user for bugzilla script actions 2023-04-13 17:39:38 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pylint-venv


Note You need to log in before you can comment on or make changes to this bug.