Bug 2187249 - 3.13.1: PACKAGE_VERSION redefined #729
Summary: 3.13.1: PACKAGE_VERSION redefined #729
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fuse3
Version: 38
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-17 08:53 UTC by Marc-Andre Lureau
Modified: 2023-04-24 02:47 UTC (History)
4 users (show)

Fixed In Version: fuse3-3.14.1-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-24 02:47:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Marc-Andre Lureau 2023-04-17 08:53:22 UTC
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0
Build Identifier: 

Upstream #729:
https://github.com/libfuse/libfuse/issues/729

FUSE 3.13.1 is breaking compilation in other packages, e.g. open-vm-tools (last-known-good 3.13.0):

gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"12.1.5\" -DPACKAGE_STRING=\"open-vm-tools\ 12.1.5\" -DPACKAGE_BUGREPORT=\"open-vm-tools-devel.net\" -DPACKAGE_URL=\"\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DPACKAGE=\"open-vm-tools\" -DVERSION=\"12.1.5\" -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_FUSE3=1 -DFUSE_USE_VERSION=35 -DHAVE_X11_SM_SMLIB_H=1 -DHAVE_X11_ICE_ICELIB_H=1 -DHAVE_X11_EXTENSIONS_XCOMPOSITE_H=1 -DHAVE_DLOPEN=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DNO_DNET=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -I.   -I/home/abuild/rpmbuild/BUILD/open-vm-tools-12.1.5/open-vm-tools/lib/include -I/home/abuild/rpmbuild/BUILD/open-vm-tools-12.1.5/open-vm-tools/lib/include  -DUSING_AUTOCONF=1 -DOPEN_VM_TOOLS -DUSE_VGAUTH  -DNO_ICU -DVMX86_TOOLS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -D_DEFAULT_SOURCE -DENABLE_RESOLUTIONKMS -Dvmblock_fuse -U_XOPEN_SOURCE -D_XOPEN_SOURCE=600 -DUSERLEVEL -D_FILE_OFFSET_BITS=64 -I/usr/include/fuse3  -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I../modules/shared/vmblock -I. -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -Wno-unused-local-typedefs -Wno-unused-but-set-variable -Wno-deprecated-declarations -Wno-sizeof-pointer-memaccess -Wno-cpp -fPIE -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -Wno-deprecated-declarations -Wno-unused-const-variable -Wno-unused-but-set-variable -c -o fsops.o fsops.c
[  309s] In file included from /usr/include/fuse3/fuse_common.h:17,
[  309s]                  from /usr/include/fuse3/fuse.h:19,
[  309s]                  from fsops.h:46,
[  309s]                  from fsops.c:39:
[  309s] /usr/include/fuse3/fuse_config.h:42: error: "PACKAGE_VERSION" redefined [-Werror]
[  309s]    42 | #define PACKAGE_VERSION "3.13.1"
[  309s]       | 
[  309s] <command-line>: note: this is the location of the previous definition
[  309s] cc1: all warnings being treated as errors
[  309s] make[1]: *** [Makefile:582: fsops.o] Error 1

PACKAGE_VERSION (and basically anything from config.h) should never be leaked directly into public APIs.

Please update to 3.14.x

Reproducible: Always

Comment 1 Richard W.M. Jones 2023-04-19 15:59:51 UTC
This was already fixed in Rawhide:

https://src.fedoraproject.org/rpms/fuse3/c/11caa83e9f700e083804f3e1420949f5b8314802?branch=rawhide

As there seems to be no reason to stick with older FUSE versions in the
other branches, I will backport this work to Fedora 38.

Comment 2 Richard W.M. Jones 2023-04-19 16:39:15 UTC
F38 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=100138268

Also here's an F37 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=100138273

The F37 change is a larger version bump and I'm reluctant to do that on
what is now a stable Fedora branch.  Note also F37 is not affected by this bug.

Comment 3 Tom "spot" Callaway 2023-04-19 16:48:11 UTC
I think moving 3.14.* to F38 is fine, if you have the cycles, please feel free to go ahead and do it.

Comment 4 Fedora Update System 2023-04-19 17:12:05 UTC
FEDORA-2023-28aa7fa96e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-28aa7fa96e

Comment 5 Fedora Update System 2023-04-20 04:30:12 UTC
FEDORA-2023-28aa7fa96e has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-28aa7fa96e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-28aa7fa96e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-04-24 02:47:26 UTC
FEDORA-2023-28aa7fa96e has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.