Bug 2187643 - Review Request: perl-Hash-Ordered - Perl class for ordered hashes
Summary: Review Request: perl-Hash-Ordered - Perl class for ordered hashes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2187275
TreeView+ depends on / blocked
 
Reported: 2023-04-18 09:52 UTC by Petr Pisar
Modified: 2023-05-10 02:28 UTC (History)
4 users (show)

Fixed In Version: perl-Hash-Ordered-0.014-1.fc39
Clone Of:
Environment:
Last Closed: 2023-05-10 00:51:53 UTC
Type: ---
Embargoed:
spotrh: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2023-04-18 09:52:23 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Hash-Ordered/perl-Hash-Ordered.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Hash-Ordered/perl-Hash-Ordered-0.014-1.fc39.src.rpm
Description:
This module implements an ordered hash, meaning that it associates keys
with values like a Perl hash, but keeps the keys in a consistent order.
Because it is implemented as an object and manipulated with method calls,
it is much slower than a Perl hash. This is the cost of keeping order.

Fedora Account System Username: ppisar

Comment 1 Tom "spot" Callaway 2023-04-19 19:18:42 UTC
Good:

- rpmlint checks return:
  perl-Hash-Ordered-tests.noarch: W: no-documentation

- package meets naming guidelines
- package meets packaging guidelines
- license (Apache-2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (sha256 8dc36cd79155ae37ab8a3de5fd9120ffba9a31e409258c28529ec5251c59747b)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

Comment 2 Fedora Admin user for bugzilla script actions 2023-04-20 07:15:40 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Hash-Ordered

Comment 3 Petr Pisar 2023-04-20 07:19:29 UTC
Thank you for the review.

Comment 4 Sergio Basto 2023-04-28 10:06:32 UTC
can we build it for F38 , F37, EPEL 9 and EPEL 8 ? to update perl-User-Identity in these branches

Comment 5 Petr Pisar 2023-04-28 10:51:21 UTC
Yes, we can. I will try it.

Comment 6 Fedora Update System 2023-04-28 11:15:26 UTC
FEDORA-2023-af14ec2ca3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-af14ec2ca3

Comment 7 Fedora Update System 2023-04-28 11:15:34 UTC
FEDORA-2023-aef6baddda has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-aef6baddda

Comment 8 Fedora Update System 2023-04-28 11:15:40 UTC
FEDORA-2023-014b33a0d7 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-014b33a0d7

Comment 9 Fedora Update System 2023-04-28 11:32:49 UTC
FEDORA-EPEL-2023-571128834c has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-571128834c

Comment 10 Fedora Update System 2023-04-28 11:32:55 UTC
FEDORA-EPEL-2023-ef724c2edf has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ef724c2edf

Comment 11 Fedora Update System 2023-04-29 05:08:44 UTC
FEDORA-2023-af14ec2ca3 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-af14ec2ca3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-af14ec2ca3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-04-29 05:18:38 UTC
FEDORA-EPEL-2023-ef724c2edf has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ef724c2edf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-04-29 05:28:26 UTC
FEDORA-EPEL-2023-571128834c has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-571128834c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-04-29 05:37:17 UTC
FEDORA-2023-014b33a0d7 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-014b33a0d7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-014b33a0d7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2023-04-29 06:28:28 UTC
FEDORA-2023-aef6baddda has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-aef6baddda \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-aef6baddda

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Maxime Besson 2023-05-09 08:13:18 UTC
Hello,
perl-User-Identity-1.02 has been pushed to stable EPEL today (https://bugzilla.redhat.com/show_bug.cgi?id=2187275)

this package should be pushed quickly as well, because as of now perl-User-Identity (and anything depending on it such as perl-Email-Sender) is no longer installable on stable EPEL8/EPEL9:

> # yum install perl-User-Identity
> Last metadata expiration check: 0:13:49 ago on Tue 09 May 2023 07:53:21 AM UTC.
> Error: 
>  Problem: conflicting requests
>   - nothing provides perl(Hash::Ordered) needed by perl-User-Identity-1.02-1.el8.noarch
> (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Thanks

Comment 17 Sergio Basto 2023-05-09 11:33:11 UTC
Sorry, I forgot to check if perl-Hash-Ordered-0.014-1 was in stable repos.

I pushed the packages now

Comment 18 Fedora Update System 2023-05-10 00:51:53 UTC
FEDORA-2023-014b33a0d7 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2023-05-10 01:40:10 UTC
FEDORA-2023-af14ec2ca3 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2023-05-10 01:40:34 UTC
FEDORA-2023-aef6baddda has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2023-05-10 02:20:49 UTC
FEDORA-EPEL-2023-571128834c has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2023-05-10 02:28:41 UTC
FEDORA-EPEL-2023-ef724c2edf has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.