Bug 2187780 - Review Request: rust-trust-dns-recursor - Safe and secure DNS recursive resolver with DNSSec support
Summary: Review Request: rust-trust-dns-recursor - Safe and secure DNS recursive resol...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: blinxen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-18 16:36 UTC by Fabio Valentini
Modified: 2023-05-17 18:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-05-17 18:51:25 UTC
Type: ---
Embargoed:
h-k-81: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-04-18 16:36:20 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-trust-dns-recursor.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-trust-dns-recursor-0.22.0-1.fc38.src.rpm

Description:
Trust-DNS Recursor is a safe and secure DNS recursive resolver with
DNSSec support. Trust-DNS is based on the Tokio and Futures libraries,
which means it should be easily integrated into other software that also
use those libraries. This library can be used as in the server and
binary for performing recursive lookups.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-04-18 16:36:22 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=100104608

Comment 2 blinxen 2023-05-12 21:57:51 UTC
Taking this review

General comments:

- Package was generated with rust2rpm and a manual change was applied
- Tests were deactivated because of a missing dependency. Should be fine but it would be cooler
- Some features were deactivated because of dependencies that have limited arch support. I guess this is fine to keep this package `noarch` if the features are not needed.

Issues:

- Apache license contains no year / owner --> https://github.com/bluejekyll/trust-dns/blob/main/crates/recursor/LICENSE-APACHE#L189
- rpmlint errors (E: summary-too-long), see below

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[!]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "MIT License", "Apache License 2.0". 4 files have unknown license.
     Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/rust-trust-dns-recursor/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     trust-dns-recursor-devel , rust-trust-dns-recursor+default-devel ,
     rust-trust-dns-recursor+dns-over-https-devel , rust-trust-dns-
     recursor+dns-over-native-tls-devel , rust-trust-dns-recursor+dns-over-
     openssl-devel , rust-trust-dns-recursor+dns-over-tls-devel , rust-
     trust-dns-recursor+dnssec-devel , rust-trust-dns-recursor+dnssec-
     openssl-devel , rust-trust-dns-recursor+serde-devel , rust-trust-dns-
     recursor+serde-config-devel , rust-trust-dns-recursor+testing-devel ,
     rust-trust-dns-recursor+tls-devel , rust-trust-dns-recursor+tls-
     openssl-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: rust-trust-dns-recursor-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+default-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+dns-over-https-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+dns-over-native-tls-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+dns-over-openssl-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+dns-over-tls-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+dnssec-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+dnssec-openssl-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+serde-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+serde-config-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+testing-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+tls-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor+tls-openssl-devel-0.22.0-1.fc39.noarch.rpm
          rust-trust-dns-recursor-0.22.0-1.fc39.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpu3r2xw5_')]
checks: 31, packages: 14

rust-trust-dns-recursor+default-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-https-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-native-tls-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-openssl-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-tls-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dnssec-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dnssec-openssl-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+serde-config-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+serde-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+testing-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+tls-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+tls-openssl-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor.src: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+default-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-https-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-native-tls-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-openssl-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-tls-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dnssec-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dnssec-openssl-devel.noarch: W: no-documentation
rust-trust-dns-recursor+serde-config-devel.noarch: W: no-documentation
rust-trust-dns-recursor+serde-devel.noarch: W: no-documentation
rust-trust-dns-recursor+testing-devel.noarch: W: no-documentation
rust-trust-dns-recursor+tls-devel.noarch: W: no-documentation
rust-trust-dns-recursor+tls-openssl-devel.noarch: W: no-documentation
 14 packages and 0 specfiles checked; 14 errors, 12 warnings, 14 badness; has taken 0.3 s




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 13

rust-trust-dns-recursor+dns-over-native-tls-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+tls-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+default-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+tls-openssl-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+testing-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dnssec-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+serde-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-tls-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-openssl-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dnssec-openssl-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-https-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+serde-config-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor-devel.noarch: E: summary-too-long Trust-DNS Recursor is a safe and secure DNS recursive resolver with DNSSec support
rust-trust-dns-recursor+dns-over-native-tls-devel.noarch: W: no-documentation
rust-trust-dns-recursor+tls-devel.noarch: W: no-documentation
rust-trust-dns-recursor+default-devel.noarch: W: no-documentation
rust-trust-dns-recursor+tls-openssl-devel.noarch: W: no-documentation
rust-trust-dns-recursor+testing-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dnssec-devel.noarch: W: no-documentation
rust-trust-dns-recursor+serde-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-tls-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-openssl-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dnssec-openssl-devel.noarch: W: no-documentation
rust-trust-dns-recursor+dns-over-https-devel.noarch: W: no-documentation
rust-trust-dns-recursor+serde-config-devel.noarch: W: no-documentation
 13 packages and 0 specfiles checked; 13 errors, 12 warnings, 13 badness; has taken 0.1 s



Source checksums
----------------
https://crates.io/api/v1/crates/trust-dns-recursor/0.22.0/download#/trust-dns-recursor-0.22.0.crate :
  CHECKSUM(SHA256) this package     : 39d1cb23f77bf8770587445a16688c5c117128fac39ab68f2c09df5f16cdaf5e
  CHECKSUM(SHA256) upstream package : 39d1cb23f77bf8770587445a16688c5c117128fac39ab68f2c09df5f16cdaf5e


Requires
--------
rust-trust-dns-recursor-devel (rpmlib, GLIBC filtered):
    (crate(async-recursion/default) >= 1.0.0 with crate(async-recursion/default) < 2.0.0~)
    (crate(async-trait/default) >= 0.1.43 with crate(async-trait/default) < 0.2.0~)
    (crate(bytes/default) >= 1.0.0 with crate(bytes/default) < 2.0.0~)
    (crate(cfg-if/default) >= 1.0.0 with crate(cfg-if/default) < 2.0.0~)
    (crate(enum-as-inner/default) >= 0.5.0 with crate(enum-as-inner/default) < 0.6.0~)
    (crate(futures-executor) >= 0.3.5 with crate(futures-executor) < 0.4.0~)
    (crate(futures-executor/std) >= 0.3.5 with crate(futures-executor/std) < 0.4.0~)
    (crate(futures-util) >= 0.3.5 with crate(futures-util) < 0.4.0~)
    (crate(futures-util/std) >= 0.3.5 with crate(futures-util/std) < 0.4.0~)
    (crate(lru-cache/default) >= 0.1.2 with crate(lru-cache/default) < 0.2.0~)
    (crate(parking_lot/default) >= 0.12.0 with crate(parking_lot/default) < 0.13.0~)
    (crate(thiserror/default) >= 1.0.20 with crate(thiserror/default) < 2.0.0~)
    (crate(time/default) >= 0.3.0 with crate(time/default) < 0.4.0~)
    (crate(tokio/default) >= 1.0.0 with crate(tokio/default) < 2.0.0~)
    (crate(tokio/net) >= 1.0.0 with crate(tokio/net) < 2.0.0~)
    (crate(toml/default) >= 0.5.0 with crate(toml/default) < 0.6.0~)
    (crate(tracing/default) >= 0.1.30 with crate(tracing/default) < 0.2.0~)
    (crate(trust-dns-proto/default) >= 0.22.0 with crate(trust-dns-proto/default) < 0.23.0~)
    (crate(trust-dns-resolver/default) >= 0.22.0 with crate(trust-dns-resolver/default) < 0.23.0~)
    cargo

rust-trust-dns-recursor+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trust-dns-recursor)

rust-trust-dns-recursor+dns-over-https-devel (rpmlib, GLIBC filtered):
    (crate(trust-dns-proto/dns-over-https) >= 0.22.0 with crate(trust-dns-proto/dns-over-https) < 0.23.0~)
    cargo
    crate(trust-dns-recursor)

rust-trust-dns-recursor+dns-over-native-tls-devel (rpmlib, GLIBC filtered):
    (crate(trust-dns-proto/dns-over-native-tls) >= 0.22.0 with crate(trust-dns-proto/dns-over-native-tls) < 0.23.0~)
    (crate(trust-dns-resolver/dns-over-native-tls) >= 0.22.0 with crate(trust-dns-resolver/dns-over-native-tls) < 0.23.0~)
    cargo
    crate(trust-dns-recursor)
    crate(trust-dns-recursor/dns-over-tls)

rust-trust-dns-recursor+dns-over-openssl-devel (rpmlib, GLIBC filtered):
    (crate(trust-dns-proto/dns-over-openssl) >= 0.22.0 with crate(trust-dns-proto/dns-over-openssl) < 0.23.0~)
    (crate(trust-dns-resolver/dns-over-openssl) >= 0.22.0 with crate(trust-dns-resolver/dns-over-openssl) < 0.23.0~)
    cargo
    crate(trust-dns-recursor)
    crate(trust-dns-recursor/dns-over-tls)
    crate(trust-dns-recursor/dnssec-openssl)

rust-trust-dns-recursor+dns-over-tls-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trust-dns-recursor)

rust-trust-dns-recursor+dnssec-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trust-dns-recursor)

rust-trust-dns-recursor+dnssec-openssl-devel (rpmlib, GLIBC filtered):
    (crate(trust-dns-proto/dnssec-openssl) >= 0.22.0 with crate(trust-dns-proto/dnssec-openssl) < 0.23.0~)
    (crate(trust-dns-resolver/dnssec-openssl) >= 0.22.0 with crate(trust-dns-resolver/dnssec-openssl) < 0.23.0~)
    cargo
    crate(trust-dns-recursor)
    crate(trust-dns-recursor/dnssec)

rust-trust-dns-recursor+serde-devel (rpmlib, GLIBC filtered):
    (crate(serde/default) >= 1.0.114 with crate(serde/default) < 2.0.0~)
    (crate(serde/derive) >= 1.0.114 with crate(serde/derive) < 2.0.0~)
    cargo
    crate(trust-dns-recursor)

rust-trust-dns-recursor+serde-config-devel (rpmlib, GLIBC filtered):
    (crate(trust-dns-proto/serde-config) >= 0.22.0 with crate(trust-dns-proto/serde-config) < 0.23.0~)
    (crate(trust-dns-resolver/serde-config) >= 0.22.0 with crate(trust-dns-resolver/serde-config) < 0.23.0~)
    cargo
    crate(trust-dns-recursor)
    crate(trust-dns-recursor/serde)

rust-trust-dns-recursor+testing-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trust-dns-recursor)

rust-trust-dns-recursor+tls-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trust-dns-recursor)
    crate(trust-dns-recursor/dns-over-openssl)

rust-trust-dns-recursor+tls-openssl-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trust-dns-recursor)
    crate(trust-dns-recursor/dns-over-openssl)



Provides
--------
rust-trust-dns-recursor-devel:
    crate(trust-dns-recursor)
    rust-trust-dns-recursor-devel

rust-trust-dns-recursor+default-devel:
    crate(trust-dns-recursor/default)
    rust-trust-dns-recursor+default-devel

rust-trust-dns-recursor+dns-over-https-devel:
    crate(trust-dns-recursor/dns-over-https)
    rust-trust-dns-recursor+dns-over-https-devel

rust-trust-dns-recursor+dns-over-native-tls-devel:
    crate(trust-dns-recursor/dns-over-native-tls)
    rust-trust-dns-recursor+dns-over-native-tls-devel

rust-trust-dns-recursor+dns-over-openssl-devel:
    crate(trust-dns-recursor/dns-over-openssl)
    rust-trust-dns-recursor+dns-over-openssl-devel

rust-trust-dns-recursor+dns-over-tls-devel:
    crate(trust-dns-recursor/dns-over-tls)
    rust-trust-dns-recursor+dns-over-tls-devel

rust-trust-dns-recursor+dnssec-devel:
    crate(trust-dns-recursor/dnssec)
    rust-trust-dns-recursor+dnssec-devel

rust-trust-dns-recursor+dnssec-openssl-devel:
    crate(trust-dns-recursor/dnssec-openssl)
    rust-trust-dns-recursor+dnssec-openssl-devel

rust-trust-dns-recursor+serde-devel:
    crate(trust-dns-recursor/serde)
    rust-trust-dns-recursor+serde-devel

rust-trust-dns-recursor+serde-config-devel:
    crate(trust-dns-recursor/serde-config)
    rust-trust-dns-recursor+serde-config-devel

rust-trust-dns-recursor+testing-devel:
    crate(trust-dns-recursor/testing)
    rust-trust-dns-recursor+testing-devel

rust-trust-dns-recursor+tls-devel:
    crate(trust-dns-recursor/tls)
    rust-trust-dns-recursor+tls-devel

rust-trust-dns-recursor+tls-openssl-devel:
    crate(trust-dns-recursor/tls-openssl)
    rust-trust-dns-recursor+tls-openssl-devel



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-trust-dns-recursor --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, Ocaml, SugarActivity, Haskell, Perl, fonts, Java, C/C++, PHP, Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 3 blinxen 2023-05-12 22:00:17 UTC
> Tests were deactivated because of a missing dependency. Should be fine but it would be cooler

Started a sentence and did not finish it :D

What I meant to write was, it would be cooler if the dependency could be packaged but I just saw you also submitted https://bugzilla.redhat.com/show_bug.cgi?id=2187797 so ignore this comment.

Comment 4 Fabio Valentini 2023-05-16 15:57:06 UTC
(In reply to blinxen from comment #2)
> Taking this review

Not sure why I didn't get an email notification for your updates ... sorry for the slow reply.

> General comments:
> 
> - Package was generated with rust2rpm and a manual change was applied
> - Tests were deactivated because of a missing dependency. Should be fine but
> it would be cooler

Yeah, I'm already packaging the missing stuff, but it's not high priority for me.

> - Some features were deactivated because of dependencies that have limited
> arch support. I guess this is fine to keep this package `noarch` if the
> features are not needed.

Yep, the features aren't needed, and I'd rather not open the can of worms that is "depending on an unmaintained fork of an OpenSSL fork" ...

> Issues:
> 
> - Apache license contains no year / owner -->
> https://github.com/bluejekyll/trust-dns/blob/main/crates/recursor/LICENSE-
> APACHE#L189

This is in the "How to apply this license to your project" APPENDIX section, it's normal.

> - rpmlint errors (E: summary-too-long), see below

Ok, good point, I'll trim the Summary a bit.

Comment 5 Fabio Valentini 2023-05-16 18:28:54 UTC
Updated for shorter Summary.

Comment 6 blinxen 2023-05-16 22:21:50 UTC
APPROVED

Comment 7 Fabio Valentini 2023-05-17 16:00:39 UTC
Thanks for the review!

Comment 8 Fedora Admin user for bugzilla script actions 2023-05-17 16:01:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trust-dns-recursor

Comment 9 Fabio Valentini 2023-05-17 18:51:25 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6a7110d7e3


Note You need to log in before you can comment on or make changes to this bug.