User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/112.0 Build Identifier: Spec URL: https://www.flyn.org/SRPMS/golang-github-hashicorp-lru-2.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-hashicorp-lru-2-2.0.2-1.fc38.src.rpm Description: Golang LRU cache. Fedora Account System Username: mikep Reproducible: Always
Package structure is correct, but I'm not sure about if License is correct. `simplelru/LICENSE_list` file suggest part of the code is BSD-3, for example simplelru/list.go. That file is part of `%global golicenses`, but then `License: MPL-2.0` won't match those BSD files. Can you manually add the other License that was not capture by go2rpm?
Spec URL: https://www.flyn.org/SRPMS/golang-github-hashicorp-lru-2.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-hashicorp-lru-2-2.0.2-1.fc38.src.rpm I added this: License: MPL-2.0 and BSD-3-Clause
Created attachment 1958429 [details] The .spec file difference from Copr build 5803423 to 5807051
I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hashicorp-lru-2
https://pagure.io/releng/fedora-scm-requests/issue/52875
FEDORA-2023-55344d729c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-55344d729c
FEDORA-2023-55344d729c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.