Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=3b0dcc6e3b0741e2cada8335a9e44cb406eaa271 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.0-1.remi.src.rpm Description: Next generation phpDoc parser with support for intersection types and generics. Fedora Account System Username: remi ---- New dependency of php-phpdocumentor-type-resolver1, used in PHPUnit stack
Copr build: https://copr.fedorainfracloud.org/coprs/build/5809291 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05809291-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.20.2 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=c035aa5c9b4c8ec5d3e99367b5566d69fdf21ca8 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.2-1.remi.src.rpm
Created attachment 1959732 [details] The .spec file difference from Copr build 5809291 to 5847609
Copr build: https://copr.fedorainfracloud.org/coprs/build/5847609 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05847609-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.20.3 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=cbf5ce9ed37157af2ff976bdec0cd2656e34f07c SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.3-1.remi.src.rpm
Created attachment 1959763 [details] The .spec file difference from Copr build 5847609 to 5847927
Copr build: https://copr.fedorainfracloud.org/coprs/build/5847927 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05847927-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.20.4 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=9ae2d1f727a1ccc415c3f4d23f8560cf6ff20265 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.4-1.remi.src.rpm
Created attachment 1961876 [details] The .spec file difference from Copr build 5847927 to 5869163
Copr build: https://copr.fedorainfracloud.org/coprs/build/5869163 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05869163-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.21.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=13d4a2c242d7efe9e8dde76aa315c5409c60ce4d SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.21.0-1.remi.src.rpm
Created attachment 1965075 [details] The .spec file difference from Copr build 5869163 to 5928337
Copr build: https://copr.fedorainfracloud.org/coprs/build/5928337 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05928337-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.21.3 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=6fd31dc6cc8eddfed99f92b4c72ebf45b329de84 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.21.3-1.remi.src.rpm
Created attachment 1967850 [details] The .spec file difference from Copr build 5928337 to 5984924
Copr build: https://copr.fedorainfracloud.org/coprs/build/5984924 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05984924-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.22.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=ec4c02c3a0929d5e4aa59569c40040321293e578 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.22.0-1.remi.src.rpm
Created attachment 1968463 [details] The .spec file difference from Copr build 5984924 to 5996514
Copr build: https://copr.fedorainfracloud.org/coprs/build/5996514 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/05996514-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.22.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=ceb825333084f9968a1a26996027e05a2d471582 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.22.1-1.remi.src.rpm
Created attachment 1973841 [details] The .spec file difference from Copr build 5996514 to 6135931
Copr build: https://copr.fedorainfracloud.org/coprs/build/6135931 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/06135931-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.22.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=0eb497290f5c07a58afdca7a16ff9adf6b13081e SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.23.0-1.remi.src.rpm
Updated to 1.23.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=1024a5c475ab91b1778843ebbbcca119dda9f106 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.23.1-1.remi.src.rpm
Created attachment 1981605 [details] The .spec file difference from Copr build 6135931 to 6240383
Copr build: https://copr.fedorainfracloud.org/coprs/build/6240383 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/06240383-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.24.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=2890e3eeed1a2bcebf743b6cf31197c320d01bb0 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.0-1.remi.src.rpm
Created attachment 1987680 [details] The .spec file difference from Copr build 6240383 to 6384496
Copr build: https://copr.fedorainfracloud.org/coprs/build/6384496 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/06384496-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.24.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=f1b21012fd4fedcc4a68c403a5c49acfb99e0686 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.1-1.remi.src.rpm
Updated to 1.24.3 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=bb34a8e1e30a69524fde4126104f5f88fd0a9998 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.3-1.remi.src.rpm
Created attachment 2000524 [details] The .spec file difference from Copr build 6384496 to 6670544
Copr build: https://copr.fedorainfracloud.org/coprs/build/6670544 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/06670544-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.24.3 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=8ad742f046031d6a144d03c562baf715034327f8 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.4-1.remi.src.rpm
Updated to 1.24.5 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=e77c1008747994318b46bb21e1fa98da865453a5 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.5-1.remi.src.rpm
Created attachment 2004829 [details] The .spec file difference from Copr build 6670544 to 6766549
Copr build: https://copr.fedorainfracloud.org/coprs/build/6766549 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/06766549-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.24.5 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=a9802bd984802aabaf08e2241d433958ac1b2786 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.25.0-1.remi.src.rpm
Created attachment 2007326 [details] The .spec file difference from Copr build 6766549 to 6865550
Copr build: https://copr.fedorainfracloud.org/coprs/build/6865550 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/06865550-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.26.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=75cd04c4b4285d0ae0088bee6e4a0f837c721550 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.26.0-1.remi.src.rpm
Created attachment 2018868 [details] The .spec file difference from Copr build 6865550 to 7060913
Copr build: https://copr.fedorainfracloud.org/coprs/build/7060913 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/07060913-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.27.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=3fd1ce5086bbeadcd6a9a5d283fe0ef445f6c320 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.27.0-1.remi.src.rpm
Created attachment 2022936 [details] The .spec file difference from Copr build 7060913 to 7193233
Copr build: https://copr.fedorainfracloud.org/coprs/build/7193233 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/07193233-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.28.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=babbccea515011bbac1bcf26f7b7b060132a8870 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.28.0-1.remi.src.rpm
Updated to 1.29.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=7388dd13a870d91552b932bbbfd32dce1b963990 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.29.0-1.remi.src.rpm
Created attachment 2032893 [details] The .spec file difference from Copr build 7193233 to 7437656
Copr build: https://copr.fedorainfracloud.org/coprs/build/7437656 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/07437656-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.29.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=bb7a15cab80199f2c261ad8b41e261402c572320 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.29.1-1.remi.src.rpm
Updated to 1.30.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=d2cfd76cf5fd4fe08f72d532e24ab57ff5339aae SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.30.0-1.remi.src.rpm
Created attachment 2045034 [details] The .spec file difference from Copr build 7437656 to 7953290
Copr build: https://copr.fedorainfracloud.org/coprs/build/7953290 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/07953290-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.30.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=51af8d8876697a945168e9e1b07301e2300045d2 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.30.1-1.remi.src.rpm
Created attachment 2046432 [details] The .spec file difference from Copr build 7953290 to 8010356
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010356 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/08010356-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.31.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=943689f934ba7d87b8ff0d1e72df5cc94f136048 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.31.0-1.remi.src.rpm
Created attachment 2048253 [details] The .spec file difference from Copr build 8010356 to 8060894
Copr build: https://copr.fedorainfracloud.org/coprs/build/8060894 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/08060894-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.32.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=be41a7c15b49da3e1dcd2befadb3ffe843b4864f SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.32.0-1.remi.src.rpm
Created attachment 2048789 [details] The .spec file difference from Copr build 8060894 to 8073102
Copr build: https://copr.fedorainfracloud.org/coprs/build/8073102 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/08073102-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to 1.33.0 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=52f6c23ee13ce941a9abafd1c9867dc223f543e3 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.33.0-1.remi.src.rpm
Hello Remi, please check my review. Issues: - Source package contains another software, abnfgen-0.20 in "tests" directory. The abnfgen-0.20's license is unclear for me. - Invalid-url Source0: 82a311fd3690fb2bf7b64d5c98f912b3dd746140/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz The upstream removes the "tests" directory from the release archive file. # md5sum rpmbuild/SOURCES/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz ad9582b67e3a8b1d96391eadce6bae07 rpmbuild/SOURCES/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz # wget https://github.com/phpstan/phpdoc-parser/archive/refs/tags/1.33.0.tar.gz && md5sum 1.33.0.tar.gz a58421ab796b7d02f48f61cb7c159b07 1.33.0.tar.gz - Tests are included in php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz but are not run in %check. If you do not think it is practical to run tests, you can use 1.33.0.tar.gz instead. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. /home/mockbuilder/2188329-php-phpstan-phpdoc-parser/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9141 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. 2.0.x exists but is 1.33.x is the latest version of 1.x. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: 7.1.4@9875282 static analyze results in /home/mockbuilder/2188329-php-phpstan-phpdoc-parser/phpci.log Rpmlint ------- Checking: php-phpstan-phpdoc-parser-1.33.0-1.fc42.noarch.rpm php-phpstan-phpdoc-parser-1.33.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpno3g6a9m')] checks: 32, packages: 2 php-phpstan-phpdoc-parser.noarch: E: spelling-error ('nullable', 'Summary(en_US) nullable -> null able, null-able, callable') php-phpstan-phpdoc-parser.src: E: spelling-error ('nullable', 'Summary(en_US) nullable -> null able, null-able, callable') php-phpstan-phpdoc-parser.spec: W: invalid-url Source0: 82a311fd3690fb2bf7b64d5c98f912b3dd746140/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 php-phpstan-phpdoc-parser.noarch: E: spelling-error ('nullable', 'Summary(en_US) nullable -> null able, null-able, callable') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s Requires -------- php-phpstan-phpdoc-parser (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-json php-pcre Provides -------- php-phpstan-phpdoc-parser: php-composer(phpstan/phpdoc-parser) php-phpstan-phpdoc-parser Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2188329 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, PHP Disabled plugins: Haskell, Python, Ocaml, R, SugarActivity, Java, Perl, C/C++, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for the review > Tests are included in php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz but are not > run in %check. If you do not think it is practical to run tests, you can use > 1.33.0.tar.gz instead. Test are run in %check So I choose to remove abnfgen from generated archive https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/commit/?id=f13996b09ae50ad9a505372432a26c9189220e86 I also switched spec license from CC-BY-SA-4.0 (only allowed for content in new Guidelines), by CECILL-1.2 (allowed for code), which is a global change in progress for all my packages. Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=f13996b09ae50ad9a505372432a26c9189220e86 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.33.0-2.remi.src.rpm
Created attachment 2062826 [details] The .spec file difference from Copr build 8073102 to 8403055
Copr build: https://copr.fedorainfracloud.org/coprs/build/8403055 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188329-php-phpstan-phpdoc-parser/fedora-rawhide-x86_64/08403055-php-phpstan-phpdoc-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Hirotaka Wakabayashi from comment #65) > Hello Remi, please check my review. Anything still blocking the review ?
Hello, Remi. Sorry for my late response. Thanks for the update. Package approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-phpstan-phpdoc-parser
Thanks! Notice: version 2.0.0 is available, but version 1.x is needed php-phpdocumentor-type-resolver1 new version SCM Requests: https://pagure.io/releng/fedora-scm-requests/issue/71018 https://pagure.io/releng/fedora-scm-requests/issue/71019
FEDORA-2024-5f5512c767 (php-phpstan-phpdoc-parser-1.33.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5f5512c767
FEDORA-2024-5f5512c767 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5f5512c767 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5f5512c767 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-5f5512c767 (php-phpstan-phpdoc-parser-2.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.