Bug 2188480 - vgrename doesn't accept the option --select
Summary: vgrename doesn't accept the option --select
Keywords:
Status: POST
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: lvm2
Version: 9.3
Hardware: x86_64
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Peter Rajnoha
QA Contact: cluster-qe
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-20 21:39 UTC by Corey Marthaler
Modified: 2023-08-10 15:41 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-155336 0 None None None 2023-04-20 21:40:57 UTC

Description Corey Marthaler 2023-04-20 21:39:34 UTC
Description of problem:
Normally this may not be an issue, but when faced with two vgs with the same name yet unique vg_uuids, many lvm commands tell the user to use vgrename with --select --uuid to remedy the problem.

"Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
Multiple VGs found with the same name: skipping df
Use --select vg_uuid=<uuid> in place of the VG name."




[root@grant-02 ~]# vgs -a -o +vg_uuid
  WARNING: VG name df is used by VGs iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI and RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo.
  Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
  VG #PV #LV #SN Attr   VSize VFree VG UUID
  df   1   0   0 wz--n- 2.91t 2.91t iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI
  df   1   0   0 wz--n- 2.91t 2.91t RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo

[root@grant-02 ~]# vgrename df df2
  WARNING: VG name df is used by VGs iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI and RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo.
  Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
  Multiple VGs found with the same name: skipping df
  Use --select vg_uuid=<uuid> in place of the VG name.

[root@grant-02 ~]# vgrename --select vg_uuid=iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI df2
vgrename: unrecognized option '--select'
  Error during parsing of command line.

[root@grant-02 ~]# vgrename --select 'vg_uuid=iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI' df2
vgrename: unrecognized option '--select'
  Error during parsing of command line.

[root@grant-02 ~]# vgremove --select 'vg_uuid=iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI'
  WARNING: VG name df is used by VGs iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI and RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo.
  Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
  Volume group "df" successfully removed


Version-Release number of selected component (if applicable):
kernel-5.14.0-284.11.1.el9_2    BUILT: Wed Apr 12 04:16:55 PM CEST 2023
lvm2-2.03.20-2.el9    BUILT: Thu Apr  6 01:40:29 PM CEST 2023
lvm2-libs-2.03.20-2.el9    BUILT: Thu Apr  6 01:40:29 PM CEST 2023

Comment 1 Peter Rajnoha 2023-05-16 12:04:36 UTC
I think removing the support for -S|--select in vgrename was intentional so we always point to a single VG by directly specifying the VG UUID (which vgrename already accepts).

Also, if we used "vgrename --select <some_criteria> new_vg_name", then all VGs that match the selection criteria would be renamed to the same "new_vg_name". That is something we don't want to as we'd produce duplicate VG names this way.

So the fix here is just to change the reported "Use --select vg_uuid=<uuid> in place of the VG name." line to "Use VG UUID in place of the VG name.".

Comment 2 Peter Rajnoha 2023-05-16 12:05:42 UTC
(And changing all related documentation that mentions -S|--select together with vgrename.")

Comment 3 Peter Rajnoha 2023-05-16 15:27:00 UTC
The message is changed now for commands that do not support -S|--select to "Use VG uuid in place of the VG name." (should be only vgrename at the moment)

https://sourceware.org/git/?p=lvm2.git;a=commit;h=3b4e7d1625ddc48dd9393f03a59cc6b74113275a


Note You need to log in before you can comment on or make changes to this bug.