Bug 2188674 - /usr/lib/firmware/qcom/sdm845/wlanmdsp.mbn.xz: broken symlink to ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz
Summary: /usr/lib/firmware/qcom/sdm845/wlanmdsp.mbn.xz: broken symlink to ../../ath10k...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: linux-firmware
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: David Woodhouse
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-21 15:06 UTC by Michael Armijo
Modified: 2023-08-22 17:34 UTC (History)
8 users (show)

Fixed In Version: linux-firmware-20230804-152.fc38 linux-firmware-20230804-153.fc37
Clone Of:
Environment:
Last Closed: 2023-08-11 00:41:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michael Armijo 2023-04-21 15:06:45 UTC
/usr/lib/firmware/qcom/sdm845/wlanmdsp.mbn.xz: broken symlink to ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz in the recent rawhide package: linux-firmware-20230404-149.fc39. 
No files exist in the /usr/lib/firmware/ath10k/WCN3990/hw1.0 directory.

Reproducible: Always

Steps to Reproduce:
1. file /usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz 
Actual Results:  
Broken symlink from /usr/lib/firmware/qcom/sdm845/wlanmdsp.mbn.xz to  ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz

Expected Results:  
The symbolic link should exist.

Comment 1 Peter Robinson 2023-04-21 15:46:29 UTC
It's listed in the WHENCE file which is what's used to create those so that must be wrong.

Comment 2 Peter Robinson 2023-04-21 15:49:39 UTC
Actually it's there as expected on my arm systems:

root@localhost:/lib/firmware/qcom/sdm845 $ ls -al
total 6512
drwxr-xr-x.  2 root root     211 Apr 21 11:35 .
drwxr-xr-x. 13 root root    4096 Apr 21 11:35 ..
-rw-r--r--.  1 root root    3532 Apr  9 00:00 a630_zap.mbn.xz
-rw-r--r--.  1 root root 4068144 Apr  9 00:00 adsp.mbn.xz
-rw-r--r--.  1 root root     232 Apr  9 00:00 adspr.jsn.xz
-rw-r--r--.  1 root root     248 Apr  9 00:00 adspua.jsn.xz
-rw-r--r--.  1 root root  853816 Apr  9 00:00 cdsp.mbn.xz
-rw-r--r--.  1 root root     232 Apr  9 00:00 cdspr.jsn.xz
-rw-r--r--.  1 root root  105860 Apr  9 00:00 mba.mbn.xz
-rw-r--r--.  1 root root 1609424 Apr  9 00:00 modem.mbn.xz
-rw-r--r--.  1 root root     268 Apr  9 00:00 modemuw.jsn.xz
lrwxrwxrwx.  1 root root      42 Apr  9 00:00 wlanmdsp.mbn.xz -> ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz
root@localhost:/lib/firmware/qcom/sdm845 $ ls -al ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz
-rw-r--r--. 1 root root 1491352 Apr  9 00:00 ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz

Please provide more details like version of linux-firmware

Comment 3 Michael Armijo 2023-04-21 17:59:49 UTC
Hi Peter, thanks for looking into this. I mentioned the affected version of linux-firmware above, which is linux-firmware-20230404-149.fc39. Here are some more details for you. Please let me know what else I can provide.

[core@cosa-devsh ~]$ rpm -qa | grep linux-firmware
linux-firmware-whence-20230404-149.fc39.noarch
linux-firmware-20230404-149.fc39.noarch

[core@cosa-devsh sdm845]$ pwd
/usr/lib/firmware/qcom/sdm845
[core@cosa-devsh sdm845]$ ls -al
total 6516
drwxr-xr-x.  2 root root    4096 Jan  1  1970 .
drwxr-xr-x. 13 root root    4096 Jan  1  1970 ..
-rw-r--r--.  2 root root    3532 Jan  1  1970 a630_zap.mbn.xz
-rw-r--r--.  2 root root 4068144 Jan  1  1970 adsp.mbn.xz
-rw-r--r--.  3 root root     232 Jan  1  1970 adspr.jsn.xz
-rw-r--r--.  3 root root     248 Jan  1  1970 adspua.jsn.xz
-rw-r--r--.  2 root root  853816 Jan  1  1970 cdsp.mbn.xz
-rw-r--r--.  3 root root     232 Jan  1  1970 cdspr.jsn.xz
-rw-r--r--.  2 root root  105860 Jan  1  1970 mba.mbn.xz
-rw-r--r--.  2 root root 1609424 Jan  1  1970 modem.mbn.xz
-rw-r--r--.  2 root root     268 Jan  1  1970 modemuw.jsn.xz
lrwxrwxrwx.  2 root root      42 Apr 20 17:23 wlanmdsp.mbn.xz -> ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz

[core@cosa-devsh sdm845]$ ls -al ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz
ls: cannot access '../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz': No such file or directory


When I revert to using the previous package: linux-firmware 20230310-148.fc39, the symbolic link is valid:

[core@cosa-devsh ~]$ rpm -qa | grep linux-firmware
linux-firmware-whence-20230310-148.fc39.noarch
linux-firmware-20230310-148.fc39.noarch

[core@cosa-devsh ~]$ ls -al /usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz 
-rw-r--r--. 2 root root 1491352 Jan  1  1970 /usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz


I noticed you performed the command from the location `/lib/firmware/...`, but the issue is in the `/usr/lib/firmware/...` location. However, I see the broken sym link in both locations.

Comment 4 Michael Armijo 2023-04-21 18:37:19 UTC
Disregard my last comment about the location. I see that /lib -> /usr/lib.

Comment 5 Timothée Ravier 2023-04-26 13:47:56 UTC
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/WHENCE#n3397

```
Link: qcom/sdm845/wlanmdsp.mbn -> ../../ath10k/WCN3990/hw1.0/wlanmdsp.mbn
```

https://src.fedoraproject.org/rpms/linux-firmware/blob/rawhide/f/linux-firmware.spec#_417

```
	-i -e '/^ath10k/d' \
```

The symlink should be moved to another sub package. Likely %files -n atheros-firmware.

Comment 6 Timothée Ravier 2023-04-26 13:53:09 UTC
To fix this "generally", we would need to look at the target for symlinks in the script at https://src.fedoraproject.org/rpms/linux-firmware/blob/rawhide/f/linux-firmware.spec#_405 to do the filtering, not just the file names.

Comment 7 Fedora Update System 2023-08-06 14:48:29 UTC
FEDORA-2023-85168977a9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-85168977a9

Comment 8 Fedora Update System 2023-08-06 14:48:39 UTC
FEDORA-2023-d15f5a186a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d15f5a186a

Comment 9 Fedora Update System 2023-08-07 01:14:59 UTC
FEDORA-2023-d15f5a186a has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d15f5a186a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d15f5a186a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-08-07 01:44:48 UTC
FEDORA-2023-85168977a9 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-85168977a9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-85168977a9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-08-11 00:41:44 UTC
FEDORA-2023-d15f5a186a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-08-11 02:26:58 UTC
FEDORA-2023-eabbf4ca4d has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-eabbf4ca4d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-eabbf4ca4d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-08-22 17:34:50 UTC
FEDORA-2023-eabbf4ca4d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.