Bug 2188676 - Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows
Summary: Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal e...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-04-21 15:10 UTC by Sergio Basto
Modified: 2025-02-27 19:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-27 19:54:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Sergio Basto 2023-04-21 15:10:28 UTC
Spec URL: https://sergiomb.fedorapeople.org/golang-github-azure-ansiterm/golang-github-azure-ansiterm.spec
SRPM URL: https://sergiomb.fedorapeople.org/golang-github-azure-ansiterm/golang-github-azure-ansiterm-0-0.1.20230420git306776e.fc39.src.rpm

Description:
Go package for ANSI terminal emulation in Windows.

Fedora Account System Username: sergiomb

Comment 1 Sergio Basto 2023-04-21 15:10:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=100216993

Comment 2 Robert-André Mauchin 🐧 2023-08-14 17:36:28 UTC
 - Please use autorelease/autochangelog

 - Isn't this a Windows only package? Which one of your package is requiring it? usually it's only a dep in _windows.go file, which are excluded by the build system and the macros.

The only notable package that requires it is moby/moby, in a test:

https://github.com/moby/moby/blob/v24.0.5/integration/internal/termtest/stripansi.go

And github.com/moby/term, which is packaged but it is not called because in windows files.


I'd patch it out from moby: https://github.com/moby/moby/commit/2ec3e14c0ff7f8552c1f9b09ffde743632fa1f8c

From 873a4b6552fcdbf60299e51de3139465da6b2a92 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Robert-Andr=C3=A9=20Mauchin?= <zebob.m>
Date: Mon, 14 Aug 2023 19:11:59 +0200
Subject: [PATCH] Make call to Azure/go-ansiterm Windows-only

---
 integration/internal/termtest/stripansi_default.go     | 10 ++++++++++
 .../{stripansi_test.go => stripansi_test_windows.go}   |  0
 .../termtest/{stripansi.go => stripansi_windows.go}    |  0
 3 files changed, 10 insertions(+)
 create mode 100644 integration/internal/termtest/stripansi_default.go
 rename integration/internal/termtest/{stripansi_test.go => stripansi_test_windows.go} (100%)
 rename integration/internal/termtest/{stripansi.go => stripansi_windows.go} (100%)

diff --git a/integration/internal/termtest/stripansi_default.go b/integration/internal/termtest/stripansi_default.go
new file mode 100644
index 0000000000..8557c8bf72
--- /dev/null
+++ b/integration/internal/termtest/stripansi_default.go
@@ -0,0 +1,10 @@
+package termtest // import "github.com/docker/docker/integration/internal/termtest"
+
+import (
+       "errors"
+)
+
+// StripANSICommands provides a dummy implementation for non-Windows platforms.
+func StripANSICommands(input string) (string, error) {
+       return input, errors.New("StripANSICommands is not implemented for this platform")
+}
diff --git a/integration/internal/termtest/stripansi_test.go b/integration/internal/termtest/stripansi_test_windows.go
similarity index 100%
rename from integration/internal/termtest/stripansi_test.go
rename to integration/internal/termtest/stripansi_test_windows.go
diff --git a/integration/internal/termtest/stripansi.go b/integration/internal/termtest/stripansi_windows.go
similarity index 100%
rename from integration/internal/termtest/stripansi.go
rename to integration/internal/termtest/stripansi_windows.go
-- 
2.41.0

Pushed upstream: https://github.com/moby/moby/pull/46234
Not tested but it should work.

Let me know if you really need it.

Comment 3 Robert-André Mauchin 🐧 2023-08-15 10:27:19 UTC
Filename was wrong, take this patch instead https://patch-diff.githubusercontent.com/raw/moby/moby/pull/46234.patch

Comment 4 Package Review 2023-09-14 00:45:26 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 5 Package Review 2024-11-12 00:45:23 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Sergio Basto 2024-11-24 15:33:39 UTC
this can be closed


Note You need to log in before you can comment on or make changes to this bug.