Spec URL: https://yselkowitz.fedorapeople.org/convertall.spec SRPM URL: https://yselkowitz.fedorapeople.org/convertall-0.8.0-1.fc39.src.rpm Description: With ConvertAll, you can combine the units any way you want. If you want to convert from inches per decade, that's fine. Or from meter-pounds. Or from cubic nautical miles. The units don't have to make sense to anyone else. Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/5835952 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188736-convertall/fedora-rawhide-x86_64/05835952-convertall/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Any possibility to also have this on Pypi?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later", "GNU General Public License, Version 2". 38 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/convertall/2188736-convertall/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 133120 bytes in 5 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: convertall-0.8.0-1.fc39.noarch.rpm convertall-0.8.0-1.fc39.src.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn67oaqoa')] checks: 31, packages: 2 convertall.noarch: E: non-executable-script /usr/share/convertall/bases.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/cmdline.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/colorset.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/convertdlg.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/fontset.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/helpview.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/icondict.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/numedit.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/option.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/optiondefaults.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/optiondlg.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/recentunits.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/setup.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitatom.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitdata.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitedit.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitgroup.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitlistview.py 644 /usr/bin/env python3 convertall.noarch: W: no-manual-page-for-binary convertall convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/64x64/apps/convertall-icon.png /usr/share/convertall/icons/convertall-icon.png:/usr/share/convertall/icons/convertall_lg.png convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/scalable/apps/convertall-icon.svg /usr/share/convertall/icons/convertall-icon.svg convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/32x32/apps/convertall-icon.png /usr/share/convertall/icons/convertall_med.png convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/16x16/apps/convertall-icon.png /usr/share/convertall/icons/convertall_sm.png =================================== 2 packages and 0 specfiles checked; 18 errors, 5 warnings, 18 badness; has taken 2.4 s =================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 convertall.noarch: E: non-executable-script /usr/share/convertall/bases.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/cmdline.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/colorset.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/convertdlg.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/fontset.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/helpview.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/icondict.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/numedit.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/option.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/optiondefaults.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/optiondlg.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/recentunits.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/setup.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitatom.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitdata.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitedit.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitgroup.py 644 /usr/bin/env python3 convertall.noarch: E: non-executable-script /usr/share/convertall/unitlistview.py 644 /usr/bin/env python3 convertall.noarch: W: no-manual-page-for-binary convertall convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/64x64/apps/convertall-icon.png /usr/share/convertall/icons/convertall-icon.png:/usr/share/convertall/icons/convertall_lg.png convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/scalable/apps/convertall-icon.svg /usr/share/convertall/icons/convertall-icon.svg convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/32x32/apps/convertall-icon.png /usr/share/convertall/icons/convertall_med.png convertall.noarch: W: files-duplicate /usr/share/icons/hicolor/16x16/apps/convertall-icon.png /usr/share/convertall/icons/convertall_sm.png 1 packages and 0 specfiles checked; 18 errors, 5 warnings, 18 badness; has taken 0.9 s Source checksums ---------------- https://github.com/doug-101/ConvertAll/releases/download/v0.8.0/convertall-0.8.0.tar.gz : CHECKSUM(SHA256) this package : 624c8a792b0bc7ff3776499c2c743b32273569efd0567615e570a7e739e8d521 CHECKSUM(SHA256) upstream package : 624c8a792b0bc7ff3776499c2c743b32273569efd0567615e570a7e739e8d521 Requires -------- convertall (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh hicolor-icon-theme python3 python3-qt5 Provides -------- convertall: application() application(convertall.desktop) convertall metainfo() metainfo(convertall.appdata.xml) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2188736 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, Perl, Ruby, Java, PHP, C/C++, Ocaml, Haskell, SugarActivity, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Can python shebang macro https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_interpreter_invocation %py3_shebang_fix SCRIPTNAME be used to update the scripts? b) Pypi parity would be nice: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity c) Is it possible to run a smoke test for the non-GUI version to check the code works? d) Might it be possible to use BuildRequires: python3dist(pyqt5) in the spec file?
(In reply to Benson Muite from comment #3) > Comments: > a) Can python shebang macro > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_interpreter_invocation > %py3_shebang_fix SCRIPTNAME > be used to update the scripts? Those are non-executable on purpose because they are not actually scripts, they are modules of the program. The actual script, convertall.py, already has its shebang automatically fixed during post-install. > b) Pypi parity would be nice: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity Not feasible. This is not a requirement for non-importable Python consumers, and this package is not compatible/installable with pip etc. > c) Is it possible to run a smoke test for the non-GUI version to check the code works? TBH I never noticed the CLI mode, but now that you mention it, yes it is. > d) Might it be possible to use > BuildRequires: python3dist(pyqt5) > in the spec file? OK.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5853700 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188736-convertall/fedora-rawhide-x86_64/05853700-convertall/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Benson, do you plan on continuing this review?
The updated spec file was not used in the srpm, see https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188736-convertall/fedora-rawhide-x86_64/05853700-convertall/convertall.spec Please use the updated spec file on importing. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/convertall
FEDORA-2023-ee7a34f74e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ee7a34f74e
FEDORA-2023-bdb8e1cb15 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bdb8e1cb15
FEDORA-FLATPAK-2023-a4bb0633dd has been submitted as an update to Fedora 38 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-a4bb0633dd
FEDORA-2023-ee7a34f74e has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-ee7a34f74e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-ee7a34f74e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-bdb8e1cb15 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-bdb8e1cb15 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-bdb8e1cb15 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-FLATPAK-2023-a4bb0633dd has been pushed to the Fedora 38 Flatpaks testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-a4bb0633dd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-ee7a34f74e has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-bdb8e1cb15 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-FLATPAK-2023-a4bb0633dd has been pushed to the Fedora 38 Flatpaks stable repository. If problem still persists, please make note of it in this bug report.