Spec URL: https://api.nicehomeservices.com/images/temp/arianna.spec SRPM URL: https://api.nicehomeservices.com/images/temp/arianna-1.0.1-1.fc39.src.rpm Description: EPub Reader for mobile devices Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/5842133 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05842133-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Creative Commons CC0 1.0", "*No copyright* BSD 2-Clause License", "*No copyright* GNU General Public License, Version 3", "Creative Commons CC0 1.0 Creative Commons Attribution-ShareAlike 4.0", "*No copyright* BSD 3-Clause License", "Creative Commons Attribution-ShareAlike 4.0", "GNU General Public License, Version 2", "GNU General Public License, Version 3", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "*No copyright* MIT License", "*No copyright* GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Library General Public License, Version 2.0", "*No copyright* GNU General Public License, Version 2". 30 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/arianne/2188970-arianna/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: arianna-1.0.1-1.fc39.x86_64.rpm arianna-debuginfo-1.0.1-1.fc39.x86_64.rpm arianna-debugsource-1.0.1-1.fc39.x86_64.rpm arianna-1.0.1-1.fc39.src.rpm ============================================= rpmlint session starts ============================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3dgff51h')] checks: 31, packages: 4 arianna.x86_64: W: no-manual-page-for-binary arianna arianna.x86_64: E: files-duplicated-waste 102735 arianna.x86_64: W: files-duplicate /usr/share/licenses/arianna/GPL-3.0-or-later.txt /usr/share/licenses/arianna/GPL-3.0-only.txt arianna.x86_64: W: files-duplicate /usr/share/licenses/arianna/LGPL-2.1-or-later.txt /usr/share/licenses/arianna/LGPL-2.1-only.txt arianna.x86_64: W: files-duplicate /usr/share/licenses/arianna/LGPL-3.0-or-later.txt /usr/share/licenses/arianna/LGPL-3.0-only.txt ============== 4 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 5.5 s ============= Rpmlint (debuginfo) ------------------- Checking: arianna-debuginfo-1.0.1-1.fc39.x86_64.rpm ============================================= rpmlint session starts ============================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpywmn8yl8')] checks: 31, packages: 1 ============== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.3 s ============= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 arianna.x86_64: W: no-manual-page-for-binary arianna arianna.x86_64: E: files-duplicated-waste 102735 arianna.x86_64: W: files-duplicate /usr/share/licenses/arianna/GPL-3.0-or-later.txt /usr/share/licenses/arianna/GPL-3.0-only.txt arianna.x86_64: W: files-duplicate /usr/share/licenses/arianna/LGPL-2.1-or-later.txt /usr/share/licenses/arianna/LGPL-2.1-only.txt arianna.x86_64: W: files-duplicate /usr/share/licenses/arianna/LGPL-3.0-or-later.txt /usr/share/licenses/arianna/LGPL-3.0-only.txt 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 6.6 s Source checksums ---------------- https://invent.kde.org/graphics/arianna/-/archive/v1.0.1/arianna-v1.0.1.tar.gz : CHECKSUM(SHA256) this package : be5a171a282fc5dfd196d9986a2199dfbc53f7ae391d4dd97044d7ad0168a30c CHECKSUM(SHA256) upstream package : be5a171a282fc5dfd196d9986a2199dfbc53f7ae391d4dd97044d7ad0168a30c Requires -------- arianna (rpmlib, GLIBC filtered): libKF5Archive.so.5()(64bit) libKF5Baloo.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5DBusAddons.so.5()(64bit) libKF5FileMetaData.so.3()(64bit) libKF5I18n.so.5()(64bit) libKF5WindowSystem.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5QuickControls2.so.5()(64bit) libQt5QuickControls2.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5WebEngine.so.5()(64bit) libQt5WebEngine.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) arianna-debuginfo (rpmlib, GLIBC filtered): arianna-debugsource (rpmlib, GLIBC filtered): Provides -------- arianna: application() application(org.kde.arianna.desktop) arianna arianna(x86-64) metainfo() metainfo(org.kde.arianna.appdata.xml) mimehandler(application/epub+zip) arianna-debuginfo: arianna-debuginfo arianna-debuginfo(x86-64) debuginfo(build-id) arianna-debugsource: arianna-debugsource arianna-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2188970 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, Ruby, SugarActivity, PHP, R, Perl, Ocaml, Haskell, fonts, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Is it possible to run the tests? b) Usually the description section provides additional information to what is in the summary. c) Use desktop-file-validate : https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files d) Can the licenses in the spec file be updated and a license breakdown given? See https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05842133-arianna/fedora-review/licensecheck.txt
Thanks for that! I have done all the required changes, and updated the src.rpm and spec. Let me know!
Re-updated. Forgot %cmake_kf5, as this is a KDE app.
[fedora-review-service-build]
Spec URL: https://api.nicehomeservices.com/images/temp/arianna.spec SRPM URL: https://api.nicehomeservices.com/images/temp/arianna-1.0.1-1.fc39.src.rpm
Created attachment 1962504 [details] The .spec file difference from Copr build 5842133 to 5879608
Copr build: https://copr.fedorainfracloud.org/coprs/build/5879608 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05879608-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
a) Build failures due to missing Qt5Webengine https://copr.fedorainfracloud.org/coprs/fed500/arianna/build/5881414/ May want to add a line similar to: https://src.fedoraproject.org/rpms/qt5-qtwebengine/blob/rawhide/f/qt5-qtwebengine.spec#_128 b) Tests do not seem to run, commented out: https://invent.kde.org/graphics/arianna/-/blob/0bbb654231945704c0b288a2a3caf8f6d5b24a3b/src/autotests/CMakeLists.txt Should these be uncommented?
Copr build: https://copr.fedorainfracloud.org/coprs/build/5890527 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05890527-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I have done the changes for qt5-webengine as you suggested. As far as the tests. I created a patch to uncomment them, but looking at mockbuild's output, I still don'T think tests are running for some reason... maybe something somewhere isn't wired in correctly to do tests?
Copr build: https://copr.fedorainfracloud.org/coprs/build/5890559 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2188970-arianna/fedora-rawhide-x86_64/05890559-arianna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for the update. Checking on the tests. Error from Fedora review: arianna.src: E: description-line-too-long An ebook reader and library management app supporting ".epub" files. Arianna discovers your books automatically, and sorts them by categories, genres and authors. For the description probably something like An ebook reader and library management app is sufficient?
(In reply to Benson Muite from comment #15) > Thanks for the update. Checking on the tests. Error from Fedora review: > > arianna.src: E: description-line-too-long An ebook reader and library > management app supporting ".epub" files. Arianna discovers your books > automatically, and sorts them by categories, genres and authors. > > For the description probably something like > > An ebook reader and library management app > > is sufficient? Agreed, updated spec/srpm with the shorter description.
The basic tests work when using kde-src build to create the executable, but it seems something more is needed when building within Fedora. Can probably remove %ctest as it does not do anything. Seems very few KDE apps run tests. Following https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage can you move the %check section after install and also use appstream-util validate-relax: %check desktop-file-validate %{buildroot}/%{_datadir}/applications/org.kde.arianna.desktop appstream-util validate-relax --nonet %{buildroot}%{_kf5_metainfodir}/org.kde.arianna.appdata.xml Will need to add BuildRequires: libappstream-glib It built on aarch64: https://copr.fedorainfracloud.org/coprs/fed500/arianna/build/5939566/
Done, I've done all the changes you asked for and some additional ones: - Removed the tests patch (Don't need a tests patch if we aren't running any tests, right?) - I also added a dependancy for cmale(KF5QuickCharts) after looking at recent commits in the project (Specifically this one: https://invent.kde.org/graphics/arianna/-/commit/d3c23509c7d17191b4af1ad9f6b870fa3e944ff3) Thanks!
Re-updated with a "echo" line I added as a test in the spec... that doesn'T belong there anymore. [fedora-review-service-build]
*Removed an "echo" line, sorry.
Thanks. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/arianna