Spec URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05849303-golang-github-pin-tftp-3/golang-github-pin-tftp.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05849303-golang-github-pin-tftp-3/golang-github-pin-tftp-3-3.0.0-1.fc38.src.rpm Description: TFTP server and client library for Golang Fedora Account System Username: mavjs Here is a build in copr: https://copr.fedorainfracloud.org/coprs/mavjs/package-reviews/build/5849303/ This package is required to update gobuster to latest stable version: v3.5.0 Current gobuster package version in Fedora is currently at: v3.1.0 Note: I am not a fedora packager yet and will require a sponsor.
> golang-github-pin-tftp.spec The filename of spec MUST match the name of the package. Rename to golang-github-pin-tftp-3.spec > %global forgeurl1 https://github.com/pin/tftp Isn't really needed, it is deduced automatically
(In reply to Pavel Solovev from comment #1) > > golang-github-pin-tftp.spec > The filename of spec MUST match the name of the package. Rename to > golang-github-pin-tftp-3.spec Done. See new build link below. > > %global forgeurl1 https://github.com/pin/tftp > Isn't really needed, it is deduced automatically This was removed as well. Note: I deleted the previous builds and therefore, here are the new links: SPEC URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05852501-golang-github-pin-tftp-3/golang-github-pin-tftp-3.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05852501-golang-github-pin-tftp-3/golang-github-pin-tftp-3-3.0.0-1.fc38.src.rpm COPR URL: https://copr.fedorainfracloud.org/coprs/mavjs/package-reviews/build/5852501/
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. Thanks!
Ah, and the last thing - on import, remove the `-f` flag from %gometa, gobuster is still built for i386.
(In reply to Pavel Solovev from comment #4) > Ah, and the last thing - on import, remove the `-f` flag from %gometa, > gobuster is still > built for i386. Will do. Thanks for the review.
Maverick, I see that you are already a member of the 'packager' group: https://accounts.fedoraproject.org/user/mavjs/ Do you still need a sponsor?
(In reply to Debarshi Ray from comment #6) > Maverick, I see that you are already a member of the 'packager' group: > https://accounts.fedoraproject.org/user/mavjs/ > > Do you still need a sponsor? Hey rishi, thanks for reaching out (via email as well). I got sponsored by nirik (Kevin). I just need to follow up with the steps to continue. -Maverick
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pin-tftp-3
FEDORA-2023-b80d36465b has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b80d36465b
FEDORA-2023-b80d36465b has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
Hello, this package is needed for the gobuster 3.5.0 - https://src.fedoraproject.org/rpms/gobuster Please would you mind building the golang-github-pin-tftp-3 also for the F38 F37 ? Thank you Michal Ambroz