Bug 2190039 - Review Request: tepl - Text editor product line library
Summary: Review Request: tepl - Text editor product line library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://gitlab.gnome.org/swilmet/tepl
Whiteboard:
Depends On:
Blocks: 2180562
TreeView+ depends on / blocked
 
Reported: 2023-04-26 22:07 UTC by Yaakov Selkowitz
Modified: 2023-06-09 01:59 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-06-09 01:59:37 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)

Description Yaakov Selkowitz 2023-04-26 22:07:41 UTC
Spec URL: https://yselkowitz.fedorapeople.org/tepl.spec
SRPM URL: https://yselkowitz.fedorapeople.org/tepl-6.4.0-1.fc39.src.rpm
Description: Tepl is a library that eases the development of GtkSourceView-based text editors and IDEs. Tepl is the acronym for “Text editor product line”.
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2023-04-26 22:19:43 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5853176
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2190039-tepl/fedora-rawhide-x86_64/05853176-tepl/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Yaakov Selkowitz 2023-04-26 22:22:37 UTC
> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://src.fedoraproject.org/rpms/tepl

This is for an unretirement.

Comment 3 Artur Frenszek-Iwicki 2023-04-27 08:57:19 UTC
> Version:        6.4.0
Lucky you, v6.5.1 has just been released: https://gitlab.gnome.org/swilmet/tepl/-/tags/6.5.1

Comment 4 Yaakov Selkowitz 2023-04-27 12:19:59 UTC
(In reply to Artur Frenszek-Iwicki from comment #3)
> Lucky you, v6.5.1 has just been released:
> https://gitlab.gnome.org/swilmet/tepl/-/tags/6.5.1

tepl still follows the odd-even versioning scheme, so that is a development snapshot corresponding to gedit 45~alpha.  First we want 6.4.0 (a stable release) for gedit 44 in F38.

Comment 5 Benson Muite 2023-04-27 17:59:02 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/tepl
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 3", "*No copyright* GNU Lesser General Public License, Version
     3". 62 files have unknown license. Detailed output of licensecheck in
     /home/FedoraPackaging/reviews/tepl/2190039-tepl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib64/girepository-1.0(harfbuzz, libtracker-sparql, at-spi2-core,
     gtksourceview5, javascriptcoregtk4.1, libgexiv2, fcitx-libs, libjcat,
     libgdl, gnome-bluetooth-libs, libsoup, gplugin-libs, webkit2gtk4.0,
     libmypaint, libgee, geoclue2-libs, grilo, javascriptcoregtk4.0,
     libcryptui, libgxps, libgnomekbd, libarrow-glib-libs, gupnp-igd,
     libgtop2, vte, gfbgraph, libmodulemd, libmanette, gitg-libs,
     goocanvas2, GConf2, gnome-bluetooth3.34-libs, gupnp-dlna, ghex-libs,
     playerctl-libs, gobject-introspection, template-glib, parquet-glib-
     libs, gst-devtools, libarrow-dataset-glib-libs, gtk2, accountsservice-
     libs, libxmlb, jsonrpc-glib, gucharmap-libs, libarrow-flight-libs,
     webkitgtk6.0, rygel, gupnp-av, gssdp, libchamplain, libgdata, glade-
     libs, malcontent-ui-libs, libgepub, graphene, librsvg2, gcr3, zbar-
     gtk, gdk-pixbuf2, javascriptcoregtk6.0, libpanel, appstream,
     malcontent-libs, libsoup3, libinsane-gobject, vte291, libxklavier,
     libdmapsharing4, libshumate, gmime30, libmash, libhandy, amtk, json-
     glib, ibus-libs, libdazzle, libsecret, libdex, gtk3, gsequencer,
     gnome-autoar, gnome-menus, gtk4, gcr-libs, libmodulemd1, libgee06,
     gnome-calculator, atk, gplugin-gtk4-libs, gsound, vips, gspell,
     gtksourceview4, webkit2gtk4.1, clutter, babl, gnome-online-accounts,
     libgnome-keyring, gupnp, gstreamer1-rtsp-server, libpeas),
     /usr/share/gir-1.0(jsonrpc-glib-devel, libdex-devel, clapper-devel,
     javascriptcoregtk6.0-devel, gupnp-dlna-devel, gupnp-igd-devel,
     javascriptcoregtk4.0-devel, libsecret-devel, libinsane-gobject-devel,
     libarrow-glib-devel, parquet-glib-devel, gsound-devel, gdk-
     pixbuf2-devel, gplugin-devel, libmypaint-devel, libchamplain-devel,
     gdm-devel, gucharmap-devel, amtk-devel, glade-devel,
     libdmapsharing4-devel, gnome-calculator-devel, webkit2gtk4.0-devel,
     libgnome-keyring-devel, gnome-bluetooth-libs-devel, vte291-devel,
     gnome-autoar-devel, gtk4-devel, vte-devel, totem-pl-parser-devel,
     libxmlb-devel, babl-devel, rygel-devel, graphene-devel, zbar-gtk-
     devel, json-glib-devel, libsoup3-devel, libxklavier-devel, gcr-devel,
     gtk3-devel, libarrow-dataset-glib-devel, gstreamer1-rtsp-server-devel,
     malcontent-devel, gssdp-devel, malcontent-ui-devel,
     webkit2gtk4.1-devel, gitg-devel, gspell-devel, libsoup-devel,
     libgexiv2-devel, fcitx-devel, libcryptui-devel, template-glib-devel,
     gtksourceview4-devel, gmime30-devel, gupnp-av-devel, libadwaita-devel,
     fcitx5-gtk-devel, GConf2-devel, libgdata-devel, libdazzle-devel,
     gtksourceview5-devel, budgie-desktop-devel, bamf-devel, ghex-devel,
     harfbuzz-devel, libpanel-devel, gnome-online-accounts-devel, at-
     spi2-core-devel, appstream-devel, ibus-devel, librsvg2-devel,
     libhandy-devel, webkitgtk6.0-devel, gcr3-devel, libgxps-devel, gst-
     devtools-devel, gnome-bluetooth3.34-libs-devel, gfbgraph-devel, vips-
     devel, gobject-introspection-devel, gsequencer-devel, gplugin-
     gtk4-devel, libgtop2-devel, geoclue2-devel, gtk2-devel, libgepub-
     devel, libgnomekbd-devel, grilo-devel, libgee06-devel, libpeas-devel,
     libgee-devel, libmodulemd1-devel, colord-gtk-devel, clutter-devel,
     gupnp-devel, libmanette-devel, libmodulemd-devel, goocanvas2-devel,
     libmash-devel, libshumate-devel, tracker-devel,
     javascriptcoregtk4.1-devel, libjcat-devel, atk-devel, gnome-menus-
     devel, gegl04-devel, accountsservice-devel, libgdl-devel),
     /usr/share/gtk-doc(gtk3-devel-docs, webkit2gtk4.0-doc, poppler-glib-
     doc, raptor2-devel, gupnp-igd-devel, libldm-devel, garcon-devel,
     switcheroo-control-docs, gegl04-devel-docs, cheese-libs-devel,
     libinsane-gobject-devel, gnome-panel-devel, gsound-devel, libu2f-host-
     devel, libunity-gtk-parser-devel, flatpak-devel, gdk-pixbuf2-xlib-
     devel, libchamplain-devel, clutter-doc, amtk-devel, webkit2gtk4.1-doc,
     glade-devel, unique3-docs, gimp-devel, power-profiles-daemon-docs,
     libgnome-keyring-devel, gom-devel, gnome-bluetooth-libs-devel, libnma-
     devel, gnome-autoar-devel, gspell-doc, anaconda-widgets-devel,
     libgnome-devel, libxmlb-devel, libgnt-doc, rygel-devel,
     libcloudproviders-devel, libfm-devel-docs, iio-sensor-proxy-docs,
     graphene-devel, unique-devel, fprintd-devel, appstream-compose-devel,
     libwnck-devel, libwnck3-devel, gtk2-devel-docs, libxklavier-devel,
     gedit-devel, gtk-doc, lasem-devel, gnome-software-devel,
     libgexiv2-devel, polkit-docs, gsequencer-devel-doc, libgda-devel,
     libgpod-doc, libcryptui-devel, template-glib-devel, libxfce4util-
     devel, gtksourceview4-devel, gmime30-devel, ibus-devel-docs, libgdata-
     devel, gtkspell3-devel, gupnp-dlna-docs, libdazzle-devel, tumbler-
     devel, libgit2-glib-devel, bamf-devel, exo-devel, libgweather-devel,
     harfbuzz-devel, gnome-online-accounts-devel, gnome-desktop3-devel,
     redland-devel, glib2-doc, libcanberra-devel, gtranslator, libdbusmenu-
     doc, parole-devel, libgxps-devel, tomoe-devel, gnome-
     bluetooth3.34-libs-devel, buildstream-docs, gfbgraph-devel,
     libxfce4ui-devel, libxml2-devel, clipsmm-doc, vips-devel, gobject-
     introspection-devel, libgda5-devel, libgtop2-devel, geoclue2-devel,
     geocode-glib2-devel, libxslt-devel, dconf-devel, gupnp-av-docs,
     nautilus-python-devel, rasqal-devel, xfconf-devel, ORBit2-devel,
     libmodulemd1-devel, dbus-doc, libsoup-doc, colord-gtk-devel, geocode-
     glib-devel, upower-devel-docs, libmodulemd-devel, playerctl-docs,
     goocanvas2-devel, clutter-gst3-devel, webkitgtk6.0-doc, gtkimageview-
     devel, gtkdatabox-devel, low-memory-monitor-doc, libglib-testing-
     devel, p11-kit-devel, anjuta-devel, libarrow-glib-doc, libidn2-devel,
     libjcat-devel, eog-devel, udisks-devel, cutter-devel, libgdl-devel),
     /usr/share/gtk-doc/html(gtk3-devel-docs, webkit2gtk4.0-doc, poppler-
     glib-doc, raptor2-devel, gupnp-igd-devel, libldm-devel, garcon-devel,
     switcheroo-control-docs, gegl04-devel-docs, cheese-libs-devel,
     libinsane-gobject-devel, gnome-panel-devel, gsound-devel, libu2f-host-
     devel, libunity-gtk-parser-devel, flatpak-devel, gdk-pixbuf2-xlib-
     devel, libchamplain-devel, clutter-doc, amtk-devel, webkit2gtk4.1-doc,
     glade-devel, unique3-docs, gimp-devel, power-profiles-daemon-docs,
     libgnome-keyring-devel, gom-devel, gnome-bluetooth-libs-devel, libnma-
     devel, gnome-autoar-devel, gspell-doc, anaconda-widgets-devel,
     libgnome-devel, libxmlb-devel, libgnt-doc, rygel-devel,
     libcloudproviders-devel, libfm-devel-docs, iio-sensor-proxy-docs,
     graphene-devel, unique-devel, fprintd-devel, appstream-compose-devel,
     libwnck-devel, libwnck3-devel, gtk2-devel-docs, libxklavier-devel,
     gedit-devel, lasem-devel, gnome-software-devel, libgexiv2-devel,
     polkit-docs, gsequencer-devel-doc, libgda-devel, libgpod-doc,
     libcryptui-devel, template-glib-devel, libxfce4util-devel,
     gtksourceview4-devel, gmime30-devel, ibus-devel-docs, libgdata-devel,
     gtkspell3-devel, gupnp-dlna-docs, libdazzle-devel, tumbler-devel,
     libgit2-glib-devel, bamf-devel, exo-devel, libgweather-devel,
     harfbuzz-devel, gnome-online-accounts-devel, gnome-desktop3-devel,
     redland-devel, glib2-doc, libcanberra-devel, gtranslator, libdbusmenu-
     doc, parole-devel, libgxps-devel, tomoe-devel, gnome-
     bluetooth3.34-libs-devel, buildstream-docs, gfbgraph-devel,
     libxfce4ui-devel, libxml2-devel, clipsmm-doc, vips-devel, gobject-
     introspection-devel, libgda5-devel, libgtop2-devel, xed-doc,
     geoclue2-devel, geocode-glib2-devel, libxslt-devel, dconf-devel,
     gupnp-av-docs, nautilus-python-devel, rasqal-devel, xfconf-devel,
     ORBit2-devel, libmodulemd1-devel, dbus-doc, libsoup-doc, colord-gtk-
     devel, geocode-glib-devel, libmodulemd-devel, playerctl-docs,
     goocanvas2-devel, clutter-gst3-devel, webkitgtk6.0-doc, gtkimageview-
     devel, gtkdatabox-devel, low-memory-monitor-doc, budgie-desktop-docs,
     libglib-testing-devel, p11-kit-devel, anjuta-devel, libarrow-glib-doc,
     libidn2-devel, libjcat-devel, eog-devel, udisks-devel, cutter-devel,
     libgdl-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tepl-
     devel
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1894400 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: tepl-6.4.0-1.fc39.x86_64.rpm
          tepl-devel-6.4.0-1.fc39.x86_64.rpm
          tepl-debuginfo-6.4.0-1.fc39.x86_64.rpm
          tepl-debugsource-6.4.0-1.fc39.x86_64.rpm
          tepl-6.4.0-1.fc39.src.rpm
============================================= rpmlint session starts ============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp85xh1po1')]
checks: 31, packages: 5

tepl.src: W: strange-permission tepl.spec 600
============== 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 4.3 s =============




Rpmlint (debuginfo)
-------------------
Checking: tepl-debuginfo-6.4.0-1.fc39.x86_64.rpm
============================================= rpmlint session starts ============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpggxkndkj')]
checks: 31, packages: 1

============== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.7 s =============





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 4.7 s 



Source checksums
----------------
https://download.gnome.org/sources/tepl/6.4/tepl-6.4.0.tar.xz :
  CHECKSUM(SHA256) this package     : 5e56b20669d0cf05fa1d64b58c8c342c59158122dc518100d093d59df9b87321
  CHECKSUM(SHA256) upstream package : 5e56b20669d0cf05fa1d64b58c8c342c59158122dc518100d093d59df9b87321


Requires
--------
tepl (rpmlib, GLIBC filtered):
    libamtk-5.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libgtksourceview-4.so.0()(64bit)
    libicui18n.so.72()(64bit)
    libicuuc.so.72()(64bit)
    libpango-1.0.so.0()(64bit)
    rtld(GNU_HASH)

tepl-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libtepl-6.so.2()(64bit)
    pkgconfig(amtk-5)
    pkgconfig(gio-2.0)
    pkgconfig(gsettings-desktop-schemas)
    pkgconfig(gtk+-3.0)
    pkgconfig(gtksourceview-4)
    pkgconfig(icu-i18n)
    pkgconfig(icu-uc)
    tepl(x86-64)

tepl-debuginfo (rpmlib, GLIBC filtered):

tepl-debugsource (rpmlib, GLIBC filtered):



Provides
--------
tepl:
    libtepl-6.so.2()(64bit)
    tepl
    tepl(x86-64)

tepl-devel:
    pkgconfig(tepl-6)
    tepl-devel
    tepl-devel(x86-64)

tepl-debuginfo:
    debuginfo(build-id)
    libtepl-6.so.2-6.4.0-1.fc39.x86_64.debug()(64bit)
    tepl-debuginfo
    tepl-debuginfo(x86-64)

tepl-debugsource:
    tepl-debugsource
    tepl-debugsource(x86-64)



Diff spec file in url and in SRPM
---------------------------------
--- /home/FedoraPackaging/reviews/tepl/2190039-tepl/srpm/tepl.spec      2023-04-27 13:31:32.868090260 +0300
+++ /home/FedoraPackaging/reviews/tepl/2190039-tepl/srpm-unpacked/tepl.spec     2023-04-27 01:02:44.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.3.5)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global apiver 6
 
@@ -69,3 +79,71 @@
 
 %changelog
-%autochangelog
+* Wed Apr 26 2023 Yaakov Selkowitz <yselkowi> - 6.4.0-1
+- tepl 6.4.0
+
+* Thu May 20 2021 Pete Walter <pwalter> - 6.00.0-2
+- Rebuild for ICU 69
+
+* Wed Mar 24 2021 Kalev Lember <klember> - 6.00.0-1
+- Update to 6.00.0
+
+* Thu Feb 18 2021 Kalev Lember <klember> - 5.1.1-1
+- Update to 5.1.1
+
+* Wed Jan 27 2021 Fedora Release Engineering <releng> - 5.0.1-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
+
+* Wed Nov 25 2020 Kalev Lember <klember> - 5.0.1-1
+- Update to 5.0.1
+
+* Fri Sep 11 2020 Kalev Lember <klember> - 5.0.0-1
+- Update to 5.0.0
+
+* Fri Sep 04 2020 Kalev Lember <klember> - 4.99.4-1
+- Update to 4.99.4
+
+* Wed Jul 29 2020 Fedora Release Engineering <releng> - 4.99.3-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
+
+* Mon Jul 20 2020 Kalev Lember <klember> - 4.99.3-1
+- Update to 4.99.3
+
+* Fri May 29 2020 Kalev Lember <klember> - 4.99.2-1
+- Update to 4.99.2
+- Switch to the meson build system
+- Drop the -tests subpackage (installed tests removed upstream)
+- Remove old gtef obsoletes
+
+* Thu Mar 05 2020 Kalev Lember <klember> - 4.4.0-1
+- Update to 4.4.0
+
+* Fri Jan 31 2020 Fedora Release Engineering <releng> - 4.3.1-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
+
+* Mon Dec 02 2019 Kalev Lember <klember> - 4.3.1-1
+- Update to 4.3.1
+
+* Wed Nov 27 2019 Kalev Lember <klember> - 4.2.1-1
+- Update to 4.2.1
+
+* Sat Jul 27 2019 Fedora Release Engineering <releng> - 4.2.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
+
+* Mon Mar 11 2019 Phil Wyett <philwyett> - 4.2.0-1
+- Update to 4.2.0
+
+* Sun Feb 03 2019 Fedora Release Engineering <releng> - 3.0.0-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
+
+* Sat Aug 04 2018 Kalev Lember <klember> - 3.0.0-4
+- Obsolete gtef (#1612444)
+
+* Sat Jul 14 2018 Fedora Release Engineering <releng> - 3.0.0-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
+
+* Fri Feb 09 2018 Fedora Release Engineering <releng> - 3.0.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
+
+* Sun Oct 29 2017 Kalev Lember <klember> - 3.0.0-1
+- Initial Fedora packaging
+


Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2190039
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: R, Perl, Ocaml, Ruby, fonts, Python, SugarActivity, PHP, Java, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) Is it worth keeping the history from the older spec file?
b) Is it possible to run tests?
c) Should gtk-sourceview3 be used rather than gtk-sourceview4?
https://gitlab.gnome.org/swilmet/tepl/-/blob/main/meson.build#L24

Comment 6 Yaakov Selkowitz 2023-04-27 19:31:37 UTC
(In reply to Benson Muite from comment #5)
> a) Is it worth keeping the history from the older spec file?

It is, but you can't tell from the downloads.  Locally I have the following commits:

- Unretire package (iow revert the retirement)
- Convert to %autochangelog (which saves the previous history in a changelog file)
- Update to 6.4.0 (the remaining changes which results in this spec&SRPM)

> b) Is it possible to run tests?

Most of the tests require a graphical server, so not worth the trouble IMO.

> c) Should gtk-sourceview3 be used rather than gtk-sourceview4?
> https://gitlab.gnome.org/swilmet/tepl/-/blob/main/meson.build#L24

That's a new requirement in 6.5+ (development version), doesn't apply to 6.4:

https://gitlab.gnome.org/swilmet/tepl/-/blob/6.4.0/meson.build?ref_type=tags#L23

Comment 7 Yaakov Selkowitz 2023-05-04 17:23:37 UTC
Benson, do you plan on continuing this review?

Comment 8 Benson Muite 2023-05-05 09:09:25 UTC
Builds on all architectures:
https://copr.fedorainfracloud.org/coprs/fed500/tepl/build/5879492/

Approved.

Comment 9 Fedora Update System 2023-05-29 17:43:15 UTC
FEDORA-2023-e83d7a66eb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e83d7a66eb

Comment 10 Fedora Update System 2023-06-09 01:59:37 UTC
FEDORA-2023-e83d7a66eb has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.