Bug 2190167 - perl-Test2-Suite-0.000152 is available [NEEDINFO]
Summary: perl-Test2-Suite-0.000152 is available
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Test2-Suite
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Josef Spacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-27 11:18 UTC by Upstream Release Monitoring
Modified: 2023-05-03 09:08 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-04-27 17:44:10 UTC
Type: ---
Embargoed:
mspacek: needinfo?


Attachments (Terms of Use)

Description Upstream Release Monitoring 2023-04-27 11:18:36 UTC
Releases retrieved: 0.000152
Upstream release that is considered latest: 0.000152
Current version/release in rawhide: 0.000150-1.fc39
URL: http://search.cpan.org/dist/Test2-Suite/

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from Anitya: https://release-monitoring.org/project/9536/


To change the monitoring settings for the project, please visit:
https://src.fedoraproject.org/rpms/perl-Test2-Suite

Comment 1 Michal Josef Spacek 2023-04-27 15:21:11 UTC
Changes:
0.000152  2023-04-27 02:52:44-07:00 America/Los_Angeles
 
    - Inline Importer.pm for core support
 
0.000151  2023-04-27 02:35:37-07:00 America/Los_Angeles
 
    - The following are all in hopes of getting Test2:Suite into core.
    - Make Module::Pluggable optional
    - Inline Scope::Guard
    - Inline Sub::Info
    - Do not recommend Sub::Name

API changes, only for rawhide.

Comment 2 Petr Pisar 2023-04-28 08:46:43 UTC
"Inline..." means bundling. E.g. a difference in a code of Importer and Test2::Util::Importer is exactly this:

--- ../../perl-Importer/Importer-0.026/lib/Importer.pm  2020-08-16 23:24:02.000000000 +0200
+++ lib/Test2/Util/Importer.pm  2023-04-27 11:52:45.000000000 +0200
@@ -1,8 +1,8 @@
-package Importer;
+package Test2::Util::Importer;
 use strict; no strict 'refs';
 use warnings; no warnings 'once';
 
-our $VERSION = '0.026';
+our $VERSION = '0.000152';
 
 my %SIG_TO_SLOT = (
     '&' => 'CODE',
@@ -763,7 +763,7 @@
 # their import redefines things.
 BEGIN { \${^WARNING_BITS} = \$caller->[9] if defined \$caller->[9] };
 #line $caller->[2] "$caller->[1]"
-(*{"$into\\::\$_"} = \$final{\$_}, push \@{\$Importer::IMPORTED{\$into}} => \$_) for keys %final;
+(*{"$into\\::\$_"} = \$final{\$_}, push \@{\$Test2::Util::Importer::IMPORTED{\$into}} => \$_) for keys
 %final;
 1;
     EOT
 }

I really recommend unbundling the modules. Otherwise you are going to maintain the same code on multiple places.

If you are going to continue bundling them, then you have follow Fedora guidelines on bundling <https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling>. I.e. adding "Provides: bundled(Importer) = 0.026".

Comment 3 Michal Josef Spacek 2023-04-28 09:08:11 UTC
@ppisar Yes I know, that's a question what about this kind of bundling? I am going to talk with author.

Comment 4 Michal Josef Spacek 2023-04-28 09:27:24 UTC
I created question to author of module (https://github.com/Test-More/Test2-Suite/issues/266)

Comment 5 Michal Josef Spacek 2023-05-02 13:45:37 UTC
@ppisar 

You could read the discussion above. My result is to stay as is.
But I don't like this kind of change for Perl Core too.

Comment 6 Petr Pisar 2023-05-02 14:02:19 UTC
Could you add the bundled() RPM symbols to Provides? It helps security team to discover all places where an affected code is packaged.

Comment 7 Michal Josef Spacek 2023-05-03 09:08:15 UTC
@ppisar I added to perl-Test2-Suite-0.000155-1.fc39, thanks.


Note You need to log in before you can comment on or make changes to this bug.