Bug 2190275 - pyhoca-cli cannot resume session with remmina-plugins-x2go
Summary: pyhoca-cli cannot resume session with remmina-plugins-x2go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pyhoca-cli
Version: 38
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-27 18:08 UTC by André Auzi
Modified: 2023-06-06 01:45 UTC (History)
1 user (show)

Fixed In Version: pyhoca-cli-0.6.1.3~20220916git7303ada-1.fc38
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-06 01:45:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description André Auzi 2023-04-27 18:08:44 UTC
Due to pyhoca-cly bug, actually already fixed upstream, resume of X2GO session is impossible in Remmina.

Reproducible: Always

Steps to Reproduce:
1.Start an X2GO session with remmina
2.Close the session window
3.Try to resume de session
Actual Results:  
Session resume fails and the trace logs shows:

pyhoca-cli[162387] (PyHocaCLI) NOTICE: give the X2Go session some time to come up...
Traceback (most recent call last):
  File "/usr/bin/pyhoca-cli", line 455, in <module>
    thisPyHocaCLI.MainLoop()
  File "/usr/lib/python3.11/site-packages/pyhoca/cli/frontend.py", line 702, in MainLoop
    self.resume_session(self.x2go_session_hash)
  File "/usr/lib/python3.11/site-packages/pyhoca/cli/frontend.py", line 229, in resume_session
    if available_sessions is None:
       ^^^^^^^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'available_sessions' where it is not associated with a value


Expected Results:  
Normal resume of the session.

versions:
* pyhoca-cli-0.6.1.2-11.fc38
* remmina-plugins-x2go-1.4.30-1.fc38
* remmina-1.4.30-1.fc38

upstream actually fixed this BUG by commit:
2020-03-11 	pyhoca/cli/frontend.py: Fix reference before assignment...
[https://code.x2go.org/pyhoca-cli?p=pyhoca-cli.git;a=commit;h=2b507520a7b4984d7020a6d5153d29350a24a9a9]

Unfortunately, this did not result in an actual hotfix release.

However (IMHO), to improve user experience with remmina, which is an awesome RDP software, it would be desirable to 'patch' the pyhoca-cli package and use, the git repo on a more recent commit than the obsolete packaged 0.6.1.2 version.

Additionally, the remmina plugin seems to use features more recent that this previsouly mentionned commit.

As the following traces show:
** (org.remmina.Remmina:162142): CRITICAL **: 19:01:16.996: (rmplugin_x2go_spawn_pyhoca_process) - [X2GO] Impossible de lancer PyHoca-CLI :
usage: pyhoca-cli [-h] [--server SERVER] [-c COMMAND] [-l USERNAME]
                  [--password PASSWORD] [--force-password]
                  [-p REMOTE_SSH_PORT] [-i SSH_PRIVKEY] [--add-to-known-hosts]
                  [--sound {pulse,esd,none}] [--printing]
                  [--share-mode SHARE_MODE] [-F <folder1>[,<folder2[,...]]]
                  [--clean-sessions] [--terminate-on-ctrl-c]
                  [--auth-attempts AUTH_ATTEMPTS] [-A]
                  [--print-action {PDFVIEW,PDFSAVE,PRINT,PRINTCMD,DIALOG}]
                  [--pdfview-cmd PDFVIEW_CMD] [--save-to-folder PRINT_DEST]
                  [--printer PRINTER] [--print-cmd PRINT_CMD] [-B BROKER_URL]
                  [--broker-password BROKER_PASSWORD] [-N] [--try-resume]
                  [-R SESSION_NAME] [-D USER@DISPLAY] [-S SESSION_NAME]
                  [-T SESSION_NAME] [-L] [--list-desktops] [--list-profiles]
                  [-P SESSION_PROFILE] [--from-stdin] [-d] [--quiet]
                  [--libdebug] [--libdebug-sftpxfer] [-V] [-g GEOMETRY] [-x]
                  [-q {modem,isdn,adsl,wan,lan}] [-t {desktop,application}]
                  [--pack PACK] [--kbd-type KBD_TYPE]
                  [--kbd-layout KBD_LAYOUT]
                  [--backend-controlsession <CONTROLSESSION_BACKEND>]
                  [--backend-terminalsession <TERMINALSESSION_BACKEND>]
                  [--backend-serversessioninfo <SERVERSESSIONINFO_BACKEND>]
                  [--backend-serversessionlist <SERVERSESSIONLIST_BACKEND>]
                  [--backend-proxy <PROXY_BACKEND>]
                  [--backend-sessionprofiles <SESSIONPROFILES_BACKEND>]
                  [--backend-clientsettings <CLIENTSETTINGS_BACKEND>]
                  [--backend-clientprinting <CLIENTPRINTING_BACKEND>]
                  [--port PORT] [--ssh-key SSH_KEY] [--use-sound {yes,no}]
                  [--client-ssh-port CLIENT_SSH_PORT]
                  [host]
pyhoca-cli: error: unrecognized arguments: --list-cmdline-features

This feature seems finalized upstream by commit [https://code.x2go.org/pyhoca-cli?p=pyhoca-cli.git;a=commit;h=22b8402428a5b7e13eb5094e1961b07907c38520]

Comment 1 Fedora Update System 2023-05-28 22:37:18 UTC
FEDORA-2023-56f9263530 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-56f9263530

Comment 2 Fedora Update System 2023-05-29 02:09:09 UTC
FEDORA-2023-56f9263530 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-56f9263530`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-56f9263530

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2023-06-06 01:45:00 UTC
FEDORA-2023-56f9263530 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.