Bug 2190315 - Review Request: oci-cli - Command Line Interface for Oracle Cloud Infrastructure
Summary: Review Request: oci-cli - Command Line Interface for Oracle Cloud Infrastructure
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/oracle/oci-cli
Whiteboard:
Depends On: 2190312
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-27 21:43 UTC by Major Hayden 🤠
Modified: 2023-05-11 21:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-11 21:28:32 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 5856601 to 5870468 (1.71 KB, patch)
2023-05-03 15:40 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 5870468 to 5908085 (335 bytes, patch)
2023-05-10 16:25 UTC, Fedora Review Service
no flags Details | Diff

Description Major Hayden 🤠 2023-04-27 21:43:51 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/oci/fedora-rawhide-x86_64/05856594-oci-cli/oci-cli.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/oci/fedora-rawhide-x86_64/05856594-oci-cli/oci-cli-3.25.4-1.fc39.src.rpm
Description: This is the command line interface for Oracle Cloud Infrastructure.
Fedora Account System Username: mhayden

Comment 2 Fedora Review Service 2023-05-03 15:40:37 UTC
Created attachment 1961989 [details]
The .spec file difference from Copr build 5856601 to 5870468

Comment 3 Fedora Review Service 2023-05-03 15:40:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5870468
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2190315-oci-cli/fedora-rawhide-x86_64/05870468-oci-cli/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Major Hayden 🤠 2023-05-03 18:51:31 UTC
Hmm, the "Depends On" is set in this ticket and the COPR builds worked fine. 🤔 https://copr.fedorainfracloud.org/coprs/mhayden/oci/builds/

Comment 5 Neil Hanlon 2023-05-04 01:54:41 UTC
(In reply to Major Hayden 🤠 from comment #4)
> Hmm, the "Depends On" is set in this ticket and the COPR builds worked fine.
> 🤔 https://copr.fedorainfracloud.org/coprs/mhayden/oci/builds/


Looking at your deps, it seems we have a common interest! I have been meaning to open reviews for circuitbreaker and the oci-sdk in order to produce oci-utils. Perhaps we can collaborate? I'd be happy to take this review.

Comment 6 Major Hayden 🤠 2023-05-04 13:50:04 UTC
That works for me, Neil!

Comment 8 Fedora Review Service 2023-05-10 16:25:25 UTC
Created attachment 1963797 [details]
The .spec file difference from Copr build 5870468 to 5908085

Comment 9 Fedora Review Service 2023-05-10 16:25:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5908085
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2190315-oci-cli/fedora-rawhide-x86_64/05908085-oci-cli/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Neal Gompa 2023-05-11 15:48:31 UTC
Package review notes:

* Package is named appropriately
* Package follows Python packaging guidelines
* Package builds and installs
* Package licensing is mostly correct, the third-party licensing documents don't apply for this package build and need to be dropped.

Note: Your Source0 format is wrong. Please follow the convention here before importing: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags

PACKAGE APPROVED.

Comment 11 Fedora Admin user for bugzilla script actions 2023-05-11 17:47:12 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/oci-cli

Comment 12 Fedora Update System 2023-05-11 21:26:01 UTC
FEDORA-2023-b65fcbcd6d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b65fcbcd6d

Comment 13 Fedora Update System 2023-05-11 21:28:32 UTC
FEDORA-2023-b65fcbcd6d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.