Bug 2190405 - Review Request: python-posix-ipc - POSIX IPC primitives (semaphores, shared memory and message queues) for Python
Summary: Review Request: python-posix-ipc - POSIX IPC primitives (semaphores, shared m...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lukáš Zaoral
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-28 10:12 UTC by Lumír Balhar
Modified: 2023-05-08 01:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-29 09:43:05 UTC
Type: ---
Embargoed:
lzaoral: fedora-review+


Attachments (Terms of Use)

Description Lumír Balhar 2023-04-28 10:12:40 UTC
Spec URL: https://lbalhar.fedorapeople.org/python-posix-ipc.spec
SRPM URL: https://lbalhar.fedorapeople.org/python-posix-ipc-1.1.1-1.fc37.src.rpm
Description: posix_ipc is a Python module (written in C) that permits creation and manipulation
of POSIX inter-process semaphores, shared memory and message queues on platforms
supporting the POSIX Realtime Extensions a.k.a. POSIX 1003.1b-1993.
This includes nearly all Unices and Windows + Cygwin ≥ 1.7.
Fedora Account System Username: lbalhar

This package was in Fedora as python-posix_ipc and therefore I'm obsoleting and providing the old name. I'm gonna update the message in dead.package for python-posix_ipc when building this.

Comment 1 Lukáš Zaoral 2023-04-28 14:40:49 UTC
LGTM!  Thanks lbalhar!  The only nitpick I have is the following rpmlint error:

> python3-posix-ipc.x86_64: E: description-line-too-long posix_ipc is a Python module (written in C) that permits creation and manipulation

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "zlib License".
     59 files have unknown license. Detailed output of licensecheck in
     /home/lukas/tmp/2190405-python-posix-ipc/licensecheck.txt

     The `zlib` licensed files are not present in the binary rpm in any form.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-posix-ipc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-posix-ipc-1.1.1-1.fc39.x86_64.rpm
          python-posix-ipc-debugsource-1.1.1-1.fc39.x86_64.rpm
          python-posix-ipc-1.1.1-1.fc39.src.rpm
==================================================================================== rpmlint session starts ====================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpplfe_vhm')]
checks: 31, packages: 3

python-posix-ipc.src: E: description-line-too-long posix_ipc is a Python module (written in C) that permits creation and manipulation
python3-posix-ipc.x86_64: E: description-line-too-long posix_ipc is a Python module (written in C) that permits creation and manipulation
===================================================== 3 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 0.7 s =====================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

python3-posix-ipc.x86_64: E: description-line-too-long posix_ipc is a Python module (written in C) that permits creation and manipulation
 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.1 s



Unversioned so-files
--------------------
python3-posix-ipc: /usr/lib64/python3.11/site-packages/posix_ipc.cpython-311-x86_64-linux-gnu.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/posix_ipc/posix_ipc-1.1.1.tar.gz :
  CHECKSUM(SHA256) this package     : e2456ba0cfb2ee5ba14121450e8d825b3c4a1461fca0761220aab66d4111cbb7
  CHECKSUM(SHA256) upstream package : e2456ba0cfb2ee5ba14121450e8d825b3c4a1461fca0761220aab66d4111cbb7


Requires
--------
python3-posix-ipc (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-posix-ipc-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-posix-ipc:
    python-posix-ipc
    python-posix_ipc
    python3-posix-ipc
    python3-posix-ipc(x86-64)
    python3-posix_ipc
    python3.11-posix-ipc
    python3.11-posix_ipc
    python3.11dist(posix-ipc)
    python3dist(posix-ipc)

python-posix-ipc-debugsource:
    python-posix-ipc-debugsource
    python-posix-ipc-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2190405
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api, C/C++
Disabled plugins: Perl, Haskell, fonts, PHP, Ocaml, R, Java, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Fedora Admin user for bugzilla script actions 2023-04-28 20:10:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-posix-ipc

Comment 3 Lumír Balhar 2023-04-28 20:11:18 UTC
The bugzilla has to be assigned to pass the process of creating a repository, see https://pagure.io/releng/fedora-scm-requests/issue/52984

Comment 4 Fedora Update System 2023-04-29 09:40:20 UTC
FEDORA-2023-37cfb4bd50 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-37cfb4bd50

Comment 5 Fedora Update System 2023-04-29 09:43:05 UTC
FEDORA-2023-37cfb4bd50 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2023-04-29 09:58:26 UTC
FEDORA-2023-8cfe1c1158 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8cfe1c1158

Comment 7 Fedora Update System 2023-04-30 02:41:00 UTC
FEDORA-2023-8cfe1c1158 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8cfe1c1158 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8cfe1c1158

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-05-08 01:49:10 UTC
FEDORA-2023-8cfe1c1158 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.