Bug 2190490 - Review Request: golang-github-hashicorp-plugin - golang plugin system over RPC
Summary: Review Request: golang-github-hashicorp-plugin - golang plugin system over RPC
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Link Dupont
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2129995
TreeView+ depends on / blocked
 
Reported: 2023-04-28 14:37 UTC by Mark E. Fuller
Modified: 2024-08-01 08:35 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-01 08:35:29 UTC
Type: ---
Embargoed:
link: fedora-review+


Attachments (Terms of Use)

Description Mark E. Fuller 2023-04-28 14:37:45 UTC
Spec URL: https://fuller.fedorapeople.org/terraform/golang-github-hashicorp-plugin.spec
SRPM URL: https://fuller.fedorapeople.org/terraform/golang-github-hashicorp-plugin-1.4.9-1.fc39.src.rpm
Description: golang plugin system over RPC
Fedora Account System Username: fuller

Comment 1 Link Dupont 2023-06-30 16:58:42 UTC
A few small commits have been released since 1.4.9; consider bumping the version to 1.4.10. https://github.com/hashicorp/go-plugin/compare/v1.4.9...v1.4.10

Some .gitignore files are included in the package via %godocs including examples. Consider removing them during %prep.

> golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/basic/.gitignore
> golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/grpc/.gitignore
> golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/negotiated/.gitignore

%prep
%goprep
%autopatch -p1
find . -iname .gitignore -exec rm {} \;

Approving the package, but consider them before/during import.

- [x] The spec file is clear and easy to read
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors (or valid justification for exceptions)
- [x] %check section passes
- [x] The latest version is packaged
- [x] %goipath is set correctly
- [x] The package complies with the Packaging Guidelines

On import, don't forget to do the following:

- [ ] Add package to https://release-monitoring.org
- [ ] Add package to https://koschei.fedoraproject.org/packages
- [ ] Grant @go-sig group commit privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Comment 2 Package Review 2024-08-01 08:35:29 UTC
Package has been retired from repositories.


Note You need to log in before you can comment on or make changes to this bug.