Red Hat Bugzilla – Bug 219103
Review Request: dvdauthor - Command line DVD authoring tool
Last modified: 2012-04-25 09:42:05 EDT
dvdauthor is a program that will generate a DVD movie from a valid
mpeg2 stream that should play when you put it in a DVD player.
spot, I think it wouldn't hurt to look at this from the FE-Legal POV as the
package touches the DVD and MPEG areas. Could you have a look?
Better to have a dicussion on FE mailing list.
I'll try to review this once legal doubts are cleared.
OK, so in looking at this:
- dvdauthor can't encode mpeg
- dvdauthor can't decode mpeg
- dvdauthor can't play mpeg (duh, it can't encode/decode)
- dvdauthor can mux/demux mpeg (this is how it gets into DVD format)
- dvdauthor can't decode encrypted DVDs
Since mux/demux is ok, this should be ok for Fedora. Lifting FE-Legal.
1. package meets naming and packaging guidelines.
2. specfile is properly named, is cleanly written and uses macros consistently.
3. dist tag is present.
4. build root is correct.
5. license field matches the actual license.
6. license is open source-compatible (GPL). License text included in package.
7. source files match upstream:
8. latest version is being packaged.
9. BuildRequires are proper.
10. package builds in mock (x86_64 devel).
11. rpmlint is silent.
12. final provides and requires are sane:
dvdauthor = 0.6.11-8.fc7
13. no shared libraries are present.
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
18. file permissions are appropriate.
19. %clean is present.
20. %check is not present and no testsuite.
21. no scriptlets present.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. no headers.
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.
Oops forgot to set ASSIGNED.
Devel build done, owners.list and comps-fe7 updated, FC-6 branch requested. Thanks!
Package Change Request
Package Name: dvdauthor
New Branches: el6
Git done (by process-git-requests).