Spec URL: http://folk.ntnu.no/sindrb/packages/flac123.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/flac123-0.0.9-1.src.rpm Description: flac123 is a command-line program for playing FLAC audio files FLAC stands for Free Lossless Audio Codec. Grossly oversimplified, FLAC is similar to Ogg Vorbis, but lossless
packaging is ok. rpmlint is silent. Is grip is also in extras? where can i find files that i can play with flac123?
(In reply to comment #1) > where can i find files that i can play with flac123? You can create them with flac (in package flac) from .wav files.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files md5sum. No upstream is available. 1614e1d1fe5b427ffd5988ea766abcf4 flac123-0.0.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel or any subpackages exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. APPROVED.
Don't forget to CLOSE this review after you finished building package in CVS.