Bug 219114 - Review Request: flac123 - Command-line program for playing FLAC audio files
Summary: Review Request: flac123 - Command-line program for playing FLAC audio files
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-11 03:16 UTC by Sindre Pedersen Bjørdal
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2006-12-28 18:00:40 UTC


Attachments (Terms of Use)

Description Sindre Pedersen Bjørdal 2006-12-11 03:16:42 UTC
Spec URL: http://folk.ntnu.no/sindrb/packages/flac123.spec
SRPM URL: http://folk.ntnu.no/sindrb/packages/flac123-0.0.9-1.src.rpm

Description: 

flac123 is a command-line program for playing FLAC audio files

FLAC stands for Free Lossless Audio Codec. Grossly oversimplified, FLAC
is similar to Ogg Vorbis, but lossless

Comment 1 Parag AN(पराग) 2006-12-11 05:15:09 UTC
packaging is ok.
rpmlint is silent.
Is grip is also in extras?
where can i find files that i can play with flac123?

Comment 2 Till Maas 2006-12-11 07:28:47 UTC
(In reply to comment #1)
> where can i find files that i can play with flac123?

You can create them with flac (in package flac) from .wav files.

Comment 3 Parag AN(पराग) 2006-12-26 05:09:59 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files md5sum. No upstream is available.
1614e1d1fe5b427ffd5988ea766abcf4  flac123-0.0.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel or any subpackages exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
APPROVED.


Comment 4 Parag AN(पराग) 2006-12-27 05:04:17 UTC
Don't forget to CLOSE this review after you finished building package in CVS.


Note You need to log in before you can comment on or make changes to this bug.