Red Hat Bugzilla – Bug 219191
[RHEL5] Include PCIe AER support
Last modified: 2009-12-14 09:10:04 EST
Created attachment 149570 [details]
The upstream patch that adds this support seems to apply cleanly. I'll post
here when added to my test kernels.
This patch had been encorporated into my rhel5 test kernels available here:
I haven't seen any interest in this, so I'm closing it as NOTABUG.
Re-opening this bug, since we have multiple partners requesting this support for RHEL 5.5.
The above patch looks like the original three patches that initially implemented AER support for 2.6.16. There have been numerous bug fixes and feature additions since then that should probably be incorporated. Please look at the backporting notes in BZ 513915 for a list of additional possible patches that you might consider for inclusion.
If you do add this to RHEL5, please be sure to include this patch now in linux-next.
Author: Matt Domsch <Matt_Domsch@dell.com>
Date: Mon Nov 2 11:51:24 2009 -0600
PCI: PCIe AER: honor ACPI HEST FIRMWARE FIRST mode
Feedback from Hidetoshi Seto and Kenji Kaneshige incorporated. This
correctly handles PCI-X bridges, PCIe root ports and endpoints, and
prints debug messages when invalid/reserved types are found in the
HEST. PCI devices not in domain/segment 0 are not represented in
HEST, thus will be ignored.
Today, the PCIe Advanced Error Reporting (AER) driver attaches itself
to every PCIe root port for which BIOS reports it should, via ACPI
However, _OSC alone is insufficient for newer BIOSes. Part of ACPI
4.0 is the new APEI (ACPI Platform Error Interfaces) which is a way
for OS and BIOS to handshake over which errors for which components
each will handle. One table in ACPI 4.0 is the Hardware Error Source
Table (HEST), where BIOS can define that errors for certain PCIe
devices (or all devices), should be handled by BIOS ("Firmware First
mode"), rather than be handled by the OS.
Dell PowerEdge 11G server BIOS defines Firmware First mode in HEST, so
that it may manage such errors, log them to the System Event Log, and
possibly take other actions. The aer driver should honor this, and
not attach itself to devices noted as such.
Furthermore, Kenji Kaneshige reminded us to disallow changing the AER
registers when respecting Firmware First mode. Platform firmware is
expected to manage these, and if changes to them are allowed, it could
break that firmware's behavior.
The HEST parsing code may be replaced in the future by a more
feature-rich implementation. This patch provides the minimum needed
to prevent breakage until that implementation is available.
Reviewed-by: Kenji Kaneshige <firstname.lastname@example.org>
Reviewed-by: Hidetoshi Seto <email@example.com>
Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: Jesse Barnes <firstname.lastname@example.org>