Spec URL: https://eseyman.fedorapeople.org/perl-Test-Future-IO-Impl/perl-Test-Future-IO-Impl.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Test-Future-IO-Impl/perl-Test-Future-IO-Impl-0.14-1.fc37.src.rpm Description: This module contains a collection of acceptance tests for implementations of Future::IO. Fedora Account System Username: eseyman
Copr build: https://copr.fedorainfracloud.org/coprs/build/5862109 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192186-perl-Test-Future-IO-Impl/fedora-rawhide-x86_64/05862109-perl-Test-Future-IO-Impl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Source file is ok Summary is ok Description is ok All tests passed BuildRequires are ok License FIX: Convert a License tag to SPDX format. Fedora moved a license syntax to SPDX https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages. URL and Source0 FIX: Please switch Source and URL from www.cpan.org to metacpan.org https://metacpan.org/dist/Test-Future-IO-Impl/ https://cpan.metacpan.org/authors/id/P/PE/PEVANS/Test-Future-IO-Impl-%{version}.tar.gz FIX: Add 'Conflicts: perl-Future-IO < 0.14' $ rpm -qp --requires perl-Test-Future-IO-Impl-0.14-1.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Errno) 1 perl(Exporter) 1 perl(IO::Handle) 1 perl-libs 1 perl(:MODULE_COMPAT_5.36.1) 1 perl(Socket) 1 perl(Test2::API) 1 perl(Test2::V0) 1 perl(Time::HiRes) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) Binary requires FIX: Please add run-require - perl(IO::Socket::INET) - lib/Test/Future/IO/Impl.pm:109,147 FIX: Remove "Requires: perl(:MODULE_COMPAT_..." line from the spec file. The dependency is now automatically generated with perl-generators. https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_versioned_module_compat_requires_or_perl_libs $ rpm -qp --provides perl-Test-Future-IO-Impl-0.14-1.fc39.noarch.rpm | sort | uniq -c 1 perl(Test::Future::IO::Impl) = 0.14 1 perl-Test-Future-IO-Impl = 0.14-1.fc39 Binary provides are Ok. $ rpmlint ./perl-Test-Future-IO-Impl* ================================== rpmlint session starts =============================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items and provide a new spec file. Resolution: Not Approved
(In reply to Jitka Plesnikova from comment #2) > > License > FIX: Convert a License tag to SPDX format. Fedora moved a license syntax to > SPDX I am a doofus. Fixed. > FIX: Please switch Source and URL from www.cpan.org to metacpan.org > https://metacpan.org/dist/Test-Future-IO-Impl/ Done. > FIX: Add 'Conflicts: perl-Future-IO < 0.14' Added. > FIX: Remove "Requires: perl(:MODULE_COMPAT_..." line from the spec file. The > dependency is now automatically generated with perl-generators. Done. New Spec URL: https://eseyman.fedorapeople.org/perl-Test-Future-IO-Impl/perl-Test-Future-IO-Impl.spec New SRPM URL: https://eseyman.fedorapeople.org/perl-Test-Future-IO-Impl/perl-Test-Future-IO-Impl-0.14-2.fc37.src.rpm
Created attachment 1962063 [details] The .spec file difference from Copr build 5862109 to 5871130
Copr build: https://copr.fedorainfracloud.org/coprs/build/5871130 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192186-perl-Test-Future-IO-Impl/fedora-rawhide-x86_64/05871130-perl-Test-Future-IO-Impl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> FIX: Convert a License tag to SPDX format. Fedora moved a license syntax to > SPDX > https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages. -License: GPL+ or Artistic +License: GPL-1.0-or-later OR Artistic-1.0-Perl Ok > FIX: Please switch Source and URL from www.cpan.org to metacpan.org -URL: http://search.cpan.org/dist/Test-Future-IO-Impl/ -Source0: http://www.cpan.org/authors/id/P/PE/PEVANS/Test-Future-IO-Impl-%{version}.tar.gz +URL: https://metacpan.org/dist/Test-Future-IO-Impl +Source0: https://cpan.metacpan.org/authors/id/P/PE/PEVANS/Test-Future-IO-Impl-%{version}.tar.gz Ok > FIX: Add 'Conflicts: perl-Future-IO < 0.14' > FIX: Please add run-require > - perl(IO::Socket::INET) - lib/Test/Future/IO/Impl.pm:109,147 > FIX: Remove "Requires: perl(:MODULE_COMPAT_..." line from the spec file. The > dependency is now automatically generated with perl-generators. -Requires: perl(:MODULE_COMPAT_%(eval "`/usr/bin/perl -V:version`"; echo $version)) +Requires: perl(IO::Socket::INET) +Conflicts: perl-Future-IO < 0.14 All Ok The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Future-IO-Impl
Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=2196266 Thank you for the review, Jitka.