Spec URL: https://solopasha.fedorapeople.org/for-review/hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/for-review/hyprland-0.25.0-1.fc38.src.rpm Description: Hyprland is a dynamic tiling Wayland compositor based on wlroots that doesn't sacrifice on its looks. It supports multiple layouts, fancy effects, has a very flexible IPC model allowing for a lot of customization, a powerful plugin system and more. Fedora Account System Username: solopasha
Copr build: https://copr.fedorainfracloud.org/coprs/build/5870983 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/05870983-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Waiting for Fedora spins with Hyprland :)
Spec URL: https://solopasha.fedorapeople.org/for-review/hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/for-review/hyprland-0.26.0-1.fc38.src.rpm
Created attachment 1968597 [details] The .spec file difference from Copr build 5870983 to 5998773
Copr build: https://copr.fedorainfracloud.org/coprs/build/5998773 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/05998773-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Any reason for closing this? Happy to review if still of interest to have it packaged.
There's no practical reason for closing this. I just don't want it anymore, sorry. I was sponsored into the packager group not so long ago and all I have is a lot of frustration about package reviews as I need to beg someone to get my package reviewed or wait forever. I will go on maintaining it in my copr.
The fedora packaging process can be very long, but once the package is approved things are much better. Pavel, could I encourage you to re-open and take Benson up on his review offer? My hope is that the sway sig will take interest in assisting as well.
Ok, seems fair, sorry for my rant.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "BSD 2-Clause License", "MIT License", "NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant", "GNU Lesser General Public License v2.1 or later", "*No copyright* MIT License", "FSF All Permissive License", "*No copyright* Creative Commons CC0 1.0". 683 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/hyprland/2192986-hyprland/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/wlr(wlroots0.15-devel, wlroots-devel, wlroots0.14-devel), /usr/include/wlr/backend(wlroots0.15-devel, wlroots-devel, wlroots0.14-devel), /usr/include/wlr/interfaces(wlroots0.15-devel, wlroots-devel, wlroots0.14-devel), /usr/include/wlr/render(wlroots0.15-devel, wlroots-devel, wlroots0.14-devel), /usr/include/wlr/types(wlroots0.15-devel, wlroots- devel, wlroots0.14-devel), /usr/include/wlr/util(wlroots0.15-devel, wlroots-devel, wlroots0.14-devel), /usr/include/wlr/xwayland(wlroots- devel) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hyprland-devel [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: hyprland-0.25.0-1.fc39.x86_64.rpm hyprland-devel-0.25.0-1.fc39.x86_64.rpm hyprland-debuginfo-0.25.0-1.fc39.x86_64.rpm hyprland-debugsource-0.25.0-1.fc39.x86_64.rpm hyprland-0.25.0-1.fc39.src.rpm ============================================= rpmlint session starts ============================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdsdo_dwg')] checks: 31, packages: 5 hyprland-devel.x86_64: W: no-documentation hyprland-debugsource.x86_64: E: files-duplicated-waste 187905 ============= 5 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 11.5 s ============= Rpmlint (debuginfo) ------------------- Checking: hyprland-debuginfo-0.25.0-1.fc39.x86_64.rpm ============================================= rpmlint session starts ============================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyvo2k9hh')] checks: 31, packages: 1 ============== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 6.4 s ============= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 hyprland-devel.x86_64: W: no-documentation hyprland-debugsource.x86_64: E: files-duplicated-waste 187905 4 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 10.3 s Source checksums ---------------- https://github.com/hyprwm/Hyprland/releases/download/v0.25.0/source-v0.25.0.tar.gz : CHECKSUM(SHA256) this package : 0d43297469268457311a916ea3c40bed602c8c8957db81cf862d74c3d5ffbe6b CHECKSUM(SHA256) upstream package : 0d43297469268457311a916ea3c40bed602c8c8957db81cf862d74c3d5ffbe6b Requires -------- hyprland (rpmlib, GLIBC filtered): glibc libEGL.so.1()(64bit) libGLESv2.so.2()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdisplay-info.so.1()(64bit) libdrm.so.2()(64bit) libgbm.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgobject-2.0.so.0()(64bit) libinput.so.10()(64bit) libinput.so.10(LIBINPUT_0.12.0)(64bit) libinput.so.10(LIBINPUT_0.14.0)(64bit) libinput.so.10(LIBINPUT_0.19.0)(64bit) libinput.so.10(LIBINPUT_0.20.0)(64bit) libinput.so.10(LIBINPUT_0.21.0)(64bit) libinput.so.10(LIBINPUT_1.1)(64bit) libinput.so.10(LIBINPUT_1.19)(64bit) libinput.so.10(LIBINPUT_1.2)(64bit) libinput.so.10(LIBINPUT_1.3)(64bit) libinput.so.10(LIBINPUT_1.4)(64bit) libinput.so.10(LIBINPUT_1.5)(64bit) libinput.so.10(LIBINPUT_1.7)(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpixman-1.so.0()(64bit) libseat.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libvulkan.so.1()(64bit) libwayland-client.so.0()(64bit) libwayland-server(x86-64) libwayland-server.so.0()(64bit) libxcb-composite.so.0()(64bit) libxcb-dri3.so.0()(64bit) libxcb-ewmh.so.2()(64bit) libxcb-icccm.so.4()(64bit) libxcb-present.so.0()(64bit) libxcb-render-util.so.0()(64bit) libxcb-render.so.0()(64bit) libxcb-res.so.0()(64bit) libxcb-shm.so.0()(64bit) libxcb-xfixes.so.0()(64bit) libxcb-xinput.so.0()(64bit) libxcb.so.1()(64bit) libxkbcommon.so.0()(64bit) libxkbcommon.so.0(V_0.5.0)(64bit) libxkbcommon.so.0(V_0.8.0)(64bit) rtld(GNU_HASH) xorg-x11-server-Xwayland(x86-64) hyprland-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config hyprland-debuginfo (rpmlib, GLIBC filtered): hyprland-debugsource (rpmlib, GLIBC filtered): Provides -------- hyprland: bundled(udis86) bundled(wlroots) hyprland hyprland(x86-64) hyprland-devel: hyprland-devel hyprland-devel(x86-64) pkgconfig(hyprland) pkgconfig(hyprland-protocols) hyprland-debuginfo: debuginfo(build-id) hyprland-debuginfo hyprland-debuginfo(x86-64) hyprland-debugsource: hyprland-debugsource hyprland-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2192986 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Ruby, Java, R, fonts, Ocaml, SugarActivity, Haskell, Perl, Python, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Try to list file extensions rather than globbing entire directories %{_datadir}/hyprland/ %{_datadir}/wayland-sessions/hyprland.desktop and %{_datadir}/hyprland-protocols/ perhaps use %dir %{_datadir}/hyprland %{_datadir}/hyprland/*.png %{_datadir}/hyprland/*.conf %dir %{_datadir}/wayland-sessions %{_datadir}/wayland-sessions/hyprland.desktop and %dir %{_datadir}/hyprland-protocols %dir %{_datadir}/hyprland-protocols/protocols %{_datadir}/hyprland-protocols/protocols/*.xml What you have is fine as per: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ though listing can help prevent accidental inclusion of incorrect files, though maybe harder to maintain. b) To preserve timestamps instead of: cp subprojects/hyprland-protocols/LICENSE LICENSE-hyprland-protocols cp subprojects/udis86/LICENSE LICENSE-udis86 cp subprojects/wlroots/LICENSE LICENSE-wlroots use: cp -p subprojects/hyprland-protocols/LICENSE LICENSE-hyprland-protocols cp -p subprojects/udis86/LICENSE LICENSE-udis86 cp -p subprojects/wlroots/LICENSE LICENSE-wlroots c) use desktop-file-validate in the check section, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files d) In devel section of spec file please add Requires: %{name}%{?_isa} = %{version}-%{release} e) wlroots and package in Fedora is not too old: https://packages.fedoraproject.org/pkgs/wlroots/wlroots/ It may work instead of bundled one. Checking this. The fork of udis86 has had many changes compared to what is in: https://packages.fedoraproject.org/pkgs/udis86/udis86/ Maybe it is better creating a separate package? f) Some warnings in build log: In file included from ../src/managers/input/InputManager.hpp:3, from ../src/managers/input/Touch.cpp:1: ../src/managers/input/../../defines.hpp:1: warning: "GIT_COMMIT_HASH" redefined 1 | #define GIT_COMMIT_HASH "f27873a6f06dc2f87600edb890f3c38298bfb55f" ../src/managers/KeybindManager.cpp: In static member function ‘static uint64_t CKeybindManager::spawnRaw(std::string)’: ../src/managers/KeybindManager.cpp:625:14: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 625 | write(socket[1], &grandchild, sizeof(grandchild)); | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/managers/KeybindManager.cpp:632:9: warning: ignoring return value of ‘ssize_t read(int, void*, size_t)’ declared with attribu te ‘warn_unused_result’ [-Wunused-result] 632 | read(socket[0], &grandchild, sizeof(grandchild)); | ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ ../src/debug/Log.cpp: In function ‘void Debug::wlrLog(wlr_log_importance, const char*, __va_list_tag*)’: ../src/debug/Log.cpp:18:14: warning: ignoring return value of ‘int vasprintf(char**, const char*, __va_list_tag*)’ declared with att ribute ‘warn_unused_result’ [-Wunused-result] 18 | vasprintf(&outputStr, fmt, args); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ../src/debug/Log.cpp: In function ‘void Debug::log(LogLevel, const char*, ...)’: ../src/debug/Log.cpp:70:14: warning: ignoring return value of ‘int vasprintf(char**, const char*, __va_list_tag*)’ declared with att ribute ‘warn_unused_result’ [-Wunused-result] 70 | vasprintf(&outputStr, fmt, args); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ../src/helpers/MiscFunctions.cpp: In function ‘std::string getFormat(const char*, ...)’: ../src/helpers/MiscFunctions.cpp:164:14: warning: ignoring return value of ‘int vasprintf(char**, const char*, __va_list_tag*)’ decl ared with attribute ‘warn_unused_result’ [-Wunused-result] 164 | vasprintf(&outputStr, fmt, args); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ../hyprctl/main.cpp: In function ‘int setcursorRequest(int, char**)’: ../hyprctl/main.cpp:234:26: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} a nd ‘int’ [-Wsign-compare] 234 | for (size_t i = 2; i < argc; ++i) | ~~^~~~~~ ../hyprctl/main.cpp: In function ‘int main(int, char**)’: ../hyprctl/main.cpp:291:24: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::deque<std::__cxx11:: basic_string<char> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 291 | for (auto i = 0; i < ARGS.size(); ++i) { | ~~^~~~~~~~~~~~~ ../hyprctl/main.cpp:279:10: warning: unused variable ‘bflag’ [-Wunused-variable] 279 | int bflag = 0, sflag = 0, index, c; | ^~~~~ ../hyprctl/main.cpp:279:21: warning: unused variable ‘sflag’ [-Wunused-variable] 279 | int bflag = 0, sflag = 0, index, c; | ^~~~~ ../hyprctl/main.cpp:279:32: warning: unused variable ‘index’ [-Wunused-variable] 279 | int bflag = 0, sflag = 0, index, c; | ^~~~~ ../hyprctl/main.cpp:279:39: warning: unused variable ‘c’ [-Wunused-variable] 279 | int bflag = 0, sflag = 0, index, c; | ^ [
> e) wlroots and package in Fedora is not too old: https://packages.fedoraproject.org/pkgs/wlroots/wlroots/ > It may work instead of bundled one. Checking this. It definitely won't. There were many changes. > The fork of udis86 has had many changes compared to what is in: https://packages.fedoraproject.org/pkgs/udis86/udis86/ >Maybe it is better creating a separate package? Is there some example of such case in the fedora repos? I am not sure how to do that, it'd provide lib, binary, headers with the same names. > f) Some warnings in build log: Those are not scary, I think... Spec URL: https://solopasha.fedorapeople.org/for-review/hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/for-review/hyprland-0.26.0-2.fc38.src.rpm
Created attachment 1970057 [details] The .spec file difference from Copr build 5998773 to 6057874
Copr build: https://copr.fedorainfracloud.org/coprs/build/6057874 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/06057874-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solopasha.fedorapeople.org/for-review/hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/for-review/hyprland-0.27.2-1.fc39.src.rpm
Created attachment 1980339 [details] The .spec file difference from Copr build 6057874 to 6218169
Copr build: https://copr.fedorainfracloud.org/coprs/build/6218169 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/06218169-hyprland/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6219256 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/06219256-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "BSD 2-Clause License", "MIT License", "NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant", "GNU Lesser General Public License v2.1 or later", "*No copyright* MIT License", "FSF All Permissive License", "*No copyright* Creative Commons CC0 1.0". 697 files have unknown license. Detailed output of licensecheck in /home/fedora/2192986-hyprland/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/wayland- sessions(filesystem) [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: hyprland-0.27.2-1.fc39.x86_64.rpm hyprland-devel-0.27.2-1.fc39.x86_64.rpm hyprland-debuginfo-0.27.2-1.fc39.x86_64.rpm hyprland-debugsource-0.27.2-1.fc39.x86_64.rpm hyprland-0.27.2-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmnoiltyp')] checks: 31, packages: 5 hyprland-devel.x86_64: W: no-documentation hyprland-debugsource.x86_64: E: files-duplicated-waste 128106 5 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 2.3 s Rpmlint (debuginfo) ------------------- Checking: hyprland-debuginfo-0.27.2-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzdc5_58m')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 hyprland-devel.x86_64: W: no-documentation hyprland-debugsource.x86_64: E: files-duplicated-waste 128106 4 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 1.9 s Source checksums ---------------- https://github.com/hyprwm/Hyprland/releases/download/v0.27.2/source-v0.27.2.tar.gz : CHECKSUM(SHA256) this package : 1cb1b345fd98e80cb04ba60c7bb42ead6b6ad79898f84b468f3ba87459d99f1f CHECKSUM(SHA256) upstream package : 1cb1b345fd98e80cb04ba60c7bb42ead6b6ad79898f84b468f3ba87459d99f1f Requires -------- hyprland (rpmlib, GLIBC filtered): glibc libEGL.so.1()(64bit) libGLESv2.so.2()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdisplay-info.so.1()(64bit) libdrm.so.2()(64bit) libgbm.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgobject-2.0.so.0()(64bit) libinput.so.10()(64bit) libinput.so.10(LIBINPUT_0.12.0)(64bit) libinput.so.10(LIBINPUT_0.14.0)(64bit) libinput.so.10(LIBINPUT_0.19.0)(64bit) libinput.so.10(LIBINPUT_0.20.0)(64bit) libinput.so.10(LIBINPUT_0.21.0)(64bit) libinput.so.10(LIBINPUT_1.1)(64bit) libinput.so.10(LIBINPUT_1.19)(64bit) libinput.so.10(LIBINPUT_1.2)(64bit) libinput.so.10(LIBINPUT_1.23)(64bit) libinput.so.10(LIBINPUT_1.3)(64bit) libinput.so.10(LIBINPUT_1.4)(64bit) libinput.so.10(LIBINPUT_1.5)(64bit) libinput.so.10(LIBINPUT_1.7)(64bit) libliftoff.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpixman-1.so.0()(64bit) libseat.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libvulkan.so.1()(64bit) libwayland-client.so.0()(64bit) libwayland-server.so.0()(64bit) libxcb-composite.so.0()(64bit) libxcb-dri3.so.0()(64bit) libxcb-ewmh.so.2()(64bit) libxcb-icccm.so.4()(64bit) libxcb-present.so.0()(64bit) libxcb-render-util.so.0()(64bit) libxcb-render.so.0()(64bit) libxcb-res.so.0()(64bit) libxcb-shm.so.0()(64bit) libxcb-xfixes.so.0()(64bit) libxcb-xinput.so.0()(64bit) libxcb.so.1()(64bit) libxkbcommon.so.0()(64bit) libxkbcommon.so.0(V_0.5.0)(64bit) libxkbcommon.so.0(V_0.8.0)(64bit) rtld(GNU_HASH) xorg-x11-server-Xwayland(x86-64) hyprland-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config hyprland(x86-64) hyprland-debuginfo (rpmlib, GLIBC filtered): hyprland-debugsource (rpmlib, GLIBC filtered): Provides -------- hyprland: bundled(udis86) bundled(wlroots) hyprland hyprland(x86-64) hyprland-devel: hyprland-devel hyprland-devel(x86-64) pkgconfig(hyprland) pkgconfig(hyprland-protocols) hyprland-debuginfo: debuginfo(build-id) hyprland-debuginfo hyprland-debuginfo(x86-64) hyprland-debugsource: hyprland-debugsource hyprland-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2192986 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, Ocaml, fonts, SugarActivity, Haskell, Java, Python, PHP, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Latest version is 0.28 which was just released b) Hyprland-protocols seems to be bundled as well. Maybe this should be a separate package? c) Newest release also bundles tracey d) Can the lines %check desktop-file-validate %{buildroot}/%{_datadir}/wayland-sessions/hyprland.desktop be moved after the install part?
a) updated b) yes, xdg-desktop-portal-hyprland also buildrequires it, submitted https://bugzilla.redhat.com/show_bug.cgi?id=2228978 c) it's built only when USE_TRACY_GPU is set, should be safe to remove in %prep d) done Spec URL: https://solopasha.fedorapeople.org/for-review/hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/for-review/hyprland-0.28.0-1.fc38.src.rpm
Created attachment 1981512 [details] The .spec file difference from Copr build 6219256 to 6238758
Copr build: https://copr.fedorainfracloud.org/coprs/build/6238758 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/06238758-hyprland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solopasha.fedorapeople.org/for-review/hyprland.spec SRPM URL: https://solopasha.fedorapeople.org/for-review/hyprland-0.29.0-1.fc38.src.rpm
Created attachment 1985724 [details] The .spec file difference from Copr build 6238758 to 6350453
Copr build: https://copr.fedorainfracloud.org/coprs/build/6350453 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2192986-hyprland/fedora-rawhide-x86_64/06350453-hyprland/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.