Red Hat Bugzilla – Bug 219575
Review Request: php-pear-File - Common file and directory routines
Last modified: 2007-11-30 17:11:51 EST
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-File.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-File-1.2.2-1.src.rpm
Provides easy access to read/write to files along with some common routines
to deal with paths. Also provides interface for handling CSV files.
package meets naming and packaging guidelines.
specfile is properly named, is cleanly written and uses macros consistently.
dist tag is present.
build root is correct.
license field matches the actual license.
license is open source-compatible. License text included in package.
source files match upstream:
latest version is being packaged.
BuildRequires are proper.
rpmlint is silent.
final provides and requires are sane
no shared libraries are present.
package is not relocatable.
owns the directories it creates.
doesn't own any directories it shouldn't.
no duplicates in %files.
file permissions are appropriate.
%clean is present.
no %check is present
no scriptlets present.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no pkgconfig files.
no libtool .la droppings.
not a GUI app.
not a web app.
Very standard PEAR package, everything check out - APPROVED.
Built for devel. Added entry on CVS sync page for FC-5/6. Updated owners.list.
Thanks for the review.
BTW, this bug was not set to block FE-ACCEPT. I'll go ahead and do that for you
Package Change Request
Package Name: php-pear-File
New Branches: EL-5