Bug 2196379 - Lmod does not get integrated into fish
Summary: Lmod does not get integrated into fish
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Lmod
Version: 38
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-05-08 21:17 UTC by stylogey
Modified: 2023-06-05 01:20 UTC (History)
4 users (show)

Fixed In Version: Lmod-8.7.25-2.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-05 01:20:03 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description stylogey 2023-05-08 21:17:22 UTC
profile.fish does not get executed by default, therefore 'module' is unavailable on fish shells unless it gets sourced manually.

Reproducible: Always

Steps to Reproduce:
Set the user shell to fish
Actual Results:  
lmod does not get loaded automatically if the current shell is fish.

Expected Results:  
lmod gets loaded on fish shells.

Comment 1 Orion Poplawski 2023-05-25 03:35:39 UTC
I think we want to coordinate this with the environment-modules package as well.  From a quick look I think we need to install /usr/share/lmod/8.7.24/init/profile.fish into /etc/fish.conf.d/.  I'm not sure what the equivalent startup file for environment-modules - perhaps /usr/share/Modules/init/fish?  But if there is one we'll want to install it via alternatives like is done with the sh/csh startup files.

Comment 2 Xavier Delaruelle 2023-05-26 05:26:49 UTC
environment-modules startup file for fish shell is /usr/share/Modules/init/fish.

It seems that the accurate location for a software-specific configuration snippet is /usr/share/fish/vendor_conf.d/. This is the directory used by other packages on fedora (on my system I found that snapd and nano-default-editor are using this spot). I would like to add that I tried to setup things in /etc/fish/conf.d, but this directory seems ignored by the fish version installed on Fedora.

So I will add a new alternatives follower file /usr/share/fish/vendor_conf.d/modules.sh in environment-modules package.

Comment 3 Xavier Delaruelle 2023-05-27 08:55:57 UTC
On environment-modules side, fixed with environment-modules-5.3.0-2.fc39.

A /usr/share/fish/vendor_conf.d/modules.fish link to /usr/share/Modules/init/fish is added. This link is managed with alternatives.

Comment 4 Orion Poplawski 2023-05-27 20:59:08 UTC
Thank you Xavier.  Similar fish support has been added to Lmod-8.7.25-2.

Comment 5 Fedora Update System 2023-05-27 21:05:31 UTC
FEDORA-2023-c1bde94b11 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c1bde94b11

Comment 6 Fedora Update System 2023-05-28 03:09:22 UTC
FEDORA-2023-c1bde94b11 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c1bde94b11`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c1bde94b11

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-06-05 01:20:03 UTC
FEDORA-2023-c1bde94b11 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.