Spec URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-latest.spec SRPM URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-latest-3.25-1.el9.src.rpm Description: gpsd is a service daemon that mediates access to a GPS sensor connected to the host computer by serial or USB interface, making its data on the location/course/velocity of the sensor available to be queried on TCP port 2947 of the host computer. With gpsd, multiple GPS client applications (such as navigational and war-driving software) can share access to a GPS without contention or loss of data. Also, gpsd responds to queries with a format that is substantially easier to parse than NMEA 0183. This package is intended to follow the latest upstream release. No devel package is provided for other applications to use the libgps library. Fedora Account System Username: mlichvar This is an alternative package of gpsd to the one already present in EPEL, which cannot be upgraded to not break the libgps API/ABI.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5901380 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2196598-gpsd-latest/fedora-rawhide-x86_64/05901380-gpsd-latest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-latest.spec SRPM URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-latest-3.25-2.el9.src.rpm This fixes some of the issues reported by rpmlint. The binaries are not PIE because scons is filtering the -spec=.../hardened-ld option from linker flags. No idea how to avoid that.
Created attachment 1964008 [details] The .spec file difference from Copr build 5901380 to 5911271
Copr build: https://copr.fedorainfracloud.org/coprs/build/5911271 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2196598-gpsd-latest/fedora-rawhide-x86_64/05911271-gpsd-latest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Would it make more sense to review new packages for OLD versions for backward compatibility, maybe shipping just limited set of libraries with different ABI? And to update original gpsd package to recent version, matching its own version in Fedora rawhide? The new package could provide just minimal support to work with older clients relying on old ABI. I think using gpsd<version> is more common than -latest suffix. I expect we usually have packages without version with the more recent version and only backward compatibility include version. At least it were this way with openssl.
I agree with Petr on the naming. The -latest suffix usually becomes misleading over time and is discouraged in the packaging guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple This package should be named gpsd3.25. Alternatively, the existing gpsd package could be updated from 3.23 to 3.25 if a compatibility package (gpsd3.23) is created to provide the old library soname. Such a transition can be somewhat tricky to get right, but does have the benefit of the unversioned package being the latest.
Spec URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-latest.spec SRPM URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-latest-3.25-3.fc39.src.rpm Subpackages were dropped. libgps was dropped as it's linked statically with the included clients. The python module and the packet parsing library it depends on are now in private directory. I'm still looking for a better name for the package.
Created attachment 1970694 [details] The .spec file difference from Copr build 5911271 to 6073736
Copr build: https://copr.fedorainfracloud.org/coprs/build/6073736 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2196598-gpsd-latest/fedora-rawhide-x86_64/06073736-gpsd-latest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-minimal.spec SRPM URL: https://fedorapeople.org/~mlichvar/tmp/gpsd-minimal-3.25-3.fc39.src.rpm The package was renamed to gpsd-minimal to avoid using the problematic -latest suffix and make it obvious not all upstream features are provided. I think it's ready for review.
Ping? If you don't have time to do a formal review, would you be ok with someone else taking over?
The guidance from the Fedora Packaging Committee was that this package, in its current state, is not a good fit for EPEL. Their recommended solution is to do one of the following: - Have an "oldish"/stable version in EPEL. - Have a latest version in COPR, which breaks library API. - Occasionally update the oldish version with the EPEL process for incompatible updates. https://pagure.io/packaging-committee/issue/1283