Created attachment 1963829 [details] Correct help text present in VM Details tab Description of problem: There's missing help text explaining CPU calculations in Catalog drawer for "CPU | Memory" field and misleading help texts for the same field present in more places: - Template Details tab - Review and create VirtualMachine page (customize VM) - VirtualMachineInstance Details tab Version-Release number of selected component (if applicable): 4.13 How reproducible: always Steps to Reproduce: 1. Access Catalog drawer or any of the problematic places mentioned above 2. Check "CPU | Memory" field in the page Actual results: Missing help text explaining CPU calculations in Catalog drawer. And in the misleading help texts, it says "This VirtualMachine ..." although it's for the other resource, not a VM, or a VM is just being created, not existing yet, which is confusing. That means 4 places with presence of "CPU | Memory" waiting for improvement. Expected results: The expected results for Templates and for VMIs are not clear yet. But it's clear that the help texts shouldn't be confusing. They shouldn't display "This VirtualMachine has ..." anywhere else except VM Details page. For missing help text in the drawer and incorrect help text when customizing VM, "The VirtualMachine will have ..." could be displayed instead. See https://bugzilla.redhat.com/show_bug.cgi?id=2172390#c16 Additional info: Possible solutions for Templates and VMIs: The help text may reflect the resource that is related to the provided information. Maybe "This Template has..."... or "This VirtualMachineInstance has...". Another solution is to make it more universal by NOT mentioning "VirtualMachine" or any specific resource at all, so we could use the same help text for "CPU | Memory" field anywhere in the whole UI. Maybe we could display "This resource has 1 sockets, 1 threads, and 3 cores." That would be the best, IMO.
I would vote for avoiding "This resource" terminology. I think users would expect something more concrete and easy to understand, so I like the first suggestion much better ("This Template has..."... or "This VirtualMachineInstance has..."). It's also more aligned with what we have for this bug https://bugzilla.redhat.com/show_bug.cgi?id=2172390#c16
(In reply to Yifat Menchik from comment #5) > I would vote for avoiding "This resource" terminology. I think users would > expect something more concrete and easy to understand, so I like the first > suggestion much better ("This Template has..."... or "This > VirtualMachineInstance has..."). It's also more aligned with what we have > for this bug https://bugzilla.redhat.com/show_bug.cgi?id=2172390#c16 Makes sense, just it would make the code more complicated, as we use the same component for VMs, Templates, etc..
@apinnick can you please advise? Thank you.
(In reply to Yifat Menchik from comment #7) > @apinnick can you please advise? Thank you. I also prefer the first option, to have the help text say "Template" or "VirtualMachineInstance" instead of "Resource". Can the component detect its context so that the correct resource name would appear?
(In reply to Avital Pinnick from comment #8) > (In reply to Yifat Menchik from comment #7) > > @apinnick can you please advise? Thank you. > > I also prefer the first option, to have the help text say "Template" or > "VirtualMachineInstance" instead of "Resource". Can the component detect its > context so that the correct resource name would appear? I don't know yet. But it should be doable somehow.
Hi Avital, and what would you suggest for VirtualMachineTemplate resource help text? Which option is better? 'The VirtualMachineTemplate has {{sockets}} sockets, {{threads}} threads, and {{cores}} cores.' or 'The Template has {{sockets}} sockets, {{threads}} threads, and {{cores}} cores.' Thanks.
Hi Avital, another, 3rd option for templates help text could also be: 'The template has {{sockets}} sockets, {{threads}} threads, and {{cores}} cores.' - see the small 't' for template.
(In reply to Hilda Stastna from comment #11) > Hi Avital, > > another, 3rd option for templates help text could also be: > 'The template has {{sockets}} sockets, {{threads}} threads, and {{cores}} > cores.' > - see the small 't' for template. LGTM
verified on kubevirt-console-plugin-rhel9:v4.14.0-2121