Red Hat Bugzilla – Bug 219751
Review Request: python-TurboMail - Multi-threaded mail queue manager for TurboGears applications.
Last modified: 2007-11-30 17:11:51 EST
Spec URL: http://people.redhat.com/lmacken/SPECS/python-TurboMail.spec
SRPM URL: http://people.redhat.com/lmacken/SRPMS/python-TurboMail-2.0.3-1.src.rpm
TurboMail is a TurboGears extension, meaning that it starts up and shuts down
alongside any TurboGears applications you write, in the same way that visit
tracking and identity do. TurboMail uses built-in Python modules for SMTP
communication and MIME e-mail creation, but greatly simplifies these tasks by
performing the grunt-work for you. Additionally, TurboMail is multi-threaded,
allowing for single or batch enqueueing and background delivery of mail.
The spec looks really clean, just one small comment (nitpicking :-):
If the package is noarch why do you need to set the CFLAGS? :-)
No need to change the spec because of this detail you do it when importing.
The full review will follow soon.
Building fails in mock because the spec file is missing
OK, better yet, make that
since the installation requires it to be present.
Assuming that my previous suggestion is followed this is the revision:
Review for release 1:
* RPM name is OK
* Source TurboMail-2.0.3.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* License is correct (MIT) and OK for Fedora
* Spec is clear and well written
* The package should contain the text of the license
superfuluous CFLAGS when building.
If you merge these two changes the package is APPROVED. You can do the changes
After the building of this package do not forget to close this bug as
* Fri Dec 15 2006 Luke Macken <email@example.com> 2.0.3-2
- Add TurboGears to BuildRequires
- Remove superfluous CFLAGS
- Add LICENSE.txt
Imported into CVS, added to owners.list, requested FC-6 CVS branch, tagged and
built for devel.