Red Hat Bugzilla – Bug 219949
Review Request: perl-File-Which - Portable implementation of the 'which' utility
Last modified: 2007-11-30 17:11:51 EST
File::Which is a portable implementation (in Perl) of 'which', and can
be used to get the absolute filename of an executable program
installed somewhere in your PATH, or just check for its existence. It
includes the command-line utility 'pwhich' which has the same function
Note: this module will help improving the test coverage of Perl::Critic.
Taking this for review
* rpmlint is silent
* free software, license not included
* follow packaging and naming guidelines
* match upstream
* sane provides
* %files and directory ownership right
I would have approved it if I were doing the review.
Thanks. Hey feel free to remove me if i have not posted any initial comments and
take that package review under REVIEW. :)
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMS.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible. License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ %check used
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
All tests successful, 5 subtests skipped.
Files=3, Tests=13, 0 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
Thanks for the review.
Package imported and built for FC-5, FC-6, and devel.