Red Hat Bugzilla – Bug 219950
Review Request: perl-Pod-Spell - A formatter for spellchecking Pod
Last modified: 2011-03-06 14:18:20 EST
Pod::Spell is a Pod formatter whose output is good for spellchecking.
Pod::Spell rather like Pod::Text, except that it doesn't put much
effort into actual formatting, and it suppresses things that look like
Perl symbols or Perl jargon (so that your spellchecking program won't
complain about mystery words like "$thing" or "Foo::Bar" or "hashref").
Note: this module will help improving the test coverage of Perl::Critic.
Taking this for review
* rpmlint is silent
* free software, license file not included
* follow naming and packaging guidelines
* match upstream
* sane provides
Provides: perl(Pod::Spell) = 1.01 perl(Pod::Wordlist)
* %files section and directory ownership right
I would have APPROVED it, but I am not doing the review ;-)
Thanks. Hey feel free to remove me if i have not posted any initial comments and
take that package review under REVIEW. :)
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMS.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible. License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ %check used
PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
# Running under perl version 5.008008 for linux
# Current time local: Sun Dec 17 23:54:19 2006
# Current time GMT: Mon Dec 18 04:54:19 2006
# Using Test.pm version 1.25
# Perl version 5.008008 under linux
# Pod::Spell version 1.01
# Pod::Wordlist version 1.01
# I see 1001 keys in %Pod::Wordlist::Wordlist
# Universe tests...
# I'm in ASCII world.
# "A" is 65
# "\n" is 10
# "\r" is 13
# "\cm" is 13
# "\cj" is 10
# "\t" is 9
# "\f" is 12
# "\b" is 8
# "\a" is 7
# "\e" is 27
# Universe tests complete.
# Real tests.
# Wrote >psin.pod (length 123 bytes)
# Opened <psin.pod and >psout.txt
# Created parser object.
# Destroyed objects.
# psout.txt is 26 bytes long.
# Opened <psout.txt
# Done reading 26 bytes from psout.txt.
# Content: TEST myormsp snickh.
# Converted content is indeed 'TEST myormsp snickh'.
# Unlinked psout.txt
# Unlinked psin.pod
+ Provides: perl(Pod::Spell) = 1.01 perl(Pod::Wordlist)
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
Thanks for the review.
Package imported and built for FC-5, FC-6, and devel.
Package Change Request
Package Name: perl-Pod-Spell
New Branches: el4
Git done (by process-git-requests).
perl-Pod-Spell-1.01-2.el4 has been submitted as an update for Fedora EPEL 4.
perl-Pod-Spell-1.01-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.