Bug 219956 - Review Request: perl-IO-Capture - Abstract Base Class to build modules to capture output
Summary: Review Request: perl-IO-Capture - Abstract Base Class to build modules to cap...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-17 18:17 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-18 15:57:30 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-12-17 18:17:32 UTC
Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-IO-Capture.spec

SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-IO-Capture-0.05-1.src.rpm

Description:
The IO::Capture Module defines an abstract base class that can be used
to create any number of useful sub-classes that capture output being
sent on a filehandle such as STDOUT or STDERR.

Note: this module will help improving the test coverage of Perl::Critic
(Module::CPANTS::Analyse --> Test::Kawlitee --> Perl::Critic)

Comment 1 Ville Skyttä 2006-12-17 18:36:20 UTC
Approved, please just fix the order of arguments to find(1) in %install (-depth
before -type d) before the first build, see spectemplate-perl.spec in rpmdevtools.

$ find /tmp -type d -depth -name foo >/dev/null
find: warning: you have specified the -depth option after a non-option argument
-type, but options are not positional (-depth affects tests specified before it
as well as those specified after it).  Please specify options before other
arguments.

$ find /tmp -depth -type d -name foo >/dev/null
(no warnings)

Comment 2 Jose Pedro Oliveira 2006-12-17 19:46:45 UTC
(In reply to comment #1)
> Approved, please just fix the order of arguments to find(1) in %install (-depth
> before -type d) before the first build, see spectemplate-perl.spec in rpmdevtools.

Done.

Packaged imported and built (only devel at the moment). I will close
this ticket as soon as this package gets built for FC-5 and FC-6.

Thanks for the review,
jpo

Comment 3 Jose Pedro Oliveira 2006-12-18 15:57:30 UTC
Also built for FC-5 and FC-6.


Note You need to log in before you can comment on or make changes to this bug.