Bug 219962 - Review Request: crystal-clear - Crystal Clear KDE Icon set
Review Request: crystal-clear - Crystal Clear KDE Icon set
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-12-17 16:21 EST by Chitlesh GOORAH
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-12-27 18:10:22 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Chitlesh GOORAH 2006-12-17 16:21:08 EST
Spec URL: http://tux.u-strasbg.fr/~chit/crystal-clear/crystal-clear.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/crystal-clear/crystal-clear-20050622-1.src.rpm
Description:
Crystal Clear is a KDE Icon set
Comment 1 Parag AN(पराग) 2006-12-18 05:02:16 EST
rpmlint is not silent on RPM
W: crystal-clear no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

W: crystal-clear dangling-symlink
/usr/share/icons/Crystal-Clear/48x48/apps/kmenu.png
/usr/share/icons/Bluecurve/48x48/apps/gnome-main-menu.png
The symbolic link points nowhere.

W: crystal-clear symlink-should-be-relative
/usr/share/icons/Crystal-Clear/48x48/apps/kmenu.png
/usr/share/icons/Bluecurve/48x48/apps/gnome-main-menu.png
Absolute symlinks are problematic eg. when working with chroot environments.

W: crystal-clear dangling-symlink
/usr/share/icons/Crystal-Clear/32x32/apps/kmenu.png
/usr/share/icons/Bluecurve/32x32/apps/gnome-main-menu.png
The symbolic link points nowhere.

W: crystal-clear symlink-should-be-relative
/usr/share/icons/Crystal-Clear/32x32/apps/kmenu.png
/usr/share/icons/Bluecurve/32x32/apps/gnome-main-menu.png
Absolute symlinks are problematic eg. when working with chroot environments.

W: crystal-clear dangling-symlink
/usr/share/icons/Crystal-Clear/22x22/apps/kmenu.png
/usr/share/icons/Bluecurve/24x24/apps/gnome-main-menu.png
The symbolic link points nowhere.

W: crystal-clear symlink-should-be-relative
/usr/share/icons/Crystal-Clear/22x22/apps/kmenu.png
/usr/share/icons/Bluecurve/24x24/apps/gnome-main-menu.png
Absolute symlinks are problematic eg. when working with chroot environments.

W: crystal-clear dangling-symlink
/usr/share/icons/Crystal-Clear/16x16/apps/kmenu.png
/usr/share/icons/Bluecurve/16x16/apps/gnome-main-menu.png
The symbolic link points nowhere.

W: crystal-clear symlink-should-be-relative
/usr/share/icons/Crystal-Clear/16x16/apps/kmenu.png
/usr/share/icons/Bluecurve/16x16/apps/gnome-main-menu.png
Absolute symlinks are problematic eg. when working with chroot environments.


Comment 2 Chitlesh GOORAH 2006-12-18 12:56:57 EST
That's true.
As you have seen I've added links to fedora logo as kmenu icon.
Is there any better solution for this ?
Comment 3 Parag AN(पराग) 2006-12-18 23:52:57 EST
Can you check whether
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217557#c17
is helpful to you. I have already suggested this in your 
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217557 bug. 
Comment 4 Chitlesh GOORAH 2006-12-20 14:48:15 EST
Sounds like you didn't understand what make those rpmlint warnings.

It is not about the normal kde issues for "common", but about making the Fedora
Logo appear on kmenu when this icon set is used!
Comment 5 Parag AN(पराग) 2006-12-21 03:00:39 EST
Then you can ask for help on Fedora-extras mailing list.
Comment 6 Chitlesh GOORAH 2006-12-21 04:44:30 EST
SPEC: http://tux.u-strasbg.fr/~chit/crystal-clear/crystal-clear.spec

rpmlint /home/chitlesh/rpmbuild/RPMS/noarch/crystal-clear-20050622-2.noarch.rpm
W: crystal-clear no-documentation
W: crystal-clear dangling-relative-symlink
/usr/share/icons/Crystal-Clear/48x48/apps/kmenu.png
../../../Bluecurve/48x48/apps/gnome-main-menu.png
W: crystal-clear dangling-relative-symlink
/usr/share/icons/Crystal-Clear/32x32/apps/kmenu.png
../../../Bluecurve/32x32/apps/gnome-main-menu.png
W: crystal-clear dangling-relative-symlink
/usr/share/icons/Crystal-Clear/22x22/apps/kmenu.png
../../../Bluecurve/24x24/apps/gnome-main-menu.png
W: crystal-clear dangling-relative-symlink
/usr/share/icons/Crystal-Clear/16x16/apps/kmenu.png
../../../Bluecurve/16x16/apps/gnome-main-menu.png
Comment 7 Parag AN(पराग) 2006-12-21 05:31:22 EST
Quick update
Included tarball and upstream tarball md5sum matches 
adb7962b585c8ad12adc3b82246edb35  CrystalClear.tar.gz

According to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=389499, you also
need to replace firefox.png icon or remove it while installing.
Thanks for giving this link Chitlesh.

I have one question, how to check that a given individual icon is LGPL/GPL or
non-LPGL. Do you know about this? 

Also where is LGPL written? I mean no license text is added in RPM

Also,
URL: http://linuxcult.com/node/10 is not working.
Comment 8 Chitlesh GOORAH 2006-12-22 03:30:04 EST
(In reply to comment #7)
> Quick update
> Included tarball and upstream tarball md5sum matches 
> adb7962b585c8ad12adc3b82246edb35  CrystalClear.tar.gz
> 
> According to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=389499, you also
> need to replace firefox.png icon or remove it while installing.
> Thanks for giving this link Chitlesh.

I've asked in the FE mailing list to see what they think of it, since I've once
read that its only trademarks by the authors, however this is an icon set. The
situation might be different.

> I have one question, how to check that a given individual icon is LGPL/GPL or
> non-LPGL. Do you know about this? 
> Also where is LGPL written? I mean no license text is added in RPM
>

see the commented link below the url:
http://www.kde-look.org/content/show.php?content=25668
 
> Also,
> URL: http://linuxcult.com/node/10 is not working.
> 

Ok, I'll use http://www.everaldo.com/crystal.html as URL
Comment 10 Parag AN(पराग) 2006-12-26 23:59:46 EST
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM 
- rpmlint is NOT for RPMS but I found them harmless.
+ source files match upstream.
adb7962b585c8ad12adc3b82246edb35  CrystalClear.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible. 
- But License text is NOT included in package.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ icon set installed successfully.
APPROVED.

Note You need to log in before you can comment on or make changes to this bug.