SRPM URL: http://home.comcast.net/~ckweyl/perl-Text-Tree-1.0-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Text-Tree.spec Description: Allows the caller to develop a tree structure, using nested arrays of strings and references. Once developed, the whole tree can be printed as a diagram, with the root of the tree at the top, and child nodes formatted horizontally below them.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. 83232a177d199d90894cf3f1d30d534c Text-Tree-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/Text-Tree....ok All tests successful. Files=1, Tests=13, 0 wallclock secs ( 0.02 cusr + 0.00 csys = 0.02 CPU) +Provides: perl(Text::Tree) = 1.0 + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED.
Imported and building for devel; branches requested for FC-[56]. Thanks for the review! :)