Red Hat Bugzilla – Bug 219971
Review Request: perl-Text-Tree - Format a simple tree of strings into a textual tree graph
Last modified: 2007-11-30 17:11:51 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-Text-Tree-1.0-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Text-Tree.spec
Allows the caller to develop a tree structure, using nested arrays of
strings and references. Once developed, the whole tree can be printed as a
diagram, with the root of the tree at the top, and child nodes formatted
horizontally below them.
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMS.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible. License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ %check used
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
All tests successful.
Files=1, Tests=13, 0 wallclock secs ( 0.02 cusr + 0.00 csys = 0.02 CPU)
+Provides: perl(Text::Tree) = 1.0
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
Imported and building for devel; branches requested for FC-.
Thanks for the review! :)