Bug 220198 - kdump service should show an appropriate message
Summary: kdump service should show an appropriate message
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kexec-tools
Version: 5.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Neil Horman
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-12-19 16:48 UTC by Akira Imamura
Modified: 2007-11-30 22:07 UTC (History)
3 users (show)

Fixed In Version: 5.0.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-02-13 17:39:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
This patch is based on -151.el5 and, can fix this problem. (736 bytes, patch)
2006-12-19 16:48 UTC, Akira Imamura
no flags Details | Diff

Description Akira Imamura 2006-12-19 16:48:08 UTC
Description of problem:
kdump service should show an appropriate message when it fails to start up
due to unspecified crashkernel.

Version-Release number of selected component (if applicable):
kexec-tools-1.101-151.el5

How reproducible:
Always

Steps to Reproduce:
1. Load 1st kernel that crashkernel parameter is not specified.
2. Run "service kdump start"
3.
  
Actual results:
No appropriate message that lets users know what happens to the service
is shown.

Expected results:
The following message should be shown.

No crashkernel parameter is specified for the running kernel (<kernel version>)


Additional info:

Comment 1 Akira Imamura 2006-12-19 16:48:08 UTC
Created attachment 144014 [details]
This patch is based on -151.el5 and, can fix this problem.

Comment 2 Neil Horman 2006-12-19 19:07:04 UTC
No, that patch won't work.  For what its worth, I don't think there is anything
particularly misleading or bad about the current error that kexec provides, but
if you insist on checking for the presence of crashkernel on the commandline the
regex needs to handle malformed crashkernel specifications that are missing a
parameter, or those which use an alternate unit of measure to specify memory
sizes (K or G rather than M, or the use of lower case letters, which the kernel
allows).

I'm checking a more accurate test into -152.el5

Comment 3 Akira Imamura 2006-12-19 19:35:00 UTC
According to Comment #2, the following statement in load_kdump() should be
modified, shouldn't it?

KDUMP_COMMANDLINE=`echo $KDUMP_COMMANDLINE | sed -e
's/crashkernel=[0-9]\+M@[0-9]\+M//g'`

I guess $MEM_RESERVED can be used there.

Comment 4 Jay Turner 2007-02-13 17:36:59 UTC
Fix confirmed with kexec-tools-1.101-164.el5.


Note You need to log in before you can comment on or make changes to this bug.