Bug 220417 - Loading of SGI images is broken due to bad endian swap code
Summary: Loading of SGI images is broken due to bad endian swap code
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: DevIL
Version: 6
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ian Chapman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-12-21 03:51 UTC by Scott A. Friedman
Modified: 2007-11-30 22:11 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2007-01-02 21:46:07 UTC


Attachments (Terms of Use)
patch to fix borked endian byteswapping (788 bytes, patch)
2006-12-21 03:51 UTC, Scott A. Friedman
no flags Details | Diff

Description Scott A. Friedman 2006-12-21 03:51:48 UTC
Description of problem:
This used to work just fine - but someone broke it along the way by trying to be
clever. Anyway, attached patch uses internal linux byteswap functionality when
requested in place of broken 'asm' 

Version-Release number of selected component (if applicable):
1.6.8-0.10.rc2

How reproducible:
Try loading an SGI image file - you will get an INVALID HEADER error because the
header values are not converted from big endian to little endian (when required)

Steps to Reproduce:
1.
2.
3.
  
Actual results:
Image file doesn't load

Expected results:
Image file should load!

Additional info:
I can attach an sgi rgb file for testing - but the patch I included works as
long as it is added to the spec file.

Comment 1 Scott A. Friedman 2006-12-21 03:51:48 UTC
Created attachment 144159 [details]
patch to fix borked endian byteswapping

Comment 2 Ian Chapman 2007-01-02 21:46:07 UTC
Thanks for patch. It's been added to the next version which should appear in the
repo shortly.


Note You need to log in before you can comment on or make changes to this bug.