Bug 220533 – units: non-failsafe install-info usage, info files removed from index on update

Bug 220533 - units: non-failsafe install-info usage, info files removed from index on update

Summary:	units: non-failsafe install-info usage, info files removed from index on update

Status:	CLOSED RAWHIDE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	units (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Harald Hoyer
QA Contact:	Ben Levenson
Docs Contact:

URL:
Whiteboard:
Keywords:	Reopened

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2006-12-21 17:32 EST by Ville Skyttä
Modified:	2007-11-30 17:11 EST (History)
CC List:	1 user (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2007-01-24 04:38:57 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Dpm (547 bytes, text/x-patch) 2007-01-23 11:54 EST, Ville Skyttä	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Ville Skyttä 2006-12-21 17:32:03 EST

units's install-info usage is not failsafe, see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#info

Additionally, the install-info --delete in %preun should be wrapped inside "if
[ $1 -eq 0 ]" to prevent the info files from being removed from the index on
upgrades.

Comment 1 Florian La Roche 2007-01-23 08:47:12 EST

Fixed in -2.

Thanks,

Florian La Roche

Comment 2 Ville Skyttä 2007-01-23 11:54:43 EST

Created attachment 146317 [details]
Dpm

Oops, -2 wraps %post inside [ "$1" = 0 ], that can never happen and should be
in %preun instead, fix attached.

Comment 3 Ville Skyttä 2007-01-23 11:57:27 EST

In case you're wondering, the "Dpm" in the patch description in comment 2 is
just an odd way of saying "fix info removal from index" ;) (accidental Enter hit
while looking for backspace)

Comment 4 Harald Hoyer 2007-01-24 04:38:57 EST

fixed previous fix

Note You need to log in before you can comment on or make changes to this bug.