Bug 220533 - units: non-failsafe install-info usage, info files removed from index on update
Summary: units: non-failsafe install-info usage, info files removed from index on update
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: units
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Harald Hoyer
QA Contact: Ben Levenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-12-21 22:32 UTC by Ville Skyttä
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-01-24 09:38:57 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Dpm (547 bytes, text/x-patch)
2007-01-23 16:54 UTC, Ville Skyttä 		no flags Details
View All

Description Ville Skyttä 2006-12-21 22:32:03 UTC 
units's install-info usage is not failsafe, see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#info

Additionally, the install-info --delete in %preun should be wrapped inside "if
[ $1 -eq 0 ]" to prevent the info files from being removed from the index on
upgrades.
Comment 1 Florian La Roche 2007-01-23 13:47:12 UTC 
Fixed in -2.

Thanks,

Florian La Roche
Comment 2 Ville Skyttä 2007-01-23 16:54:43 UTC 
Created attachment 146317 [details]
Dpm

Oops, -2 wraps %post inside [ "$1" = 0 ], that can never happen and should be
in %preun instead, fix attached.
Comment 3 Ville Skyttä 2007-01-23 16:57:27 UTC 
In case you're wondering, the "Dpm" in the patch description in comment 2 is
just an odd way of saying "fix info removal from index" ;) (accidental Enter hit
while looking for backspace)
Comment 4 Harald Hoyer 2007-01-24 09:38:57 UTC 
fixed previous fix
Note You need to log in before you can comment on or make changes to this bug.