Bug 220703 - Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library
Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widg...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Mamoru TASAKA
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2006-12-23 12:53 EST by Damien Durand
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-01-29 12:15:09 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Damien Durand 2006-12-23 12:53:07 EST
Spec URL:http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm.spec
SRPM URL: http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm-0.2.0-1.src.rpm
Description: libgtksourceviewmm is a C++ wrapper for the gtksourceview widget 
library. It offers all the power of gtksourceview with an interface 
familiar to c++ developers, including users of the gtkmm library
Comment 1 Mamoru TASAKA 2006-12-23 13:33:23 EST
A quick note:
* /usr/lib/gtksourceviewmm-1.0 should be in -devel package.
* The existence of /usr/lib/pkgconfig/libgtksourceviewmm-1.0.pc and
  its contents means that -devel package should Require some
  other packages (pkgconfig + else).
  Check "Requires" section of
Comment 2 Mamoru TASAKA 2006-12-23 13:37:58 EST
Oops.. Also:
* COPYING must be in main package. I think AUTHORS should also
  be in main package (and also README?)
* ChangeLog, NEWS should be added in -devel package.
Comment 3 Damien Durand 2006-12-23 14:14:49 EST
New Spec file :
New SRPM file :

- add libdir/gtksourceviewmm-1.0 in devel package
- add Changelog and NEWS in devel package
- add gtkmm24-devel and gtksourceview-devel in devel package
Comment 4 Mamoru TASAKA 2006-12-23 14:33:59 EST
* I think adding "pkgconfig" to Requires for -devel package is
  safe for .pc file
* I didn't notice it, however, this is licensed under LGPL, not
Comment 5 Mamoru TASAKA 2006-12-25 05:07:53 EST
Additional comment:
Inclusion of m4 file usually means that -devel package
should require automake.
Comment 6 Mamoru TASAKA 2007-01-05 10:35:46 EST
Comment 7 Damien Durand 2007-01-12 16:56:26 EST
Sorry for the delay

SPEC file :

- add automake and pkgconfig in devel package
Comment 8 Mamoru TASAKA 2007-01-13 11:36:08 EST
Okay. All issues are now fixed correctly.

One issue.
* Timestamps
  - -devel package contains many header files and keeping
     timestamps on these files are recommended.
     Please use
make INSTALL="install -c -p" DESTDIR=$RPM_BUILD_ROOT install

Other things are okay.
  This package (libgtksoureviewmm) is APPROVED by me.
Comment 9 Mamoru TASAKA 2007-01-19 08:44:13 EST
(Please close this bug as CLOSED NEXTRELEASE
 when rebuilding is done)
Comment 10 Mamoru TASAKA 2007-01-29 12:15:09 EST
(Closing as NEXTRELEASE as this is already imported into
 If there is any problem, please let me know it.)

Note You need to log in before you can comment on or make changes to this bug.