Spec URL: https://people.freedesktop.org/~whot/libei/libei.spec SRPM URL: https://people.freedesktop.org/~whot/libei/libei-0.99.1-1.fc38.src.rpm Description: libei is a library to Emulate Input. It allows clients to talk to an EIS implementatation (Emulated Input Server), typically a Wayland compositor and send input events via that connection. The EIS implementation replays those events as if they came from physical devices. Fedora Account System Username: whot
Copr build: https://copr.fedorainfracloud.org/coprs/build/5927016 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2207838-libei/fedora-rawhide-x86_64/05927016-libei/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://people.freedesktop.org/~whot/libei/libei.spec SRPM URL: https://people.freedesktop.org/~whot/libei/libei-0.99.1-1.fc38.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5927056 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2207838-libei/fedora-rawhide-x86_64/05927056-libei/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
sigh, probably helps if I copy to the right host... let's try again: Spec URL: https://people.freedesktop.org/~whot/libei/libei.spec SRPM URL: https://people.freedesktop.org/~whot/libei/libei-0.99.1-1.fc38.src.rpm
Created attachment 1964988 [details] The .spec file difference from Copr build 5927056 to 5927057
Copr build: https://copr.fedorainfracloud.org/coprs/build/5927057 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2207838-libei/fedora-rawhide-x86_64/05927057-libei/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
> %ldconfig_scriptlets This can be dropped because it doesn't do anything since RHEL 8 / Fedora 28.
Spec review: > BuildRequires: git-core > BuildRequires: meson gcc libxml2 pkgconf-pkg-config systemd-devel > BuildRequires: python3 python3-attrs python3-jinja2 > BuildRequires: python3-rpm-macros Having each dependency on its own line is preferred, since it makes easier to diff over time > %package -n libeis-devel > Summary: Library for Emulated Input Serverse Development Package > Requires: %{name}%{?_isa} = %{version}-%{release} This must require libeis, not libei > %package -n liboeffis-devel > Summary: Library for XDG RemoteDesktop Portal Setup Development Package > Requires: %{name}%{?_isa} = %{version}-%{release} This must require liboeffis, not libei > %ldconfig_scriptlets This can be dropped because it doesn't do anything since RHEL 8 / Fedora 28. > %doc COPYING This must be "%license COPYING".
Thanks for the review, everything addressed including one extra issue: libeis/liboeffis don't need to Requires: libei, so dropped that line No more %{name} usage either, spelled out the individual package names everywhere. Less chance of that being wrong. Spec URL: https://people.freedesktop.org/~whot/libei/libei.spec SRPM URL: https://people.freedesktop.org/~whot/libei/libei-0.99.1-2.fc38.src.rpm Note for us puny humans: I bumped to -2 so the src.rpm file name has changed.
Created attachment 1965294 [details] The .spec file difference from Copr build 5927057 to 5929565
Copr build: https://copr.fedorainfracloud.org/coprs/build/5929565 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2207838-libei/fedora-rawhide-x86_64/05929565-libei/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Another small thing: > %{_libdir}/libei.so.* > [...] > %{_libdir}/libeis.so.* > [...] > %{_libdir}/liboeffis.so.* The soversions need to be tracked directly in the spec file so that soname bumps are noticed. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
Fixed, thanks. Bumped to -3, just ftr. Spec URL: https://people.freedesktop.org/~whot/libei/libei.spec SRPM URL: https://people.freedesktop.org/~whot/libei/libei-0.99.1-3.fc38.src.rpm
Everything looks good now, so... PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/libei
libei-0.99.1-1.fc39 is now in rawhide F38 builds will be as soon as koji lets me build them. Thanks for the quick review!