Bug 2208361 - Review Request: golang-github-iovisor-gobpf - Go bindings for creating BPF programs
Summary: Review Request: golang-github-iovisor-gobpf - Go bindings for creating BPF pr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Link Dupont
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-05-18 17:22 UTC by Davide Cavalca
Modified: 2023-07-18 01:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-09 03:42:54 UTC
Type: ---
Embargoed:
link: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-05-18 17:22:16 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-iovisor-gobpf/golang-github-iovisor-gobpf.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-iovisor-gobpf/golang-github-iovisor-gobpf-0.2.0-1.fc39.src.rpm

Description:
Go bindings for creating BPF programs.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-05-18 17:22:18 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=101293766

Comment 2 Link Dupont 2023-06-30 16:19:35 UTC
- [x] The spec file is clear and easy to read
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors (or valid justification for exceptions)
- [x] %check section passes
- [x] The latest version is packaged
- [x] %goipath is set correctly
- [x] The package complies with the Packaging Guidelines

rpmlint detected a couple of .gitignore files that get included when the examples are packaged.

> golang-github-iovisor-gobpf-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-iovisor-gobpf-devel/examples/bcc/perf/.gitignore
> golang-github-iovisor-gobpf-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-iovisor-gobpf-devel/examples/tracepipe/.gitignore

Maybe remove them during %prep?

> %prep
> %goprep
> %autopatch -p1
> rm examples/bcc/perf/.gitignore
> rm examples/tracepipe/.gitignore

Package approved; consider making the change above on or after import. On import, don't forget to do the following:

- [ ] Add package to https://release-monitoring.org
- [ ] Add package to https://koschei.fedoraproject.org/packages
- [ ] Grant @go-sig group commit privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Comment 3 Fedora Admin user for bugzilla script actions 2023-07-09 03:25:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-iovisor-gobpf

Comment 4 Fedora Update System 2023-07-09 03:41:01 UTC
FEDORA-2023-0dc0048b1a has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0dc0048b1a

Comment 5 Fedora Update System 2023-07-09 03:42:54 UTC
FEDORA-2023-0dc0048b1a has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2023-07-09 03:59:16 UTC
FEDORA-2023-29bdc61a32 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-29bdc61a32

Comment 7 Fedora Update System 2023-07-10 02:09:46 UTC
FEDORA-2023-29bdc61a32 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-29bdc61a32 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-29bdc61a32

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-07-18 01:23:41 UTC
FEDORA-2023-29bdc61a32 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.