Bug 2208400 - Review Request: python-pytest-qt - pytest support for PyQt and PySide applications
Summary: Review Request: python-pytest-qt - pytest support for PyQt and PySide applica...
Keywords:
Status: CLOSED DUPLICATE of bug 2268677
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL: http://github.com/pytest-dev/pytest-qt
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-05-18 21:46 UTC by Davide Cavalca
Modified: 2025-01-03 03:22 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-03 03:22:24 UTC
Type: ---
Embargoed:
orion: fedora-review?


Attachments (Terms of Use)
The .spec file difference from Copr build 5933220 to 6848274 (1.14 KB, patch)
2024-01-02 15:13 UTC, Fedora Review Service
no flags Details | Diff

Description Davide Cavalca 2023-05-18 21:46:29 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-pytest-qt/python-pytest-qt.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-pytest-qt/python-pytest-qt-4.2.0-1.fc39.src.rpm

Description:
pytest-qt is a pytest plugin that allows programmers to write tests for PyQt5,
PyQt6, PySide2 and PySide6 applications.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-05-18 21:46:31 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=101300979

Comment 2 Fedora Review Service 2023-05-18 21:53:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5933220
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2208400-python-pytest-qt/fedora-rawhide-x86_64/05933220-python-pytest-qt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Orion Poplawski 2023-11-29 03:52:45 UTC
Tests are failing currently:

=================================== FAILURES ===================================
____________________________________ test_1 ____________________________________
CALL ERROR: Exceptions caught in Qt event loop:
________________________________________________________________________________
Traceback (most recent call last):
  File "/tmp/pytest-of-mockbuild/pytest-0/test_exceptions_dont_leak0/test_exceptions_dont_leak.py", line 9, in event
    raise RuntimeError('event processed')
RuntimeError: event processed
________________________________________________________________________________
Traceback (most recent call last):
  File "/tmp/pytest-of-mockbuild/pytest-0/test_exceptions_dont_leak0/test_exceptions_dont_leak.py", line 9, in event
    raise RuntimeError('event processed')
RuntimeError: event processed
________________________________________________________________________________
----------------------------- Captured stderr call -----------------------------
Exceptions caught in Qt event loop:
________________________________________________________________________________
Traceback (most recent call last):
  File "/tmp/pytest-of-mockbuild/pytest-0/test_exceptions_dont_leak0/test_exceptions_dont_leak.py", line 9, in event
    raise RuntimeError('event processed')
RuntimeError: event processed
________________________________________________________________________________
Exceptions caught in Qt event loop:
________________________________________________________________________________
Traceback (most recent call last):
  File "/tmp/pytest-of-mockbuild/pytest-0/test_exceptions_dont_leak0/test_exceptions_dont_leak.py", line 9, in event
    raise RuntimeError('event processed')
RuntimeError: event processed
________________________________________________________________________________
____________________________________ test_2 ____________________________________
qapp = <PyQt6.QtWidgets.QApplication object at 0x7fac29064410>
    def test_2(qapp):
        assert called
        gc.collect()
>       assert weak_ref() is None
E       assert <test_exceptions_dont_leak.MyWidget object at 0x7fac28e085f0> is None
E        +  where <test_exceptions_dont_leak.MyWidget object at 0x7fac28e085f0> = weak_ref()
test_exceptions_dont_leak.py:24: AssertionError
=========================== short test summary info ============================
FAILED test_exceptions_dont_leak.py::test_1 - Failed: CALL ERROR: Exceptions ...
FAILED test_exceptions_dont_leak.py::test_2 - assert <test_exceptions_dont_le...
============================== 2 failed in 0.05s ===============================

Comment 4 Davide Cavalca 2024-01-02 05:50:31 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-pytest-qt/python-pytest-qt.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-pytest-qt/python-pytest-qt-4.3.1-1.fc40.src.rpm

Changelog:
- update to 4.3.1
- build and package the docs as well

Comment 5 Fedora Review Service 2024-01-02 15:13:01 UTC
Created attachment 2006846 [details]
The .spec file difference from Copr build 5933220 to 6848274

Comment 6 Fedora Review Service 2024-01-02 15:13:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6848274
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2208400-python-pytest-qt/fedora-rawhide-x86_64/06848274-python-pytest-qt/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Package Review 2025-01-03 00:45:27 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 8 Orion Poplawski 2025-01-03 03:22:24 UTC
Looks like this was reviewed separately.  Sorry I dropped the ball.

*** This bug has been marked as a duplicate of bug 2268677 ***


Note You need to log in before you can comment on or make changes to this bug.