Red Hat Bugzilla – Bug 220862
Review Request: php-channel-phpunit - Add phpunit channel to pear
Last modified: 2007-11-30 17:11:52 EST
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-channel-phpunit.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-channel-phpunit-1.0-1.src.rpm Description: This package adds the phpunit channel which allows PEAR packages from this channel to be installed.
As i proposed this solution i think i could not review it ;) Who own %{pear_phpdir}/.channels ? This package probably should own it, or you could post a RFE against php-pear.
I think php-pear already owns it: # rpm -qf /usr/share/pear/.channels/ php-pear-1.4.9-4
After IRC meeting, all is OK. Build fine, and allow the build of new php-pear-PHPUnit in mock. REVIEW * no source files * package meets naming and packaging guidelines (no special guideline for channels). * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (BSD). * BuildRequires are proper. * %clean is present. * package builds in mock (development). * package installs properly * rpmlint : W: php-channel-phpunit no-documentation * final provides are sane: php-channel-phpunit = 1.0-1.fc6 * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation No version for the .xml file, but i think using 1.0 is OK. APPROVED
Oups... You probably should provide a virtual Provide php-channel(pear.phpunit.de) I will propose this for the PHP Guidelines
- src rpm checked into cvs - Virtual provides added in -2 release - added entry to owners.list - built on devel - requested branch on fc5/6 Thanks for the review!
oops removed branch request for fc5/6, forgot that this is for fc7+ only.
New Package CVS Request ======================= Package Name: php-channel-phpunit Short Description: Add phpunit channel to pear Owners: chris.stone@gmail.com Branches: EP-4 EP-5 InitialCC:
oops Branches should only be EP-5, not EP-4 New Package CVS Request ======================= Package Name: php-channel-phpunit Short Description: Add phpunit channel to pear Owners: chris.stone@gmail.com Branches: EP-5 InitialCC:
Crap, removing fedora-cvs flag, this is only on devel and I don't think there is an EP branch for devel at all.
Okay enterprise linux stuff straightened out now :) Package Change Request ====================== Package Name: php-channel-phpunit New Branches: EL-5