Bug 2208692 - Review Request: rust-rstest_macros - Rust fixture based test framework
Summary: Review Request: rust-rstest_macros - Rust fixture based test framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2208693
TreeView+ depends on / blocked
 
Reported: 2023-05-20 00:35 UTC by Michel Lind
Modified: 2023-05-24 01:17 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-05-24 01:14:05 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-05-20 00:35:21 UTC
Spec URL: https://salimma.fedorapeople.org/rust-rstest_macros.spec
SRPM URL: https://salimma.fedorapeople.org/rust-rstest_macros-0.17.0-1.fc37.src.rpm

Description:
Rust fixture based test framework. It use procedural macro to implement
fixtures and table based tests.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-05-20 13:56:23 UTC
Did you look at the generated spec file at all, or at the rust2rpm output?
I don't know how to make ERROR FIXME NO LICENSE FILES even more obvious ...

Comment 2 Michel Lind 2023-05-20 20:44:14 UTC
Argh, sorry, was too focused trying to get the crate that depends on this working. Update coming; sent a PR upstream

https://github.com/la10736/rstest/pull/196

Comment 4 Davide Cavalca 2023-05-20 21:31:02 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is disabled to handle circular dependency with rstests
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-05-21 01:56:36 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rstest_macros

Comment 6 Fedora Update System 2023-05-21 03:37:28 UTC
FEDORA-2023-50690dd8b5 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-50690dd8b5

Comment 7 Fedora Update System 2023-05-21 03:38:59 UTC
FEDORA-2023-8d2ef11e0c has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d2ef11e0c

Comment 8 Fedora Update System 2023-05-22 01:05:42 UTC
FEDORA-2023-8d2ef11e0c has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8d2ef11e0c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d2ef11e0c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-05-22 02:04:31 UTC
FEDORA-2023-50690dd8b5 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-50690dd8b5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-50690dd8b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-05-24 01:14:05 UTC
FEDORA-2023-8d2ef11e0c has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-05-24 01:17:26 UTC
FEDORA-2023-50690dd8b5 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.