Spec URL: https://skim.cz/tmp/perl-Lingua-EN-Syllable.spec SRPM URL: https://skim.cz/tmp/perl-Lingua-EN-Syllable-0.31-1.fc39.src.rpm Description: count the number of syllables in English words Fedora Account System Username: mspacek
Perl module was orphaned (https://src.fedoraproject.org/rpms/perl-Lingua-EN-Syllable)
Spec files on URL and in source rpm are different. Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-require 'coreutils', it is needed for %{_fixperms} TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Lingua-EN-Syllable-0.31-1.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Exporter) 1 perl-libs 1 perl(strict) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Lingua-EN-Syllable-0.31-1.fc39.noarch.rpm | sort | uniq -c 1 perl(Lingua::EN::Syllable) = 0.31 1 perl-Lingua-EN-Syllable = 1:0.31-1.fc39 Binary provides are Ok. $ rpmlint ./perl-Lingua-EN-Syllable* ================================== rpmlint session starts ================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s === Rpmlint is ok FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved
@jplesnik Thank you for the review. Updated spec and src files: Spec URL: https://skim.cz/tmp/perl-Lingua-EN-Syllable-2/perl-Lingua-EN-Syllable.spec SRPM URL: https://skim.cz/tmp/perl-Lingua-EN-Syllable-2/perl-Lingua-EN-Syllable-0.31-1.fc39.src.rpm
> FIX: Please add build-require 'coreutils', it is needed for %{_fixperms} Ok. > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. Ok. > FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} > directories > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Ok. Resolution: Approved