Bug 2209131 - Review Request: rust-nu-cmd-lang - Nushell's core language commands
Summary: Review Request: rust-nu-cmd-lang - Nushell's core language commands
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-05-22 18:58 UTC by Michel Lind
Modified: 2023-06-07 17:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-07 17:18:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-05-22 18:58:44 UTC
Spec URL: https://salimma.fedorapeople.org/rust-nu-cmd-lang.spec
SRPM URL: https://salimma.fedorapeople.org/rust-nu-cmd-lang-0.80.0-1.fc38.src.rpm

Description:
Nushell's core language commands.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-05-22 19:58:05 UTC
This currently fails to build because it needs nu-* v0.80.0. Do you have a koji side tag I can run a test scratch build against?

Comment 2 Michel Lind 2023-05-23 02:59:26 UTC
Ah yes, sorry!

f39-build-side-67708

https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=67708&order=-build_id&latest=1

Comment 3 Fabio Valentini 2023-05-23 11:50:44 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds without errors on f39-build-side-67708
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- patches are justified and documented
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-05-23 14:40:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-cmd-lang


Note You need to log in before you can comment on or make changes to this bug.